[GitHub] [arrow-datafusion] pjmore commented on pull request #1153: Generic constant expression evaluation

[GitBox <gi...@apache.org>]

pjmore commented on pull request #1153:
URL: https://github.com/apache/arrow-datafusion/pull/1153#issuecomment-950524208


   @rdettai  made a good point on my initial implementation about how stable functions should be evaluatable in a constant context.   Maybe the constant folding optimizer should have a flag to allow for evaluating stable functions in a constant context if provided execution properties? This might be useful even if it's just to make the option available to  the partition pruning logic. Doing this would allow the special case for now in the expression simplifier to be removed. While this doesn't matter much at the moment because it is the only stable function if more stable built-ins are added this might start mattering. Besides the question of constant evaluating stable functions this looks good to me, 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org