You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/21 22:46:10 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #30455: [WIP][BUILD] Upgrade to Scala 2.13.4
dongjoon-hyun opened a new pull request #30455:
URL: https://github.com/apache/spark/pull/30455
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732378156
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36166/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732338407
**[Test build #131565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131565/testReport)** for PR 30455 at commit [`67cbc0b`](https://github.com/apache/spark/commit/67cbc0bbc468a19347fb2135dd52904e6018e246).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529081547
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -362,7 +362,7 @@ case class Join(
left.constraints
case RightOuter =>
right.constraints
- case FullOuter =>
+ case _ =>
Review comment:
It was difficult to track one-by-one. Logically, this is the rest of the previous patterns. So, I decided to skip that comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732399652
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36171/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732437628
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732352212
**[Test build #131569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131569/testReport)** for PR 30455 at commit [`5661918`](https://github.com/apache/spark/commit/56619185468a162228798a5685ed63935a610c07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732638286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732359744
**[Test build #131570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131570/testReport)** for PR 30455 at commit [`eb19da4`](https://github.com/apache/spark/commit/eb19da49589b5391c9947867ea926400b8fe56b2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732407318
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36170/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732444018
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131570/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732452216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732487921
**[Test build #131573 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131573/testReport)** for PR 30455 at commit [`7214398`](https://github.com/apache/spark/commit/721439826beee1b4c8e58108ab7091e44db4cf9f).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732415342
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36171/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732338407
**[Test build #131565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131565/testReport)** for PR 30455 at commit [`67cbc0b`](https://github.com/apache/spark/commit/67cbc0bbc468a19347fb2135dd52904e6018e246).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732437628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732277998
**[Test build #131558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131558/testReport)** for PR 30455 at commit [`6c26b2d`](https://github.com/apache/spark/commit/6c26b2d4890f5d837795221e37dcf33638410fb4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732417830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732415355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732602657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732638286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732637050
**[Test build #131590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131590/testReport)** for PR 30455 at commit [`7214398`](https://github.com/apache/spark/commit/721439826beee1b4c8e58108ab7091e44db4cf9f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732437569
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36174/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732417167
**[Test build #131566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131566/testReport)** for PR 30455 at commit [`dab110c`](https://github.com/apache/spark/commit/dab110ca6defae07ce2b6c30cb862a269662f6fc).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732344112
**[Test build #131566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131566/testReport)** for PR 30455 at commit [`dab110c`](https://github.com/apache/spark/commit/dab110ca6defae07ce2b6c30cb862a269662f6fc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732422508
This PR is ready for review finally.
Could you review this PR, @srowen , @HyukjinKwon , @maropu , @LuciferYang ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732344112
**[Test build #131566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131566/testReport)** for PR 30455 at commit [`dab110c`](https://github.com/apache/spark/commit/dab110ca6defae07ce2b6c30cb862a269662f6fc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r534634388
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala
##########
@@ -298,7 +299,10 @@ private[ml] object RFormulaParser extends RegexParsers {
private val expr = (sum | term)
private val formula: Parser[ParsedRFormula] =
- (label ~ "~" ~ expr) ^^ { case r ~ "~" ~ t => ParsedRFormula(r, t.asTerms.terms) }
+ (label ~ "~" ~ expr) ^^ {
+ case r ~ "~" ~ t => ParsedRFormula(r, t.asTerms.terms)
Review comment:
Feel free to make a PR, @retronym . :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732407354
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36170/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732406655
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529063258
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -362,7 +362,7 @@ case class Join(
left.constraints
case RightOuter =>
right.constraints
- case FullOuter =>
+ case _ =>
Review comment:
nit: for readability, how about leaving a comment like this?
```
case _ => // FullOuter
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732317591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529082045
##########
File path: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
##########
@@ -757,15 +757,15 @@ private[spark] object JsonProtocol {
def taskResourceRequestMapFromJson(json: JValue): Map[String, TaskResourceRequest] = {
val jsonFields = json.asInstanceOf[JObject].obj
- jsonFields.map { case JField(k, v) =>
+ jsonFields.collect { case JField(k, v) =>
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732406668
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131565/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732415355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732384273
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732488470
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732384244
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36167/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529081280
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -362,7 +362,7 @@ case class Join(
left.constraints
case RightOuter =>
right.constraints
- case FullOuter =>
+ case _ =>
Review comment:
Ya. I thought like that, but actually, there are many missing patterns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529082129
##########
File path: streaming/src/main/scala/org/apache/spark/streaming/util/FileBasedWriteAheadLog.scala
##########
@@ -293,7 +293,7 @@ private[streaming] object FileBasedWriteAheadLog {
val startTime = startTimeStr.toLong
val stopTime = stopTimeStr.toLong
Some(LogInfo(startTime, stopTime, file.toString))
- case None =>
+ case None | Some(_) =>
Review comment:
We can use like that~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732351909
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131558/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732444010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732511289
Thank you always, @maropu !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732417836
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131566/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732368599
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36167/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732452191
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36174/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732417830
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732359744
**[Test build #131570 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131570/testReport)** for PR 30455 at commit [`eb19da4`](https://github.com/apache/spark/commit/eb19da49589b5391c9947867ea926400b8fe56b2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732384288
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36167/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732501470
**[Test build #131590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131590/testReport)** for PR 30455 at commit [`7214398`](https://github.com/apache/spark/commit/721439826beee1b4c8e58108ab7091e44db4cf9f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732602657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732407343
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-731652823
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36087/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732634256
Thank you, @srowen and @HyukjinKwon .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-731654849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732384273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732351897
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732452216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732504530
The new pattern match is strict and the `master` branch change can easily break it. I'll merge this first with @maropu 's approval and do the follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732444010
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529081950
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
##########
@@ -120,7 +120,7 @@ class GenericArrayData(val array: Array[Any]) extends ArrayData {
if (!o2.isInstanceOf[Double] || ! java.lang.Double.isNaN(o2.asInstanceOf[Double])) {
return false
}
- case _ => if (!o1.equals(o2)) {
+ case _ => if (o1.getClass != o2.getClass || o1 != o2) {
Review comment:
Yes. We cannot use `equals` and we cannot use `!=` here due to the following.
```scala
scala> Float.NaN == Float.NaN
val res2: Boolean = false
scala> Float.NaN.equals(Float.NaN)
val res3: Boolean = true
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732443504
**[Test build #131570 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131570/testReport)** for PR 30455 at commit [`eb19da4`](https://github.com/apache/spark/commit/eb19da49589b5391c9947867ea926400b8fe56b2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529083852
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -322,7 +322,9 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
case (a: Array[Byte], b: Array[Byte]) => util.Arrays.equals(a, b)
case (a: ArrayBasedMapData, b: ArrayBasedMapData) =>
a.keyArray == b.keyArray && a.valueArray == b.valueArray
- case (a, b) => a != null && a.equals(b)
+ case (a: Double, b: Double) if a.isNaN && b.isNaN => true
+ case (a: Float, b: Float) if a.isNaN && b.isNaN => true
+ case (a, b) => a != null && a == b
Review comment:
Oh, I see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732436717
**[Test build #131569 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131569/testReport)** for PR 30455 at commit [`5661918`](https://github.com/apache/spark/commit/56619185468a162228798a5685ed63935a610c07).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732407343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732390911
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36170/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-731654849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732501470
**[Test build #131590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131590/testReport)** for PR 30455 at commit [`7214398`](https://github.com/apache/spark/commit/721439826beee1b4c8e58108ab7091e44db4cf9f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732351268
**[Test build #131558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131558/testReport)** for PR 30455 at commit [`6c26b2d`](https://github.com/apache/spark/commit/6c26b2d4890f5d837795221e37dcf33638410fb4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732406655
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732488475
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131573/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732352212
**[Test build #131569 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131569/testReport)** for PR 30455 at commit [`5661918`](https://github.com/apache/spark/commit/56619185468a162228798a5685ed63935a610c07).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-731654870
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36087/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732378192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529081157
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -322,7 +322,9 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
case (a: Array[Byte], b: Array[Byte]) => util.Arrays.equals(a, b)
case (a: ArrayBasedMapData, b: ArrayBasedMapData) =>
a.keyArray == b.keyArray && a.valueArray == b.valueArray
- case (a, b) => a != null && a.equals(b)
+ case (a: Double, b: Double) if a.isNaN && b.isNaN => true
+ case (a: Float, b: Float) if a.isNaN && b.isNaN => true
+ case (a, b) => a != null && a == b
Review comment:
Yes. It's a compilation error. We cannot use `.equals` for `Any` type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732360519
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36166/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732406030
**[Test build #131565 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131565/testReport)** for PR 30455 at commit [`67cbc0b`](https://github.com/apache/spark/commit/67cbc0bbc468a19347fb2135dd52904e6018e246).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732378192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732351897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30455:
URL: https://github.com/apache/spark/pull/30455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732488470
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [WIP][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-731648601
**[Test build #131481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131481/testReport)** for PR 30455 at commit [`f0d9fff`](https://github.com/apache/spark/commit/f0d9fff41dbc7abee59a26fa2cfb41cce2e2b630).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r529062466
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
##########
@@ -322,7 +322,9 @@ case class Literal (value: Any, dataType: DataType) extends LeafExpression {
case (a: Array[Byte], b: Array[Byte]) => util.Arrays.equals(a, b)
case (a: ArrayBasedMapData, b: ArrayBasedMapData) =>
a.keyArray == b.keyArray && a.valueArray == b.valueArray
- case (a, b) => a != null && a.equals(b)
+ case (a: Double, b: Double) if a.isNaN && b.isNaN => true
+ case (a: Float, b: Float) if a.isNaN && b.isNaN => true
+ case (a, b) => a != null && a == b
Review comment:
(Just a question) Are the changes above related to this PR?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala
##########
@@ -120,7 +120,7 @@ class GenericArrayData(val array: Array[Any]) extends ArrayData {
if (!o2.isInstanceOf[Double] || ! java.lang.Double.isNaN(o2.asInstanceOf[Double])) {
return false
}
- case _ => if (!o1.equals(o2)) {
+ case _ => if (o1.getClass != o2.getClass || o1 != o2) {
Review comment:
ditto: Is this change above related to this PR?
##########
File path: streaming/src/main/scala/org/apache/spark/streaming/util/FileBasedWriteAheadLog.scala
##########
@@ -293,7 +293,7 @@ private[streaming] object FileBasedWriteAheadLog {
val startTime = startTimeStr.toLong
val stopTime = stopTimeStr.toLong
Some(LogInfo(startTime, stopTime, file.toString))
- case None =>
+ case None | Some(_) =>
Review comment:
We cannot write it like `case _ =>` here?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -362,7 +362,7 @@ case class Join(
left.constraints
case RightOuter =>
right.constraints
- case FullOuter =>
+ case _ =>
Review comment:
nit: for readability, how about leaving the comment like this?
```
case _ => // FullOuter
```
##########
File path: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
##########
@@ -757,15 +757,15 @@ private[spark] object JsonProtocol {
def taskResourceRequestMapFromJson(json: JValue): Map[String, TaskResourceRequest] = {
val jsonFields = json.asInstanceOf[JObject].obj
- jsonFields.map { case JField(k, v) =>
+ jsonFields.collect { case JField(k, v) =>
Review comment:
Ah, I see. The compilation of `map` in this case fails in v2.13.4?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732277998
**[Test build #131558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131558/testReport)** for PR 30455 at commit [`6c26b2d`](https://github.com/apache/spark/commit/6c26b2d4890f5d837795221e37dcf33638410fb4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-731654866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] retronym commented on a change in pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
retronym commented on a change in pull request #30455:
URL: https://github.com/apache/spark/pull/30455#discussion_r534630859
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala
##########
@@ -298,7 +299,10 @@ private[ml] object RFormulaParser extends RegexParsers {
private val expr = (sum | term)
private val formula: Parser[ParsedRFormula] =
- (label ~ "~" ~ expr) ^^ { case r ~ "~" ~ t => ParsedRFormula(r, t.asTerms.terms) }
+ (label ~ "~" ~ expr) ^^ {
+ case r ~ "~" ~ t => ParsedRFormula(r, t.asTerms.terms)
Review comment:
For future reference, a slightly cleaner way to express this in a warning free way is:
```
((label <~ "~") ~ expr ) ^^ {
case r ~ t => ParsedRFormula(r, t.asTerms.terms)
}
```
It also avoids duplicating the `"~"` token in the parser and the action.
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala
##########
@@ -298,7 +299,10 @@ private[ml] object RFormulaParser extends RegexParsers {
private val expr = (sum | term)
private val formula: Parser[ParsedRFormula] =
- (label ~ "~" ~ expr) ^^ { case r ~ "~" ~ t => ParsedRFormula(r, t.asTerms.terms) }
+ (label ~ "~" ~ expr) ^^ {
+ case r ~ "~" ~ t => ParsedRFormula(r, t.asTerms.terms)
Review comment:
For future reference, a slightly cleaner way to express this in a warning free way is:
```scala
((label <~ "~") ~ expr ) ^^ {
case r ~ t => ParsedRFormula(r, t.asTerms.terms)
}
```
It also avoids duplicating the `"~"` token in the parser and the action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732417368
**[Test build #131573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131573/testReport)** for PR 30455 at commit [`7214398`](https://github.com/apache/spark/commit/721439826beee1b4c8e58108ab7091e44db4cf9f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732317573
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36160/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732417368
**[Test build #131573 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131573/testReport)** for PR 30455 at commit [`7214398`](https://github.com/apache/spark/commit/721439826beee1b4c8e58108ab7091e44db4cf9f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732437639
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131569/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4 to improve exhaustivity
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732317591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30455: [SPARK-33513][BUILD] Upgrade to Scala 2.13.4
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30455:
URL: https://github.com/apache/spark/pull/30455#issuecomment-732303971
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36160/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org