You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2025/08/04 13:12:31 UTC

[PR] [core] Fix commit kind for non-pk table in row-level command [paimon]

Zouxxyy opened a new pull request, #6025:
URL: https://github.com/apache/paimon/pull/6025

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Fix the commit kind when performing row-level changes on non-pk table [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6025:
URL: https://github.com/apache/paimon/pull/6025#discussion_r2252935554


##########
paimon-api/src/main/java/org/apache/paimon/Snapshot.java:
##########
@@ -496,13 +496,13 @@ public boolean equals(Object o) {
     /** Type of changes in this snapshot. */
     public enum CommitKind {
 
-        /** Changes flushed from the mem table. */
+        /** New data is appended to the table and no data is deleted. */

Review Comment:
   `New data files are appended to the table and no data file is deleted.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Fix the commit kind when performing row-level changes on non-pk table [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #6025:
URL: https://github.com/apache/paimon/pull/6025#issuecomment-3311011964

   +1
   
   > FileStoreCommitImpl.noConflictsOrFail should contains check for deletion vectors.
   
   We can finish this in next PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Fix the commit kind when performing row-level changes on non-pk table [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6025:
URL: https://github.com/apache/paimon/pull/6025#discussion_r2252935835


##########
paimon-api/src/main/java/org/apache/paimon/Snapshot.java:
##########
@@ -496,13 +496,13 @@ public boolean equals(Object o) {
     /** Type of changes in this snapshot. */
     public enum CommitKind {
 
-        /** Changes flushed from the mem table. */
+        /** New data is appended to the table and no data is deleted. */
         APPEND,
 
         /** Changes by compacting existing data files. */
         COMPACT,
 
-        /** Changes that clear up the whole partition and then add new records. */
+        /** New data is added to overwrite existing data or just delete existing data. */

Review Comment:
   `New data files are added to overwrite existing data files or just delete existing data files.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Fix the commit kind when performing row-level changes on non-pk table [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #6025:
URL: https://github.com/apache/paimon/pull/6025


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Fix the commit kind when performing row-level changes on non-pk table [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6025:
URL: https://github.com/apache/paimon/pull/6025#discussion_r2361997504


##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -426,8 +428,23 @@ private void reportCommit(
         commitMetrics.reportCommit(commitStats);
     }
 
+    private boolean hasDelete(

Review Comment:
   `containsFileDeletionOrDeletionVectors`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org