[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4569: [ARTEMIS-4159] Support duplicate cache size configuration per address

["jbertram (via GitHub)" <gi...@apache.org>]

jbertram commented on code in PR #4569:
URL: https://github.com/apache/activemq-artemis/pull/4569#discussion_r1283586569


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java:
##########
@@ -1456,6 +1458,10 @@ protected Pair<String, AddressSettings> parseAddressSettings(final Node node) {
             addressSettings.setEnableMetrics(XMLUtil.parseBoolean(child));
          } else if (ENABLE_INGRESS_TIMESTAMP.equalsIgnoreCase(name)) {
             addressSettings.setEnableIngressTimestamp(XMLUtil.parseBoolean(child));
+         } else if (ID_CACHE_SIZE.equalsIgnoreCase(name)) {
+            int idCacheSize = XMLUtil.parseInt(child);
+            Validators.GT_ZERO.validate(ID_CACHE_SIZE, idCacheSize);

Review Comment:
   I wonder if this should use `Validators.GE_ZERO` so that users can disable the cache for specific addresses even if a "parent" address-setting uses a value > 0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org