You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/12/14 18:58:13 UTC
Review Request 64620: Fixed `os::chown` error message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64620/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
Description
-------
getpwnam(3) only sets `errno` if there is an error. To detect
the (most common) case where the user account is successfully
not found, we need to clear `errno` and verify that it is
still clear on failure.
Diffs
-----
3rdparty/stout/include/stout/os/posix/chown.hpp e2214acbd726e8f84480e97f01ca240096a75877
Diff: https://reviews.apache.org/r/64620/diff/1/
Testing
-------
sudo make check (Fedora 26)
Thanks,
James Peach
Re: Review Request 64620: Fixed `os::chown` error message.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64620/#review193833
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64620']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64620
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64620/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2311 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2334 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2267 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2290 ms total)
[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (298352 ms total)
[ PASSED ] 825 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
10 FAILED TESTS
YOU HAVE 205 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64620/logs/mesos-tests-stderr.log):
```
I1214 19:47:10.223968 6088 slave.cpp:3401] Shutting down framework 12I1214 19:47:09.577996 3572 exec.cpp:162] Version: 1.5.0
I1214 19:47:09.600975 7320 exec.cpp:237] Executor registered on agent 126ccccf-11fd-4095-86e5-5582b1bc902c-S0
I1214 19:47:09.604001 5532 executor.cpp:171] Received SUBSCRIBED event
I1214 19:47:09.607998 5532 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1214 19:47:09.608997 5532 executor.cpp:171] Received LAUNCH event
I1214 19:47:09.611999 5532 executor.cpp:638] Starting task bab58e4b-663b-4249-a075-80780832a27e
I1214 19:47:09.687996 5532 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1214 19:47:10.199988 5532 executor.cpp:651] Forked command at 4052
I1214 19:47:10.225966 6744 exec.cpp:435] Executor asked to shutdown
I1214 19:47:10.225966 5532 executor.cpp:171] Received SHUTDOWN event
I1214 19:47:10.225966 5532 executor.cpp:748] Shutting down
I1214 19:47:10.225966 5532 executor.cpp:855] Sending SIGTERM to process tree at pid 46ccccf-11fd-4095-86e5-5582b1bc902c-0000
I1214 19:47:10.223968 5056 master.cpp:10160] Updating the state of task bab58e4b-663b-4249-a075-80780832a27e of framework 126ccccf-11fd-4095-86e5-5582b1bc902c-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1214 19:47:10.223968 6088 slave.cpp:6109] Shutting down executor 'bab58e4b-663b-4249-a075-80780832a27e' of framework 126ccccf-11fd-4095-86e5-5582b1bc902c-0000 at executor(1)@10.3.1.5:61980
I1214 19:47:10.224968 6088 slave.cpp:909] Agent terminating
W1214 19:47:10.224968 6088 slave.cpp:3397] Ignoring shutdown framework 126ccccf-11fd-4095-86e5-5582b1bc902c-0000 because it is terminating
I1214 19:47:10.225966 5056 master.cpp:10266] Removing task bab58e4b-663b-4249-a075-80780832a27e with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 126ccccf-11fd-4095-86e5-5582b1bc902c-0000 on agent 126ccccf-11fd-4095-86e5-5582b1bc902c-S0 at slave(327)@10.3.1.5:61959 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 19:47:10.227967 1684 containerizer.cpp:2337] Destroying container f8604142-d593-48da-a2e6-743b72fd3b99 in RUNNING state
I1214 19:47:10.227967 1684 containerizer.cpp:2939] Transitioning the state of container f8604142-d593-48da-a2e6-743b72fd3b99 from RUNNING to DESTROYING
I1214 19:47:10.228966 1684 launcher.cpp:156] Asked to destroy container f8604142-d593-48da-a2e6-743b72fd3b99
I1214 19:47:10.228966 5056 master.cpp:1305] Agent 126ccccf-11fd-4095-86e5-5582b1bc902c-S0 at slave(327)@10.3.1.5:61959 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1214 19:47:10.228966 5056 master.cpp:3364] Disconnecting agent 126ccccf-11fd-4095-86e5-5582b1bc902c-S0 at slave(327)@10.3.1.5:61959 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 19:47:10.228966 8812 hierarchical.cpp:344] Removed framework 126ccccf-11fd-4095-86e5-5582b1bc902c-0000
I1214 19:47:10.229967 5056 master.cpp:3383] Deactivating agent 126ccccf-11fd-4095-86e5-5582b1bc902c-S0 at slave(327)@10.3.1.5:61959 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1214 19:47:10.229967 3068 hierarchical.cpp:766] Agent 126ccccf-11fd-4095-86e5-5582b1bc902c-S0 deactivated
I1214 19:47:10.290076 1684 containerizer.cpp:2788] Container f8604142-d593-48da-a2e6-743b72fd3b99 has exited
I1214 19:47:10.320088 5388 master.cpp:1147] Master terminating
I1214 19:47:10.322115 8812 hierarchical.cpp:609] Removed agent 126ccccf-11fd-4095-86e5-5582b1bc902c-S0
I1214 19:47:10.626085 4748 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 6:58 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64620/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 6:58 p.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> getpwnam(3) only sets `errno` if there is an error. To detect
> the (most common) case where the user account is successfully
> not found, we need to clear `errno` and verify that it is
> still clear on failure.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/chown.hpp e2214acbd726e8f84480e97f01ca240096a75877
>
>
> Diff: https://reviews.apache.org/r/64620/diff/1/
>
>
> Testing
> -------
>
> sudo make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 64620: Fixed `os::chown` error message.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64620/#review193828
-----------------------------------------------------------
Ship it!
> The getpwnam() and getpwuid() functions return a pointer to a passwd structure, or NULL if the matching entry is
> not found or an error occurs. If an error occurs, errno is set appropriately. If one wants to check errno
> after the call, it should be set to zero before the call.
- Andrew Schwartzmeyer
On Dec. 14, 2017, 10:58 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64620/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 10:58 a.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> getpwnam(3) only sets `errno` if there is an error. To detect
> the (most common) case where the user account is successfully
> not found, we need to clear `errno` and verify that it is
> still clear on failure.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/posix/chown.hpp e2214acbd726e8f84480e97f01ca240096a75877
>
>
> Diff: https://reviews.apache.org/r/64620/diff/1/
>
>
> Testing
> -------
>
> sudo make check (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>