[GitHub] [incubator-superset] john-bodley opened a new pull request #8714: [fix] Druid IS NULL/IS NOT NULL filters

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #8714: [fix] Druid IS NULL/IS NOT NULL filters
URL: https://github.com/apache/incubator-superset/pull/8714
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR fixes an issues with the way the `IS NULL` and `IS NOT NULL` filters are handled using the Druid native query language. Per [here](https://groups.google.com/forum/#!topic/druid-development/3HcW91YsT5Y) it seems that Druid internally treats `NULL` values and empty strings as same and thus the fix is to make the comparison value simply an empty string.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: Fixes https://github.com/apache/incubator-superset/issues/8676
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @villebro 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org