You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rob Tompkins <ch...@apache.org> on 2017/06/06 18:20:09 UTC
[VOTE] Release Commons Fileupload 1.3.3 based on RC5
Hello all,
This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
Tag name:
commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
Tag URL:
https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
Commit ID the tag points at:
dd2238b1671644cfead0e87c24a8ac61b4039084
Site:
http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
Distribution files (committed at revision 19901):
https://dist.apache.org/repos/dist/dev/commons/fileupload/
Distribution files hashes (SHA1):
commons-fileupload-1.3.3-bin.tar.gz
(SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
commons-fileupload-1.3.3-bin.zip
(SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
commons-fileupload-1.3.3-src.tar.gz
(SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
commons-fileupload-1.3.3-src.zip
(SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
These are the Maven artifacts and their hashes:
commons-fileupload-1.3.3-javadoc.jar
(SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
commons-fileupload-1.3.3-sources.jar
(SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
commons-fileupload-1.3.3-test-sources.jar
(SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
commons-fileupload-1.3.3-tests.jar
(SHA1: 20510147958fc759582e6ede789ccf31d056b232)
commons-fileupload-1.3.3.jar
(SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
commons-fileupload-1.3.3.pom
(SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
KEYS file to check signatures:
http://www.apache.org/dist/commons/KEYS
Maven artifacts:
https://repository.apache.org/content/repositories/orgapachecommons-1249
Please select one of the following options[1]:
[ ] +1 Release it.
[ ] +0 Go ahead; I don't care.
[ ] -0 There are a few minor glitches: ...
[ ] -1 No, do not release it because ...
This vote will be open at least 72 hours, i.e. until
2017-06-09T19:00:00Z
(this is UTC time).
--------
Cheers,
-Rob
[1] http://apache.org/foundation/voting.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 9, 2017, at 8:18 PM, Gary Gregory <ga...@gmail.com> wrote:
>
>> On Fri, Jun 9, 2017 at 2:51 PM, Rob Tompkins <ch...@gmail.com> wrote:
>>
>>
>> This time I mean it. Heh... :-)
>>
>> I agree on the items needing fixing. I'm a -1 now. Will get to it
>> Sunday/Monday. Thanks for the sets of eyes everyone.
>>
>
> Thank you for RM'ing!
No worries. Glad to. :-)
>
> Gary
>
>
>>
>> Cheers,
>> -Rob
>>
>>>> On Jun 9, 2017, at 3:08 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>> On Fri, Jun 9, 2017 at 9:21 AM, Rob Tompkins <ch...@gmail.com>
>> wrote:
>>>>
>>>>
>>>>
>>>>> On Jun 9, 2017, at 12:17 PM, Oliver Heger <
>> oliver.heger@oliver-heger.de>
>>>> wrote:
>>>>>
>>>>> Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
>>>>>
>>>>> Remarks:
>>>>> - The NOTICE file has an incorrect copyright year (-2016).
>>>>
>>>
>>> That should be fixed IMO.
>>>
>>>
>>>>> - The binary distribution has a different structure than binaries
>>>>> released for other components. For instance, it contains only the jar,
>>>>> but no Javadoc or Sources jars. (Not blocking, but may make sense to be
>>>>> conform to other components.)
>>>>
>>>
>>> That should be fixed IMO, it's just confusing.
>>>
>>>
>>>>> - The ant build did not work for me. (Not blocking, could also be
>>>>> dropped IMHO).
>>>>
>>>
>>> IIRC the only reason we still have Ant builds is that some Linux distros
>>> build jars from Scratch using Ant. Why not Maven I do not know. Does
>> anyone
>>> else recall anything about this?
>>>
>>> Otherwise, we could nuke the Ant build.
>>>
>>> Gary
>>>
>>>
>>>>>
>>>>> I think, the copyright date could be a problem. Therefore, I abstain
>>>>> from voting.
>>>>
>>>> What are others thoughts on this point?
>>>>
>>>>>
>>>>> Oliver
>>>>>
>>>>>> Am 06.06.2017 um 20:20 schrieb Rob Tompkins:
>>>>>> Hello all,
>>>>>>
>>>>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>>>> RC5).
>>>>>>
>>>>>> Tag name:
>>>>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>>>> 'git tag -v')
>>>>>>
>>>>>> Tag URL:
>>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-
>>>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>>
>>>>>> Commit ID the tag points at:
>>>>>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>>
>>>>>> Site:
>>>>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>>>>>
>>>>>> Distribution files (committed at revision 19901):
>>>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>>>>>
>>>>>> Distribution files hashes (SHA1):
>>>>>> commons-fileupload-1.3.3-bin.tar.gz
>>>>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>>>>>> commons-fileupload-1.3.3-bin.zip
>>>>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>>>>>> commons-fileupload-1.3.3-src.tar.gz
>>>>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>>>>>> commons-fileupload-1.3.3-src.zip
>>>>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>>>>>
>>>>>> These are the Maven artifacts and their hashes:
>>>>>> commons-fileupload-1.3.3-javadoc.jar
>>>>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>>>>>> commons-fileupload-1.3.3-sources.jar
>>>>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>>>>>> commons-fileupload-1.3.3-test-sources.jar
>>>>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>>>>>> commons-fileupload-1.3.3-tests.jar
>>>>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>>>>>> commons-fileupload-1.3.3.jar
>>>>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>>>>>> commons-fileupload-1.3.3.pom
>>>>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>>>>>
>>>>>> KEYS file to check signatures:
>>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>>
>>>>>> Maven artifacts:
>>>>>> https://repository.apache.org/content/repositories/
>>>> orgapachecommons-1249
>>>>>>
>>>>>> Please select one of the following options[1]:
>>>>>> [ ] +1 Release it.
>>>>>> [ ] +0 Go ahead; I don't care.
>>>>>> [ ] -0 There are a few minor glitches: ...
>>>>>> [ ] -1 No, do not release it because ...
>>>>>>
>>>>>> This vote will be open at least 72 hours, i.e. until
>>>>>> 2017-06-09T19:00:00Z
>>>>>> (this is UTC time).
>>>>>> --------
>>>>>>
>>>>>> Cheers,
>>>>>> -Rob
>>>>>>
>>>>>> [1] http://apache.org/foundation/voting.html
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Jun 9, 2017 at 2:51 PM, Rob Tompkins <ch...@gmail.com> wrote:
>
> This time I mean it. Heh... :-)
>
> I agree on the items needing fixing. I'm a -1 now. Will get to it
> Sunday/Monday. Thanks for the sets of eyes everyone.
>
Thank you for RM'ing!
Gary
>
> Cheers,
> -Rob
>
> > On Jun 9, 2017, at 3:08 PM, Gary Gregory <ga...@gmail.com> wrote:
> >
> >> On Fri, Jun 9, 2017 at 9:21 AM, Rob Tompkins <ch...@gmail.com>
> wrote:
> >>
> >>
> >>
> >>> On Jun 9, 2017, at 12:17 PM, Oliver Heger <
> oliver.heger@oliver-heger.de>
> >> wrote:
> >>>
> >>> Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
> >>>
> >>> Remarks:
> >>> - The NOTICE file has an incorrect copyright year (-2016).
> >>
> >
> > That should be fixed IMO.
> >
> >
> >>> - The binary distribution has a different structure than binaries
> >>> released for other components. For instance, it contains only the jar,
> >>> but no Javadoc or Sources jars. (Not blocking, but may make sense to be
> >>> conform to other components.)
> >>
> >
> > That should be fixed IMO, it's just confusing.
> >
> >
> >>> - The ant build did not work for me. (Not blocking, could also be
> >>> dropped IMHO).
> >>
> >
> > IIRC the only reason we still have Ant builds is that some Linux distros
> > build jars from Scratch using Ant. Why not Maven I do not know. Does
> anyone
> > else recall anything about this?
> >
> > Otherwise, we could nuke the Ant build.
> >
> > Gary
> >
> >
> >>>
> >>> I think, the copyright date could be a problem. Therefore, I abstain
> >>> from voting.
> >>
> >> What are others thoughts on this point?
> >>
> >>>
> >>> Oliver
> >>>
> >>>> Am 06.06.2017 um 20:20 schrieb Rob Tompkins:
> >>>> Hello all,
> >>>>
> >>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
> >> RC5).
> >>>>
> >>>> Tag name:
> >>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
> >> 'git tag -v')
> >>>>
> >>>> Tag URL:
> >>>> https://git-wip-us.apache.org/repos/asf?p=commons-
> >> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
> >>>>
> >>>> Commit ID the tag points at:
> >>>> dd2238b1671644cfead0e87c24a8ac61b4039084
> >>>>
> >>>> Site:
> >>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
> >>>>
> >>>> Distribution files (committed at revision 19901):
> >>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
> >>>>
> >>>> Distribution files hashes (SHA1):
> >>>> commons-fileupload-1.3.3-bin.tar.gz
> >>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> >>>> commons-fileupload-1.3.3-bin.zip
> >>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> >>>> commons-fileupload-1.3.3-src.tar.gz
> >>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> >>>> commons-fileupload-1.3.3-src.zip
> >>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
> >>>>
> >>>> These are the Maven artifacts and their hashes:
> >>>> commons-fileupload-1.3.3-javadoc.jar
> >>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> >>>> commons-fileupload-1.3.3-sources.jar
> >>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> >>>> commons-fileupload-1.3.3-test-sources.jar
> >>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> >>>> commons-fileupload-1.3.3-tests.jar
> >>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> >>>> commons-fileupload-1.3.3.jar
> >>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> >>>> commons-fileupload-1.3.3.pom
> >>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
> >>>>
> >>>> KEYS file to check signatures:
> >>>> http://www.apache.org/dist/commons/KEYS
> >>>>
> >>>> Maven artifacts:
> >>>> https://repository.apache.org/content/repositories/
> >> orgapachecommons-1249
> >>>>
> >>>> Please select one of the following options[1]:
> >>>> [ ] +1 Release it.
> >>>> [ ] +0 Go ahead; I don't care.
> >>>> [ ] -0 There are a few minor glitches: ...
> >>>> [ ] -1 No, do not release it because ...
> >>>>
> >>>> This vote will be open at least 72 hours, i.e. until
> >>>> 2017-06-09T19:00:00Z
> >>>> (this is UTC time).
> >>>> --------
> >>>>
> >>>> Cheers,
> >>>> -Rob
> >>>>
> >>>> [1] http://apache.org/foundation/voting.html
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
[CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
This time I mean it. Heh... :-)
I agree on the items needing fixing. I'm a -1 now. Will get to it Sunday/Monday. Thanks for the sets of eyes everyone.
Cheers,
-Rob
> On Jun 9, 2017, at 3:08 PM, Gary Gregory <ga...@gmail.com> wrote:
>
>> On Fri, Jun 9, 2017 at 9:21 AM, Rob Tompkins <ch...@gmail.com> wrote:
>>
>>
>>
>>> On Jun 9, 2017, at 12:17 PM, Oliver Heger <ol...@oliver-heger.de>
>> wrote:
>>>
>>> Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
>>>
>>> Remarks:
>>> - The NOTICE file has an incorrect copyright year (-2016).
>>
>
> That should be fixed IMO.
>
>
>>> - The binary distribution has a different structure than binaries
>>> released for other components. For instance, it contains only the jar,
>>> but no Javadoc or Sources jars. (Not blocking, but may make sense to be
>>> conform to other components.)
>>
>
> That should be fixed IMO, it's just confusing.
>
>
>>> - The ant build did not work for me. (Not blocking, could also be
>>> dropped IMHO).
>>
>
> IIRC the only reason we still have Ant builds is that some Linux distros
> build jars from Scratch using Ant. Why not Maven I do not know. Does anyone
> else recall anything about this?
>
> Otherwise, we could nuke the Ant build.
>
> Gary
>
>
>>>
>>> I think, the copyright date could be a problem. Therefore, I abstain
>>> from voting.
>>
>> What are others thoughts on this point?
>>
>>>
>>> Oliver
>>>
>>>> Am 06.06.2017 um 20:20 schrieb Rob Tompkins:
>>>> Hello all,
>>>>
>>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>> RC5).
>>>>
>>>> Tag name:
>>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>> 'git tag -v')
>>>>
>>>> Tag URL:
>>>> https://git-wip-us.apache.org/repos/asf?p=commons-
>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>
>>>> Commit ID the tag points at:
>>>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>
>>>> Site:
>>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>>>
>>>> Distribution files (committed at revision 19901):
>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>>>
>>>> Distribution files hashes (SHA1):
>>>> commons-fileupload-1.3.3-bin.tar.gz
>>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>>>> commons-fileupload-1.3.3-bin.zip
>>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>>>> commons-fileupload-1.3.3-src.tar.gz
>>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>>>> commons-fileupload-1.3.3-src.zip
>>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>>>
>>>> These are the Maven artifacts and their hashes:
>>>> commons-fileupload-1.3.3-javadoc.jar
>>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>>>> commons-fileupload-1.3.3-sources.jar
>>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>>>> commons-fileupload-1.3.3-test-sources.jar
>>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>>>> commons-fileupload-1.3.3-tests.jar
>>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>>>> commons-fileupload-1.3.3.jar
>>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>>>> commons-fileupload-1.3.3.pom
>>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>>>
>>>> KEYS file to check signatures:
>>>> http://www.apache.org/dist/commons/KEYS
>>>>
>>>> Maven artifacts:
>>>> https://repository.apache.org/content/repositories/
>> orgapachecommons-1249
>>>>
>>>> Please select one of the following options[1]:
>>>> [ ] +1 Release it.
>>>> [ ] +0 Go ahead; I don't care.
>>>> [ ] -0 There are a few minor glitches: ...
>>>> [ ] -1 No, do not release it because ...
>>>>
>>>> This vote will be open at least 72 hours, i.e. until
>>>> 2017-06-09T19:00:00Z
>>>> (this is UTC time).
>>>> --------
>>>>
>>>> Cheers,
>>>> -Rob
>>>>
>>>> [1] http://apache.org/foundation/voting.html
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Gary Gregory <ga...@gmail.com>.
On Fri, Jun 9, 2017 at 9:21 AM, Rob Tompkins <ch...@gmail.com> wrote:
>
>
> > On Jun 9, 2017, at 12:17 PM, Oliver Heger <ol...@oliver-heger.de>
> wrote:
> >
> > Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
> >
> > Remarks:
> > - The NOTICE file has an incorrect copyright year (-2016).
>
That should be fixed IMO.
> > - The binary distribution has a different structure than binaries
> > released for other components. For instance, it contains only the jar,
> > but no Javadoc or Sources jars. (Not blocking, but may make sense to be
> > conform to other components.)
>
That should be fixed IMO, it's just confusing.
> > - The ant build did not work for me. (Not blocking, could also be
> > dropped IMHO).
>
IIRC the only reason we still have Ant builds is that some Linux distros
build jars from Scratch using Ant. Why not Maven I do not know. Does anyone
else recall anything about this?
Otherwise, we could nuke the Ant build.
Gary
> >
> > I think, the copyright date could be a problem. Therefore, I abstain
> > from voting.
>
> What are others thoughts on this point?
>
> >
> > Oliver
> >
> >> Am 06.06.2017 um 20:20 schrieb Rob Tompkins:
> >> Hello all,
> >>
> >> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
> RC5).
> >>
> >> Tag name:
> >> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
> 'git tag -v')
> >>
> >> Tag URL:
> >> https://git-wip-us.apache.org/repos/asf?p=commons-
> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
> >>
> >> Commit ID the tag points at:
> >> dd2238b1671644cfead0e87c24a8ac61b4039084
> >>
> >> Site:
> >> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
> >>
> >> Distribution files (committed at revision 19901):
> >> https://dist.apache.org/repos/dist/dev/commons/fileupload/
> >>
> >> Distribution files hashes (SHA1):
> >> commons-fileupload-1.3.3-bin.tar.gz
> >> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> >> commons-fileupload-1.3.3-bin.zip
> >> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> >> commons-fileupload-1.3.3-src.tar.gz
> >> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> >> commons-fileupload-1.3.3-src.zip
> >> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
> >>
> >> These are the Maven artifacts and their hashes:
> >> commons-fileupload-1.3.3-javadoc.jar
> >> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> >> commons-fileupload-1.3.3-sources.jar
> >> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> >> commons-fileupload-1.3.3-test-sources.jar
> >> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> >> commons-fileupload-1.3.3-tests.jar
> >> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> >> commons-fileupload-1.3.3.jar
> >> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> >> commons-fileupload-1.3.3.pom
> >> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
> >>
> >> KEYS file to check signatures:
> >> http://www.apache.org/dist/commons/KEYS
> >>
> >> Maven artifacts:
> >> https://repository.apache.org/content/repositories/
> orgapachecommons-1249
> >>
> >> Please select one of the following options[1]:
> >> [ ] +1 Release it.
> >> [ ] +0 Go ahead; I don't care.
> >> [ ] -0 There are a few minor glitches: ...
> >> [ ] -1 No, do not release it because ...
> >>
> >> This vote will be open at least 72 hours, i.e. until
> >> 2017-06-09T19:00:00Z
> >> (this is UTC time).
> >> --------
> >>
> >> Cheers,
> >> -Rob
> >>
> >> [1] http://apache.org/foundation/voting.html
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 9, 2017, at 12:17 PM, Oliver Heger <ol...@oliver-heger.de> wrote:
>
> Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
>
> Remarks:
> - The NOTICE file has an incorrect copyright year (-2016).
> - The binary distribution has a different structure than binaries
> released for other components. For instance, it contains only the jar,
> but no Javadoc or Sources jars. (Not blocking, but may make sense to be
> conform to other components.)
> - The ant build did not work for me. (Not blocking, could also be
> dropped IMHO).
>
> I think, the copyright date could be a problem. Therefore, I abstain
> from voting.
What are others thoughts on this point?
>
> Oliver
>
>> Am 06.06.2017 um 20:20 schrieb Rob Tompkins:
>> Hello all,
>>
>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>>
>> Tag name:
>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
>>
>> Tag URL:
>> https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>
>> Commit ID the tag points at:
>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>
>> Site:
>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>
>> Distribution files (committed at revision 19901):
>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>
>> Distribution files hashes (SHA1):
>> commons-fileupload-1.3.3-bin.tar.gz
>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>> commons-fileupload-1.3.3-bin.zip
>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>> commons-fileupload-1.3.3-src.tar.gz
>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>> commons-fileupload-1.3.3-src.zip
>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>
>> These are the Maven artifacts and their hashes:
>> commons-fileupload-1.3.3-javadoc.jar
>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>> commons-fileupload-1.3.3-sources.jar
>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>> commons-fileupload-1.3.3-test-sources.jar
>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>> commons-fileupload-1.3.3-tests.jar
>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>> commons-fileupload-1.3.3.jar
>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>> commons-fileupload-1.3.3.pom
>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>
>> KEYS file to check signatures:
>> http://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>> https://repository.apache.org/content/repositories/orgapachecommons-1249
>>
>> Please select one of the following options[1]:
>> [ ] +1 Release it.
>> [ ] +0 Go ahead; I don't care.
>> [ ] -0 There are a few minor glitches: ...
>> [ ] -1 No, do not release it because ...
>>
>> This vote will be open at least 72 hours, i.e. until
>> 2017-06-09T19:00:00Z
>> (this is UTC time).
>> --------
>>
>> Cheers,
>> -Rob
>>
>> [1] http://apache.org/foundation/voting.html
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Oliver Heger <ol...@oliver-heger.de>.
Build works fine with Java 1.6 and 1.8 on Windows 10. Site looks good.
Remarks:
- The NOTICE file has an incorrect copyright year (-2016).
- The binary distribution has a different structure than binaries
released for other components. For instance, it contains only the jar,
but no Javadoc or Sources jars. (Not blocking, but may make sense to be
conform to other components.)
- The ant build did not work for me. (Not blocking, could also be
dropped IMHO).
I think, the copyright date could be a problem. Therefore, I abstain
from voting.
Oliver
Am 06.06.2017 um 20:20 schrieb Rob Tompkins:
> Hello all,
>
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>
> Tag name:
> commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
>
> Tag URL:
> https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>
> Commit ID the tag points at:
> dd2238b1671644cfead0e87c24a8ac61b4039084
>
> Site:
> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>
> Distribution files (committed at revision 19901):
> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>
> Distribution files hashes (SHA1):
> commons-fileupload-1.3.3-bin.tar.gz
> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> commons-fileupload-1.3.3-bin.zip
> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> commons-fileupload-1.3.3-src.tar.gz
> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> commons-fileupload-1.3.3-src.zip
> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>
> These are the Maven artifacts and their hashes:
> commons-fileupload-1.3.3-javadoc.jar
> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> commons-fileupload-1.3.3-sources.jar
> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> commons-fileupload-1.3.3-test-sources.jar
> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> commons-fileupload-1.3.3-tests.jar
> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> commons-fileupload-1.3.3.jar
> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> commons-fileupload-1.3.3.pom
> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>
> KEYS file to check signatures:
> http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1249
>
> Please select one of the following options[1]:
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
> [ ] -0 There are a few minor glitches: ...
> [ ] -1 No, do not release it because ...
>
> This vote will be open at least 72 hours, i.e. until
> 2017-06-09T19:00:00Z
> (this is UTC time).
> --------
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 8, 2017, at 5:46 AM, sebb <se...@gmail.com> wrote:
>
> On 8 June 2017 at 01:36, Rob Tompkins <chtompki@gmail.com <ma...@gmail.com>> wrote:
>>
>>
>>> On Jun 7, 2017, at 8:31 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>>> On Wed, Jun 7, 2017 at 5:30 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>>
>>>>
>>>>> On Wed, Jun 7, 2017 at 5:27 PM, Rob Tompkins <ch...@gmail.com> wrote:
>>>>>
>>>>>
>>>>>
>>>>>> On Jun 7, 2017, at 8:20 PM, Gary Gregory <ga...@gmail.com>
>>>>> wrote:
>>>>>>
>>>>>> The ASC does not seem to have a public key.:
>>>>>>
>>>>>> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
>>>>>> gpg: assuming signed data in 'commons-fileupload-1.3.3-sour
>>>>> ce-release.zip'
>>>>>> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
>>>>> key
>>>>>> ID 7188601C
>>>>>> *gpg: Can't check signature: No public key*
>>>>>>
>>>>>>
>>>>>
>>>>> Curious. I'll re-roll.
>>>>>
>>>>
>>> I wonder if this VOTE should be canceled or if properly signing the files
>>> can be done "in-line" to this VOTE?
>>
>> Indeed I was wondering if I re-built from the tag if that would warrant an RC6.
>
> I'm not sure I understand why the code needs to be rebuilt if the only
> problem is that the public signing key is not in KEYS.
>
> Surely you just need to ensure that the public key is added to the KEYS file?
>
> Or am I missing something here?
I think I missed pushing the src.zip artifacts properly to svn.
Gary, can you try again?
Thanks,
-Rob
>
>>>
>>> Gary
>>>
>>>
>>>> Just FYI, I re-imported http://www.apache.org/dist/commons/KEYS. Just in
>>>> case. Didn't help.
>>>>
>>>> Gary
>>>>
>>>>
>>>>>
>>>>>> Also, the file naming should be consistent,
>>>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
>>>>> both
>>>>>> "source-release" and "src". Not sure how you can end up with the
>>>>>> differences beyond just the file extension.
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
>>>>> wrote:
>>>>>>>
>>>>>>> Hello all,
>>>>>>>
>>>>>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>>>>> RC5).
>>>>>>>
>>>>>>> Tag name:
>>>>>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>>>>>>> 'git tag -v')
>>>>>>>
>>>>>>> Tag URL:
>>>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-
>>>>>>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>>>
>>>>>>> Commit ID the tag points at:
>>>>>>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>>>
>>>>>>> Site:
>>>>>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>>>>>>
>>>>>>> Distribution files (committed at revision 19901):
>>>>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>>>>>>
>>>>>>> Distribution files hashes (SHA1):
>>>>>>> commons-fileupload-1.3.3-bin.tar.gz
>>>>>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>>>>>>> commons-fileupload-1.3.3-bin.zip
>>>>>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>>>>>>> commons-fileupload-1.3.3-src.tar.gz
>>>>>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>>>>>>> commons-fileupload-1.3.3-src.zip
>>>>>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>>>>>>
>>>>>>> These are the Maven artifacts and their hashes:
>>>>>>> commons-fileupload-1.3.3-javadoc.jar
>>>>>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>>>>>>> commons-fileupload-1.3.3-sources.jar
>>>>>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>>>>>>> commons-fileupload-1.3.3-test-sources.jar
>>>>>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>>>>>>> commons-fileupload-1.3.3-tests.jar
>>>>>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>>>>>>> commons-fileupload-1.3.3.jar
>>>>>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>>>>>>> commons-fileupload-1.3.3.pom
>>>>>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>>>>>>
>>>>>>> KEYS file to check signatures:
>>>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>>>
>>>>>>> Maven artifacts:
>>>>>>> https://repository.apache.org/content/repositories/
>>>>>>> orgapachecommons-1249
>>>>>>>
>>>>>>> Please select one of the following options[1]:
>>>>>>> [ ] +1 Release it.
>>>>>>> [ ] +0 Go ahead; I don't care.
>>>>>>> [ ] -0 There are a few minor glitches: ...
>>>>>>> [ ] -1 No, do not release it because ...
>>>>>>>
>>>>>>> This vote will be open at least 72 hours, i.e. until
>>>>>>> 2017-06-09T19:00:00Z
>>>>>>> (this is UTC time).
>>>>>>> --------
>>>>>>>
>>>>>>> Cheers,
>>>>>>> -Rob
>>>>>>>
>>>>>>> [1] http://apache.org/foundation/voting.html
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>>
>>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org <ma...@commons.apache.org>
>> For additional commands, e-mail: dev-help@commons.apache.org <ma...@commons.apache.org>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org <ma...@commons.apache.org>
> For additional commands, e-mail: dev-help@commons.apache.org <ma...@commons.apache.org>
Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by sebb <se...@gmail.com>.
On 8 June 2017 at 01:36, Rob Tompkins <ch...@gmail.com> wrote:
>
>
>> On Jun 7, 2017, at 8:31 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>>> On Wed, Jun 7, 2017 at 5:30 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>>
>>>
>>>> On Wed, Jun 7, 2017 at 5:27 PM, Rob Tompkins <ch...@gmail.com> wrote:
>>>>
>>>>
>>>>
>>>>> On Jun 7, 2017, at 8:20 PM, Gary Gregory <ga...@gmail.com>
>>>> wrote:
>>>>>
>>>>> The ASC does not seem to have a public key.:
>>>>>
>>>>> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
>>>>> gpg: assuming signed data in 'commons-fileupload-1.3.3-sour
>>>> ce-release.zip'
>>>>> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
>>>> key
>>>>> ID 7188601C
>>>>> *gpg: Can't check signature: No public key*
>>>>>
>>>>>
>>>>
>>>> Curious. I'll re-roll.
>>>>
>>>
>> I wonder if this VOTE should be canceled or if properly signing the files
>> can be done "in-line" to this VOTE?
>
> Indeed I was wondering if I re-built from the tag if that would warrant an RC6.
I'm not sure I understand why the code needs to be rebuilt if the only
problem is that the public signing key is not in KEYS.
Surely you just need to ensure that the public key is added to the KEYS file?
Or am I missing something here?
>>
>> Gary
>>
>>
>>> Just FYI, I re-imported http://www.apache.org/dist/commons/KEYS. Just in
>>> case. Didn't help.
>>>
>>> Gary
>>>
>>>
>>>>
>>>>> Also, the file naming should be consistent,
>>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
>>>> both
>>>>> "source-release" and "src". Not sure how you can end up with the
>>>>> differences beyond just the file extension.
>>>>>
>>>>> Gary
>>>>>
>>>>>
>>>>>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
>>>> wrote:
>>>>>>
>>>>>> Hello all,
>>>>>>
>>>>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>>>> RC5).
>>>>>>
>>>>>> Tag name:
>>>>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>>>>>> 'git tag -v')
>>>>>>
>>>>>> Tag URL:
>>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-
>>>>>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>>
>>>>>> Commit ID the tag points at:
>>>>>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>>
>>>>>> Site:
>>>>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>>>>>
>>>>>> Distribution files (committed at revision 19901):
>>>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>>>>>
>>>>>> Distribution files hashes (SHA1):
>>>>>> commons-fileupload-1.3.3-bin.tar.gz
>>>>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>>>>>> commons-fileupload-1.3.3-bin.zip
>>>>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>>>>>> commons-fileupload-1.3.3-src.tar.gz
>>>>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>>>>>> commons-fileupload-1.3.3-src.zip
>>>>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>>>>>
>>>>>> These are the Maven artifacts and their hashes:
>>>>>> commons-fileupload-1.3.3-javadoc.jar
>>>>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>>>>>> commons-fileupload-1.3.3-sources.jar
>>>>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>>>>>> commons-fileupload-1.3.3-test-sources.jar
>>>>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>>>>>> commons-fileupload-1.3.3-tests.jar
>>>>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>>>>>> commons-fileupload-1.3.3.jar
>>>>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>>>>>> commons-fileupload-1.3.3.pom
>>>>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>>>>>
>>>>>> KEYS file to check signatures:
>>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>>
>>>>>> Maven artifacts:
>>>>>> https://repository.apache.org/content/repositories/
>>>>>> orgapachecommons-1249
>>>>>>
>>>>>> Please select one of the following options[1]:
>>>>>> [ ] +1 Release it.
>>>>>> [ ] +0 Go ahead; I don't care.
>>>>>> [ ] -0 There are a few minor glitches: ...
>>>>>> [ ] -1 No, do not release it because ...
>>>>>>
>>>>>> This vote will be open at least 72 hours, i.e. until
>>>>>> 2017-06-09T19:00:00Z
>>>>>> (this is UTC time).
>>>>>> --------
>>>>>>
>>>>>> Cheers,
>>>>>> -Rob
>>>>>>
>>>>>> [1] http://apache.org/foundation/voting.html
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>>
>>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 7, 2017, at 8:31 PM, Gary Gregory <ga...@gmail.com> wrote:
>
>> On Wed, Jun 7, 2017 at 5:30 PM, Gary Gregory <ga...@gmail.com> wrote:
>>
>>
>>
>>> On Wed, Jun 7, 2017 at 5:27 PM, Rob Tompkins <ch...@gmail.com> wrote:
>>>
>>>
>>>
>>>> On Jun 7, 2017, at 8:20 PM, Gary Gregory <ga...@gmail.com>
>>> wrote:
>>>>
>>>> The ASC does not seem to have a public key.:
>>>>
>>>> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
>>>> gpg: assuming signed data in 'commons-fileupload-1.3.3-sour
>>> ce-release.zip'
>>>> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
>>> key
>>>> ID 7188601C
>>>> *gpg: Can't check signature: No public key*
>>>>
>>>>
>>>
>>> Curious. I'll re-roll.
>>>
>>
> I wonder if this VOTE should be canceled or if properly signing the files
> can be done "in-line" to this VOTE?
Indeed I was wondering if I re-built from the tag if that would warrant an RC6.
>
> Gary
>
>
>> Just FYI, I re-imported http://www.apache.org/dist/commons/KEYS. Just in
>> case. Didn't help.
>>
>> Gary
>>
>>
>>>
>>>> Also, the file naming should be consistent,
>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
>>> both
>>>> "source-release" and "src". Not sure how you can end up with the
>>>> differences beyond just the file extension.
>>>>
>>>> Gary
>>>>
>>>>
>>>>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
>>> wrote:
>>>>>
>>>>> Hello all,
>>>>>
>>>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>>> RC5).
>>>>>
>>>>> Tag name:
>>>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>>>>> 'git tag -v')
>>>>>
>>>>> Tag URL:
>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-
>>>>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>
>>>>> Commit ID the tag points at:
>>>>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>
>>>>> Site:
>>>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>>>>
>>>>> Distribution files (committed at revision 19901):
>>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>>>>
>>>>> Distribution files hashes (SHA1):
>>>>> commons-fileupload-1.3.3-bin.tar.gz
>>>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>>>>> commons-fileupload-1.3.3-bin.zip
>>>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>>>>> commons-fileupload-1.3.3-src.tar.gz
>>>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>>>>> commons-fileupload-1.3.3-src.zip
>>>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>>>>
>>>>> These are the Maven artifacts and their hashes:
>>>>> commons-fileupload-1.3.3-javadoc.jar
>>>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>>>>> commons-fileupload-1.3.3-sources.jar
>>>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>>>>> commons-fileupload-1.3.3-test-sources.jar
>>>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>>>>> commons-fileupload-1.3.3-tests.jar
>>>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>>>>> commons-fileupload-1.3.3.jar
>>>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>>>>> commons-fileupload-1.3.3.pom
>>>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>>>>
>>>>> KEYS file to check signatures:
>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>
>>>>> Maven artifacts:
>>>>> https://repository.apache.org/content/repositories/
>>>>> orgapachecommons-1249
>>>>>
>>>>> Please select one of the following options[1]:
>>>>> [ ] +1 Release it.
>>>>> [ ] +0 Go ahead; I don't care.
>>>>> [ ] -0 There are a few minor glitches: ...
>>>>> [ ] -1 No, do not release it because ...
>>>>>
>>>>> This vote will be open at least 72 hours, i.e. until
>>>>> 2017-06-09T19:00:00Z
>>>>> (this is UTC time).
>>>>> --------
>>>>>
>>>>> Cheers,
>>>>> -Rob
>>>>>
>>>>> [1] http://apache.org/foundation/voting.html
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Jun 7, 2017 at 5:30 PM, Gary Gregory <ga...@gmail.com> wrote:
>
>
> On Wed, Jun 7, 2017 at 5:27 PM, Rob Tompkins <ch...@gmail.com> wrote:
>
>>
>>
>> > On Jun 7, 2017, at 8:20 PM, Gary Gregory <ga...@gmail.com>
>> wrote:
>> >
>> > The ASC does not seem to have a public key.:
>> >
>> > gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
>> > gpg: assuming signed data in 'commons-fileupload-1.3.3-sour
>> ce-release.zip'
>> > gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
>> key
>> > ID 7188601C
>> > *gpg: Can't check signature: No public key*
>> >
>> >
>>
>> Curious. I'll re-roll.
>>
>
I wonder if this VOTE should be canceled or if properly signing the files
can be done "in-line" to this VOTE?
Gary
> Just FYI, I re-imported http://www.apache.org/dist/commons/KEYS. Just in
> case. Didn't help.
>
> Gary
>
>
>>
>> > Also, the file naming should be consistent,
>> > https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
>> both
>> > "source-release" and "src". Not sure how you can end up with the
>> > differences beyond just the file extension.
>> >
>> > Gary
>> >
>> >
>> >> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
>> wrote:
>> >>
>> >> Hello all,
>> >>
>> >> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>> RC5).
>> >>
>> >> Tag name:
>> >> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>> >> 'git tag -v')
>> >>
>> >> Tag URL:
>> >> https://git-wip-us.apache.org/repos/asf?p=commons-
>> >> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>> >>
>> >> Commit ID the tag points at:
>> >> dd2238b1671644cfead0e87c24a8ac61b4039084
>> >>
>> >> Site:
>> >> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>> >>
>> >> Distribution files (committed at revision 19901):
>> >> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>> >>
>> >> Distribution files hashes (SHA1):
>> >> commons-fileupload-1.3.3-bin.tar.gz
>> >> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>> >> commons-fileupload-1.3.3-bin.zip
>> >> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>> >> commons-fileupload-1.3.3-src.tar.gz
>> >> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>> >> commons-fileupload-1.3.3-src.zip
>> >> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>> >>
>> >> These are the Maven artifacts and their hashes:
>> >> commons-fileupload-1.3.3-javadoc.jar
>> >> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>> >> commons-fileupload-1.3.3-sources.jar
>> >> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>> >> commons-fileupload-1.3.3-test-sources.jar
>> >> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>> >> commons-fileupload-1.3.3-tests.jar
>> >> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>> >> commons-fileupload-1.3.3.jar
>> >> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>> >> commons-fileupload-1.3.3.pom
>> >> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>> >>
>> >> KEYS file to check signatures:
>> >> http://www.apache.org/dist/commons/KEYS
>> >>
>> >> Maven artifacts:
>> >> https://repository.apache.org/content/repositories/
>> >> orgapachecommons-1249
>> >>
>> >> Please select one of the following options[1]:
>> >> [ ] +1 Release it.
>> >> [ ] +0 Go ahead; I don't care.
>> >> [ ] -0 There are a few minor glitches: ...
>> >> [ ] -1 No, do not release it because ...
>> >>
>> >> This vote will be open at least 72 hours, i.e. until
>> >> 2017-06-09T19:00:00Z
>> >> (this is UTC time).
>> >> --------
>> >>
>> >> Cheers,
>> >> -Rob
>> >>
>> >> [1] http://apache.org/foundation/voting.html
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
Re: [CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Jun 7, 2017 at 5:27 PM, Rob Tompkins <ch...@gmail.com> wrote:
>
>
> > On Jun 7, 2017, at 8:20 PM, Gary Gregory <ga...@gmail.com> wrote:
> >
> > The ASC does not seem to have a public key.:
> >
> > gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
> > gpg: assuming signed data in 'commons-fileupload-1.3.3-
> source-release.zip'
> > gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA key
> > ID 7188601C
> > *gpg: Can't check signature: No public key*
> >
> >
>
> Curious. I'll re-roll.
>
Just FYI, I re-imported http://www.apache.org/dist/commons/KEYS. Just in
case. Didn't help.
Gary
>
> > Also, the file naming should be consistent,
> > https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
> both
> > "source-release" and "src". Not sure how you can end up with the
> > differences beyond just the file extension.
> >
> > Gary
> >
> >
> >> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
> wrote:
> >>
> >> Hello all,
> >>
> >> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
> RC5).
> >>
> >> Tag name:
> >> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
> >> 'git tag -v')
> >>
> >> Tag URL:
> >> https://git-wip-us.apache.org/repos/asf?p=commons-
> >> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
> >>
> >> Commit ID the tag points at:
> >> dd2238b1671644cfead0e87c24a8ac61b4039084
> >>
> >> Site:
> >> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
> >>
> >> Distribution files (committed at revision 19901):
> >> https://dist.apache.org/repos/dist/dev/commons/fileupload/
> >>
> >> Distribution files hashes (SHA1):
> >> commons-fileupload-1.3.3-bin.tar.gz
> >> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> >> commons-fileupload-1.3.3-bin.zip
> >> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> >> commons-fileupload-1.3.3-src.tar.gz
> >> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> >> commons-fileupload-1.3.3-src.zip
> >> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
> >>
> >> These are the Maven artifacts and their hashes:
> >> commons-fileupload-1.3.3-javadoc.jar
> >> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> >> commons-fileupload-1.3.3-sources.jar
> >> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> >> commons-fileupload-1.3.3-test-sources.jar
> >> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> >> commons-fileupload-1.3.3-tests.jar
> >> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> >> commons-fileupload-1.3.3.jar
> >> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> >> commons-fileupload-1.3.3.pom
> >> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
> >>
> >> KEYS file to check signatures:
> >> http://www.apache.org/dist/commons/KEYS
> >>
> >> Maven artifacts:
> >> https://repository.apache.org/content/repositories/
> >> orgapachecommons-1249
> >>
> >> Please select one of the following options[1]:
> >> [ ] +1 Release it.
> >> [ ] +0 Go ahead; I don't care.
> >> [ ] -0 There are a few minor glitches: ...
> >> [ ] -1 No, do not release it because ...
> >>
> >> This vote will be open at least 72 hours, i.e. until
> >> 2017-06-09T19:00:00Z
> >> (this is UTC time).
> >> --------
> >>
> >> Cheers,
> >> -Rob
> >>
> >> [1] http://apache.org/foundation/voting.html
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
[CANCEL][VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 7, 2017, at 8:20 PM, Gary Gregory <ga...@gmail.com> wrote:
>
> The ASC does not seem to have a public key.:
>
> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
> gpg: assuming signed data in 'commons-fileupload-1.3.3-source-release.zip'
> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA key
> ID 7188601C
> *gpg: Can't check signature: No public key*
>
>
Curious. I'll re-roll.
> Also, the file naming should be consistent,
> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has both
> "source-release" and "src". Not sure how you can end up with the
> differences beyond just the file extension.
>
> Gary
>
>
>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org> wrote:
>>
>> Hello all,
>>
>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>>
>> Tag name:
>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>> 'git tag -v')
>>
>> Tag URL:
>> https://git-wip-us.apache.org/repos/asf?p=commons-
>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>
>> Commit ID the tag points at:
>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>
>> Site:
>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>
>> Distribution files (committed at revision 19901):
>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>
>> Distribution files hashes (SHA1):
>> commons-fileupload-1.3.3-bin.tar.gz
>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>> commons-fileupload-1.3.3-bin.zip
>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>> commons-fileupload-1.3.3-src.tar.gz
>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>> commons-fileupload-1.3.3-src.zip
>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>
>> These are the Maven artifacts and their hashes:
>> commons-fileupload-1.3.3-javadoc.jar
>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>> commons-fileupload-1.3.3-sources.jar
>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>> commons-fileupload-1.3.3-test-sources.jar
>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>> commons-fileupload-1.3.3-tests.jar
>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>> commons-fileupload-1.3.3.jar
>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>> commons-fileupload-1.3.3.pom
>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>
>> KEYS file to check signatures:
>> http://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>> https://repository.apache.org/content/repositories/
>> orgapachecommons-1249
>>
>> Please select one of the following options[1]:
>> [ ] +1 Release it.
>> [ ] +0 Go ahead; I don't care.
>> [ ] -0 There are a few minor glitches: ...
>> [ ] -1 No, do not release it because ...
>>
>> This vote will be open at least 72 hours, i.e. until
>> 2017-06-09T19:00:00Z
>> (this is UTC time).
>> --------
>>
>> Cheers,
>> -Rob
>>
>> [1] http://apache.org/foundation/voting.html
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 8, 2017, at 11:02 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> Adding the appropriate key to the KEYS file after the fact should still
> work. It would have the same cryptographic reliability as being added
> beforehand as you can't exactly imitate a key.
Yes (mine has been up there since February actually), but the signature and the time stamp on the files didn't match me. Bad svn commit on my part initially. Doh.
>
>> On 8 June 2017 at 07:17, Rob Tompkins <ch...@gmail.com> wrote:
>>
>>
>>
>>>> On Jun 8, 2017, at 8:09 AM, sebb <se...@gmail.com> wrote:
>>>>
>>>> On 8 June 2017 at 01:20, Gary Gregory <ga...@gmail.com> wrote:
>>>> The ASC does not seem to have a public key.:
>>>>
>>>> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
>>>
>>> That is not the recommended way to check a sig; you also need the target
>> file
>>>
>>> $ gpg --verify downloaded_file.asc downloaded_file
>>
>> Indeed, but if you don't specify it looks in the current directory for the
>> file.
>>
>>>
>>>> gpg: assuming signed data in 'commons-fileupload-1.3.3-
>> source-release.zip'
>>>
>>> Note that gpg is assuming where to find the data.
>>>
>>>> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
>> key
>>>> ID 7188601C
>>>> *gpg: Can't check signature: No public key*
>>>
>>> However if the .asc file was not detached, gpg would not check the
>> target file.
>>>
>>> https://www.apache.org/info/verification.html#specify_both
>>>
>>>>
>>>> Also, the file naming should be consistent,
>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
>> both
>>>> "source-release" and "src". Not sure how you can end up with the
>>>> differences beyond just the file extension.
>>>>
>>>> Gary
>>>>
>>>>
>>>>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
>> wrote:
>>>>>
>>>>> Hello all,
>>>>>
>>>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>> RC5).
>>>>>
>>>>> Tag name:
>>>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>>>>> 'git tag -v')
>>>>>
>>>>> Tag URL:
>>>>> https://git-wip-us.apache.org/repos/asf?p=commons-
>>>>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>
>>>>> Commit ID the tag points at:
>>>>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>>>>
>>>>> Site:
>>>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>>>>
>>>>> Distribution files (committed at revision 19901):
>>>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>>>>
>>>>> Distribution files hashes (SHA1):
>>>>> commons-fileupload-1.3.3-bin.tar.gz
>>>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>>>>> commons-fileupload-1.3.3-bin.zip
>>>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>>>>> commons-fileupload-1.3.3-src.tar.gz
>>>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>>>>> commons-fileupload-1.3.3-src.zip
>>>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>>>>
>>>>> These are the Maven artifacts and their hashes:
>>>>> commons-fileupload-1.3.3-javadoc.jar
>>>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>>>>> commons-fileupload-1.3.3-sources.jar
>>>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>>>>> commons-fileupload-1.3.3-test-sources.jar
>>>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>>>>> commons-fileupload-1.3.3-tests.jar
>>>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>>>>> commons-fileupload-1.3.3.jar
>>>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>>>>> commons-fileupload-1.3.3.pom
>>>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>>>>
>>>>> KEYS file to check signatures:
>>>>> http://www.apache.org/dist/commons/KEYS
>>>>>
>>>>> Maven artifacts:
>>>>> https://repository.apache.org/content/repositories/
>>>>> orgapachecommons-1249
>>>>>
>>>>> Please select one of the following options[1]:
>>>>> [ ] +1 Release it.
>>>>> [ ] +0 Go ahead; I don't care.
>>>>> [ ] -0 There are a few minor glitches: ...
>>>>> [ ] -1 No, do not release it because ...
>>>>>
>>>>> This vote will be open at least 72 hours, i.e. until
>>>>> 2017-06-09T19:00:00Z
>>>>> (this is UTC time).
>>>>> --------
>>>>>
>>>>> Cheers,
>>>>> -Rob
>>>>>
>>>>> [1] http://apache.org/foundation/voting.html
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Matt Sicker <bo...@gmail.com>.
Adding the appropriate key to the KEYS file after the fact should still
work. It would have the same cryptographic reliability as being added
beforehand as you can't exactly imitate a key.
On 8 June 2017 at 07:17, Rob Tompkins <ch...@gmail.com> wrote:
>
>
> > On Jun 8, 2017, at 8:09 AM, sebb <se...@gmail.com> wrote:
> >
> >> On 8 June 2017 at 01:20, Gary Gregory <ga...@gmail.com> wrote:
> >> The ASC does not seem to have a public key.:
> >>
> >> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
> >
> > That is not the recommended way to check a sig; you also need the target
> file
> >
> > $ gpg --verify downloaded_file.asc downloaded_file
>
> Indeed, but if you don't specify it looks in the current directory for the
> file.
>
> >
> >> gpg: assuming signed data in 'commons-fileupload-1.3.3-
> source-release.zip'
> >
> > Note that gpg is assuming where to find the data.
> >
> >> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
> key
> >> ID 7188601C
> >> *gpg: Can't check signature: No public key*
> >
> > However if the .asc file was not detached, gpg would not check the
> target file.
> >
> > https://www.apache.org/info/verification.html#specify_both
> >
> >>
> >> Also, the file naming should be consistent,
> >> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
> both
> >> "source-release" and "src". Not sure how you can end up with the
> >> differences beyond just the file extension.
> >>
> >> Gary
> >>
> >>
> >>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
> wrote:
> >>>
> >>> Hello all,
> >>>
> >>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
> RC5).
> >>>
> >>> Tag name:
> >>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
> >>> 'git tag -v')
> >>>
> >>> Tag URL:
> >>> https://git-wip-us.apache.org/repos/asf?p=commons-
> >>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
> >>>
> >>> Commit ID the tag points at:
> >>> dd2238b1671644cfead0e87c24a8ac61b4039084
> >>>
> >>> Site:
> >>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
> >>>
> >>> Distribution files (committed at revision 19901):
> >>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
> >>>
> >>> Distribution files hashes (SHA1):
> >>> commons-fileupload-1.3.3-bin.tar.gz
> >>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> >>> commons-fileupload-1.3.3-bin.zip
> >>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> >>> commons-fileupload-1.3.3-src.tar.gz
> >>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> >>> commons-fileupload-1.3.3-src.zip
> >>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
> >>>
> >>> These are the Maven artifacts and their hashes:
> >>> commons-fileupload-1.3.3-javadoc.jar
> >>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> >>> commons-fileupload-1.3.3-sources.jar
> >>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> >>> commons-fileupload-1.3.3-test-sources.jar
> >>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> >>> commons-fileupload-1.3.3-tests.jar
> >>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> >>> commons-fileupload-1.3.3.jar
> >>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> >>> commons-fileupload-1.3.3.pom
> >>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
> >>>
> >>> KEYS file to check signatures:
> >>> http://www.apache.org/dist/commons/KEYS
> >>>
> >>> Maven artifacts:
> >>> https://repository.apache.org/content/repositories/
> >>> orgapachecommons-1249
> >>>
> >>> Please select one of the following options[1]:
> >>> [ ] +1 Release it.
> >>> [ ] +0 Go ahead; I don't care.
> >>> [ ] -0 There are a few minor glitches: ...
> >>> [ ] -1 No, do not release it because ...
> >>>
> >>> This vote will be open at least 72 hours, i.e. until
> >>> 2017-06-09T19:00:00Z
> >>> (this is UTC time).
> >>> --------
> >>>
> >>> Cheers,
> >>> -Rob
> >>>
> >>> [1] http://apache.org/foundation/voting.html
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
--
Matt Sicker <bo...@gmail.com>
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Gary Gregory <ga...@gmail.com>.
+1
From src zip: ASC, MD5, SHA1 OK.
Build passes with 'mvn clean site'.
Tests, CLIRR, RAT and reports OK.
Used:
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T12:39:06-07:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"
Gary
On Thu, Jun 8, 2017 at 8:55 AM, Gary Gregory <ga...@gmail.com> wrote:
>
>
> On Thu, Jun 8, 2017 at 5:17 AM, Rob Tompkins <ch...@gmail.com> wrote:
>
>>
>>
>> > On Jun 8, 2017, at 8:09 AM, sebb <se...@gmail.com> wrote:
>> >
>> >> On 8 June 2017 at 01:20, Gary Gregory <ga...@gmail.com> wrote:
>> >> The ASC does not seem to have a public key.:
>> >>
>> >> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
>> >
>> > That is not the recommended way to check a sig; you also need the
>> target file
>> >
>> > $ gpg --verify downloaded_file.asc downloaded_file
>>
>> Indeed, but if you don't specify it looks in the current directory for
>> the file.
>>
>
> Works like a charm now:
>
> $ gpg --verify commons-fileupload-1.3.3-src.zip.asc
> commons-fileupload-1.3.3-src.zip
> gpg: Signature made 06/06/17 17:31:41 ric using RSA key ID 5ECBB314
> gpg: Good signature from "Rob Tompkins <ch...@apache.org>" [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the
> owner.
> Primary key fingerprint: B6E7 3D84 EA4F CC47 1660 8725 3FAA D2CD 5ECB B314
>
> Gary
>
>
>>
>> >
>> >> gpg: assuming signed data in 'commons-fileupload-1.3.3-sour
>> ce-release.zip'
>> >
>> > Note that gpg is assuming where to find the data.
>> >
>> >> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
>> key
>> >> ID 7188601C
>> >> *gpg: Can't check signature: No public key*
>> >
>> > However if the .asc file was not detached, gpg would not check the
>> target file.
>> >
>> > https://www.apache.org/info/verification.html#specify_both
>> >
>> >>
>> >> Also, the file naming should be consistent,
>> >> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
>> both
>> >> "source-release" and "src". Not sure how you can end up with the
>> >> differences beyond just the file extension.
>> >>
>> >> Gary
>> >>
>> >>
>> >>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
>> wrote:
>> >>>
>> >>> Hello all,
>> >>>
>> >>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
>> RC5).
>> >>>
>> >>> Tag name:
>> >>> commons-fileupload-1.3.3-RC5 (signature can be checked from git
>> using
>> >>> 'git tag -v')
>> >>>
>> >>> Tag URL:
>> >>> https://git-wip-us.apache.org/repos/asf?p=commons-
>> >>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>> >>>
>> >>> Commit ID the tag points at:
>> >>> dd2238b1671644cfead0e87c24a8ac61b4039084
>> >>>
>> >>> Site:
>> >>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>> >>>
>> >>> Distribution files (committed at revision 19901):
>> >>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>> >>>
>> >>> Distribution files hashes (SHA1):
>> >>> commons-fileupload-1.3.3-bin.tar.gz
>> >>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>> >>> commons-fileupload-1.3.3-bin.zip
>> >>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>> >>> commons-fileupload-1.3.3-src.tar.gz
>> >>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>> >>> commons-fileupload-1.3.3-src.zip
>> >>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>> >>>
>> >>> These are the Maven artifacts and their hashes:
>> >>> commons-fileupload-1.3.3-javadoc.jar
>> >>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>> >>> commons-fileupload-1.3.3-sources.jar
>> >>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>> >>> commons-fileupload-1.3.3-test-sources.jar
>> >>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>> >>> commons-fileupload-1.3.3-tests.jar
>> >>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>> >>> commons-fileupload-1.3.3.jar
>> >>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>> >>> commons-fileupload-1.3.3.pom
>> >>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>> >>>
>> >>> KEYS file to check signatures:
>> >>> http://www.apache.org/dist/commons/KEYS
>> >>>
>> >>> Maven artifacts:
>> >>> https://repository.apache.org/content/repositories/
>> >>> orgapachecommons-1249
>> >>>
>> >>> Please select one of the following options[1]:
>> >>> [ ] +1 Release it.
>> >>> [ ] +0 Go ahead; I don't care.
>> >>> [ ] -0 There are a few minor glitches: ...
>> >>> [ ] -1 No, do not release it because ...
>> >>>
>> >>> This vote will be open at least 72 hours, i.e. until
>> >>> 2017-06-09T19:00:00Z
>> >>> (this is UTC time).
>> >>> --------
>> >>>
>> >>> Cheers,
>> >>> -Rob
>> >>>
>> >>> [1] http://apache.org/foundation/voting.html
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >>> For additional commands, e-mail: dev-help@commons.apache.org
>> >>>
>> >>>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Gary Gregory <ga...@gmail.com>.
On Thu, Jun 8, 2017 at 5:17 AM, Rob Tompkins <ch...@gmail.com> wrote:
>
>
> > On Jun 8, 2017, at 8:09 AM, sebb <se...@gmail.com> wrote:
> >
> >> On 8 June 2017 at 01:20, Gary Gregory <ga...@gmail.com> wrote:
> >> The ASC does not seem to have a public key.:
> >>
> >> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
> >
> > That is not the recommended way to check a sig; you also need the target
> file
> >
> > $ gpg --verify downloaded_file.asc downloaded_file
>
> Indeed, but if you don't specify it looks in the current directory for the
> file.
>
Works like a charm now:
$ gpg --verify commons-fileupload-1.3.3-src.zip.asc
commons-fileupload-1.3.3-src.zip
gpg: Signature made 06/06/17 17:31:41 ric using RSA key ID 5ECBB314
gpg: Good signature from "Rob Tompkins <ch...@apache.org>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: B6E7 3D84 EA4F CC47 1660 8725 3FAA D2CD 5ECB B314
Gary
>
> >
> >> gpg: assuming signed data in 'commons-fileupload-1.3.3-
> source-release.zip'
> >
> > Note that gpg is assuming where to find the data.
> >
> >> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA
> key
> >> ID 7188601C
> >> *gpg: Can't check signature: No public key*
> >
> > However if the .asc file was not detached, gpg would not check the
> target file.
> >
> > https://www.apache.org/info/verification.html#specify_both
> >
> >>
> >> Also, the file naming should be consistent,
> >> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has
> both
> >> "source-release" and "src". Not sure how you can end up with the
> >> differences beyond just the file extension.
> >>
> >> Gary
> >>
> >>
> >>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org>
> wrote:
> >>>
> >>> Hello all,
> >>>
> >>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from
> RC5).
> >>>
> >>> Tag name:
> >>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
> >>> 'git tag -v')
> >>>
> >>> Tag URL:
> >>> https://git-wip-us.apache.org/repos/asf?p=commons-
> >>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
> >>>
> >>> Commit ID the tag points at:
> >>> dd2238b1671644cfead0e87c24a8ac61b4039084
> >>>
> >>> Site:
> >>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
> >>>
> >>> Distribution files (committed at revision 19901):
> >>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
> >>>
> >>> Distribution files hashes (SHA1):
> >>> commons-fileupload-1.3.3-bin.tar.gz
> >>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> >>> commons-fileupload-1.3.3-bin.zip
> >>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> >>> commons-fileupload-1.3.3-src.tar.gz
> >>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> >>> commons-fileupload-1.3.3-src.zip
> >>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
> >>>
> >>> These are the Maven artifacts and their hashes:
> >>> commons-fileupload-1.3.3-javadoc.jar
> >>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> >>> commons-fileupload-1.3.3-sources.jar
> >>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> >>> commons-fileupload-1.3.3-test-sources.jar
> >>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> >>> commons-fileupload-1.3.3-tests.jar
> >>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> >>> commons-fileupload-1.3.3.jar
> >>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> >>> commons-fileupload-1.3.3.pom
> >>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
> >>>
> >>> KEYS file to check signatures:
> >>> http://www.apache.org/dist/commons/KEYS
> >>>
> >>> Maven artifacts:
> >>> https://repository.apache.org/content/repositories/
> >>> orgapachecommons-1249
> >>>
> >>> Please select one of the following options[1]:
> >>> [ ] +1 Release it.
> >>> [ ] +0 Go ahead; I don't care.
> >>> [ ] -0 There are a few minor glitches: ...
> >>> [ ] -1 No, do not release it because ...
> >>>
> >>> This vote will be open at least 72 hours, i.e. until
> >>> 2017-06-09T19:00:00Z
> >>> (this is UTC time).
> >>> --------
> >>>
> >>> Cheers,
> >>> -Rob
> >>>
> >>> [1] http://apache.org/foundation/voting.html
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 8, 2017, at 8:09 AM, sebb <se...@gmail.com> wrote:
>
>> On 8 June 2017 at 01:20, Gary Gregory <ga...@gmail.com> wrote:
>> The ASC does not seem to have a public key.:
>>
>> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
>
> That is not the recommended way to check a sig; you also need the target file
>
> $ gpg --verify downloaded_file.asc downloaded_file
Indeed, but if you don't specify it looks in the current directory for the file.
>
>> gpg: assuming signed data in 'commons-fileupload-1.3.3-source-release.zip'
>
> Note that gpg is assuming where to find the data.
>
>> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA key
>> ID 7188601C
>> *gpg: Can't check signature: No public key*
>
> However if the .asc file was not detached, gpg would not check the target file.
>
> https://www.apache.org/info/verification.html#specify_both
>
>>
>> Also, the file naming should be consistent,
>> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has both
>> "source-release" and "src". Not sure how you can end up with the
>> differences beyond just the file extension.
>>
>> Gary
>>
>>
>>> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org> wrote:
>>>
>>> Hello all,
>>>
>>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>>>
>>> Tag name:
>>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>>> 'git tag -v')
>>>
>>> Tag URL:
>>> https://git-wip-us.apache.org/repos/asf?p=commons-
>>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>>
>>> Commit ID the tag points at:
>>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>>
>>> Site:
>>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>>
>>> Distribution files (committed at revision 19901):
>>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>>
>>> Distribution files hashes (SHA1):
>>> commons-fileupload-1.3.3-bin.tar.gz
>>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>>> commons-fileupload-1.3.3-bin.zip
>>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>>> commons-fileupload-1.3.3-src.tar.gz
>>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>>> commons-fileupload-1.3.3-src.zip
>>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>>
>>> These are the Maven artifacts and their hashes:
>>> commons-fileupload-1.3.3-javadoc.jar
>>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>>> commons-fileupload-1.3.3-sources.jar
>>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>>> commons-fileupload-1.3.3-test-sources.jar
>>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>>> commons-fileupload-1.3.3-tests.jar
>>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>>> commons-fileupload-1.3.3.jar
>>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>>> commons-fileupload-1.3.3.pom
>>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>>
>>> KEYS file to check signatures:
>>> http://www.apache.org/dist/commons/KEYS
>>>
>>> Maven artifacts:
>>> https://repository.apache.org/content/repositories/
>>> orgapachecommons-1249
>>>
>>> Please select one of the following options[1]:
>>> [ ] +1 Release it.
>>> [ ] +0 Go ahead; I don't care.
>>> [ ] -0 There are a few minor glitches: ...
>>> [ ] -1 No, do not release it because ...
>>>
>>> This vote will be open at least 72 hours, i.e. until
>>> 2017-06-09T19:00:00Z
>>> (this is UTC time).
>>> --------
>>>
>>> Cheers,
>>> -Rob
>>>
>>> [1] http://apache.org/foundation/voting.html
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by sebb <se...@gmail.com>.
On 8 June 2017 at 01:20, Gary Gregory <ga...@gmail.com> wrote:
> The ASC does not seem to have a public key.:
>
> gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
That is not the recommended way to check a sig; you also need the target file
$ gpg --verify downloaded_file.asc downloaded_file
> gpg: assuming signed data in 'commons-fileupload-1.3.3-source-release.zip'
Note that gpg is assuming where to find the data.
> gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA key
> ID 7188601C
> *gpg: Can't check signature: No public key*
However if the .asc file was not detached, gpg would not check the target file.
https://www.apache.org/info/verification.html#specify_both
>
> Also, the file naming should be consistent,
> https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has both
> "source-release" and "src". Not sure how you can end up with the
> differences beyond just the file extension.
>
> Gary
>
>
> On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org> wrote:
>
>> Hello all,
>>
>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>>
>> Tag name:
>> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
>> 'git tag -v')
>>
>> Tag URL:
>> https://git-wip-us.apache.org/repos/asf?p=commons-
>> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>>
>> Commit ID the tag points at:
>> dd2238b1671644cfead0e87c24a8ac61b4039084
>>
>> Site:
>> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>>
>> Distribution files (committed at revision 19901):
>> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>
>> Distribution files hashes (SHA1):
>> commons-fileupload-1.3.3-bin.tar.gz
>> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>> commons-fileupload-1.3.3-bin.zip
>> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>> commons-fileupload-1.3.3-src.tar.gz
>> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>> commons-fileupload-1.3.3-src.zip
>> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>>
>> These are the Maven artifacts and their hashes:
>> commons-fileupload-1.3.3-javadoc.jar
>> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>> commons-fileupload-1.3.3-sources.jar
>> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>> commons-fileupload-1.3.3-test-sources.jar
>> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>> commons-fileupload-1.3.3-tests.jar
>> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>> commons-fileupload-1.3.3.jar
>> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>> commons-fileupload-1.3.3.pom
>> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>>
>> KEYS file to check signatures:
>> http://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>> https://repository.apache.org/content/repositories/
>> orgapachecommons-1249
>>
>> Please select one of the following options[1]:
>> [ ] +1 Release it.
>> [ ] +0 Go ahead; I don't care.
>> [ ] -0 There are a few minor glitches: ...
>> [ ] -1 No, do not release it because ...
>>
>> This vote will be open at least 72 hours, i.e. until
>> 2017-06-09T19:00:00Z
>> (this is UTC time).
>> --------
>>
>> Cheers,
>> -Rob
>>
>> [1] http://apache.org/foundation/voting.html
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Gary Gregory <ga...@gmail.com>.
The ASC does not seem to have a public key.:
gpg --verify commons-fileupload-1.3.3-source-release.zip.asc
gpg: assuming signed data in 'commons-fileupload-1.3.3-source-release.zip'
gpg: Signature made 12/04/16 05:15:02 Pacific Standard Time using DSA key
ID 7188601C
*gpg: Can't check signature: No public key*
Also, the file naming should be consistent,
https://dist.apache.org/repos/dist/dev/commons/fileupload/source/ has both
"source-release" and "src". Not sure how you can end up with the
differences beyond just the file extension.
Gary
On Tue, Jun 6, 2017 at 11:20 AM, Rob Tompkins <ch...@apache.org> wrote:
> Hello all,
>
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>
> Tag name:
> commons-fileupload-1.3.3-RC5 (signature can be checked from git using
> 'git tag -v')
>
> Tag URL:
> https://git-wip-us.apache.org/repos/asf?p=commons-
> fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>
> Commit ID the tag points at:
> dd2238b1671644cfead0e87c24a8ac61b4039084
>
> Site:
> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>
> Distribution files (committed at revision 19901):
> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>
> Distribution files hashes (SHA1):
> commons-fileupload-1.3.3-bin.tar.gz
> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> commons-fileupload-1.3.3-bin.zip
> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> commons-fileupload-1.3.3-src.tar.gz
> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> commons-fileupload-1.3.3-src.zip
> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>
> These are the Maven artifacts and their hashes:
> commons-fileupload-1.3.3-javadoc.jar
> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> commons-fileupload-1.3.3-sources.jar
> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> commons-fileupload-1.3.3-test-sources.jar
> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> commons-fileupload-1.3.3-tests.jar
> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> commons-fileupload-1.3.3.jar
> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> commons-fileupload-1.3.3.pom
> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>
> KEYS file to check signatures:
> http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/
> orgapachecommons-1249
>
> Please select one of the following options[1]:
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
> [ ] -0 There are a few minor glitches: ...
> [ ] -1 No, do not release it because ...
>
> This vote will be open at least 72 hours, i.e. until
> 2017-06-09T19:00:00Z
> (this is UTC time).
> --------
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br.INVALID>.
> Anyway, FILEUPLOAD-279 is not there, but this shouldn't be a blocker.
Just to be clear, it is not in http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5/changes-report.html, but it's correctly displayed in my local generated site. So no issues I think.
Bruno
________________________________
From: Bruno P. Kinoshita <br...@yahoo.com.br.INVALID>
To: Commons Developers List <de...@commons.apache.org>
Sent: Wednesday, 7 June 2017 7:19 PM
Subject: Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
[ X ] +1 Release it.
All tests pass, artifacts generated successfully, and site correctly generated too with `mvn clean test install -e -X` on the following environments.
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
Maven home: /opt/maven
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
Maven home: /opt/maven
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
Maven home: /opt/maven
Java version: 1.8.0, vendor: IBM Corporation
Java home: /home/kinow/Development/java/ibm-java-x86_64-80/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
Reports look OK. Noticed that coverage could be enhanced for future releases. There are some classes with 0 tests (PortletFileUpload and PortletRequestContext) so I'm adding a note in my todo list to write some tests when I have some spare time (happy if anyone does so first :).
I think NOTICE.txt was not updated to include 2017 in the year (I believe we manually update this file?), but that's trivial and definitely not a blocker (I guess we just fix it later - if necessary).
My local web site has changes report showing 1.3.3 with date as tbd. Yours is showing 1.4 with date set to today, but I guess it's temporary and after the release it will display 1.3.3 and another date? Anyway, FILEUPLOAD-279 is not there, but this shouldn't be a blocker.
Didn't have much time so checked only the main jar gpg signature, and it's also looking OK.
Go for it, and thanks for preparing the release!
Cheers
Bruno
ps: first time I look at the DOAP file while reviewing a release... there are some releases missing there, but I guess it's not updated automagically by Maven... maybe those blocks could be removed?
________________________________
From: Rob Tompkins <ch...@apache.org>
To: Commons Developers List <de...@commons.apache.org>
Sent: Wednesday, 7 June 2017 6:26 AM
Subject: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Hello all,
This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
Tag name:
commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
Tag URL:
https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
Commit ID the tag points at:
dd2238b1671644cfead0e87c24a8ac61b4039084
Site:
http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
Distribution files (committed at revision 19901):
https://dist.apache.org/repos/dist/dev/commons/fileupload/
Distribution files hashes (SHA1):
commons-fileupload-1.3.3-bin.tar.gz
(SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
commons-fileupload-1.3.3-bin.zip
(SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
commons-fileupload-1.3.3-src.tar.gz
(SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
commons-fileupload-1.3.3-src.zip
(SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
These are the Maven artifacts and their hashes:
commons-fileupload-1.3.3-javadoc.jar
(SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
commons-fileupload-1.3.3-sources.jar
(SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
commons-fileupload-1.3.3-test-sources.jar
(SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
commons-fileupload-1.3.3-tests.jar
(SHA1: 20510147958fc759582e6ede789ccf31d056b232)
commons-fileupload-1.3.3.jar
(SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
commons-fileupload-1.3.3.pom
(SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
KEYS file to check signatures:
http://www.apache.org/dist/commons/KEYS
Maven artifacts:
https://repository.apache.org/content/repositories/orgapachecommons-1249
Please select one of the following options[1]:
[ ] +1 Release it.
[ ] +0 Go ahead; I don't care.
[ ] -0 There are a few minor glitches: ...
[ ] -1 No, do not release it because ...
This vote will be open at least 72 hours, i.e. until
2017-06-09T19:00:00Z
(this is UTC time).
--------
Cheers,
-Rob
[1] http://apache.org/foundation/voting.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Rob Tompkins <ch...@gmail.com>.
> On Jun 7, 2017, at 3:19 AM, Bruno P. Kinoshita <br...@yahoo.com.br.INVALID> wrote:
>
> [ X ] +1 Release it.
>
> All tests pass, artifacts generated successfully, and site correctly generated too with `mvn clean test install -e -X` on the following environments.
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
> Maven home: /opt/maven
> Java version: 1.8.0_131, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
> Maven home: /opt/maven
> Java version: 1.7.0_80, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-7-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
>
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
> Maven home: /opt/maven
> Java version: 1.8.0, vendor: IBM Corporation
> Java home: /home/kinow/Development/java/ibm-java-x86_64-80/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
>
>
> Reports look OK. Noticed that coverage could be enhanced for future releases. There are some classes with 0 tests (PortletFileUpload and PortletRequestContext) so I'm adding a note in my todo list to write some tests when I have some spare time (happy if anyone does so first :).
>
> I think NOTICE.txt was not updated to include 2017 in the year (I believe we manually update this file?), but that's trivial and definitely not a blocker (I guess we just fix it later - if necessary).
>
> My local web site has changes report showing 1.3.3 with date as tbd. Yours is showing 1.4 with date set to today, but I guess it's temporary and after the release it will display 1.3.3 and another date? Anyway, FILEUPLOAD-279 is not there, but this shouldn't be a blocker.
I actually uploaded the site from the master branch because there were considerable differences between the RC and the master branch. I figured we would use the site from the master branch. I’ve just changed that for the sake of release validation.
-Rob
>
> Didn't have much time so checked only the main jar gpg signature, and it's also looking OK.
>
> Go for it, and thanks for preparing the release!
> Cheers
>
> Bruno
>
> ps: first time I look at the DOAP file while reviewing a release... there are some releases missing there, but I guess it's not updated automagically by Maven... maybe those blocks could be removed?
> ________________________________
> From: Rob Tompkins <ch...@apache.org>
> To: Commons Developers List <de...@commons.apache.org>
> Sent: Wednesday, 7 June 2017 6:26 AM
> Subject: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
>
>
>
> Hello all,
>
>
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>
>
> Tag name:
>
> commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
>
>
> Tag URL:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>
>
> Commit ID the tag points at:
>
> dd2238b1671644cfead0e87c24a8ac61b4039084
>
>
> Site:
>
> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>
>
> Distribution files (committed at revision 19901):
>
> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>
>
> Distribution files hashes (SHA1):
>
> commons-fileupload-1.3.3-bin.tar.gz
>
> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
>
> commons-fileupload-1.3.3-bin.zip
>
> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
>
> commons-fileupload-1.3.3-src.tar.gz
>
> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
>
> commons-fileupload-1.3.3-src.zip
>
> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>
>
> These are the Maven artifacts and their hashes:
>
> commons-fileupload-1.3.3-javadoc.jar
>
> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
>
> commons-fileupload-1.3.3-sources.jar
>
> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
>
> commons-fileupload-1.3.3-test-sources.jar
>
> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
>
> commons-fileupload-1.3.3-tests.jar
>
> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
>
> commons-fileupload-1.3.3.jar
>
> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
>
> commons-fileupload-1.3.3.pom
>
> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>
>
> KEYS file to check signatures:
>
> http://www.apache.org/dist/commons/KEYS
>
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1249
>
>
> Please select one of the following options[1]:
>
> [ ] +1 Release it.
>
> [ ] +0 Go ahead; I don't care.
>
> [ ] -0 There are a few minor glitches: ...
>
> [ ] -1 No, do not release it because ...
>
>
> This vote will be open at least 72 hours, i.e. until
>
> 2017-06-09T19:00:00Z
>
> (this is UTC time).
>
> --------
>
>
> Cheers,
>
> -Rob
>
>
> [1] http://apache.org/foundation/voting.html
>
> ---------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>
> For additional commands, e-mail: dev-help@commons.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br.INVALID>.
[ X ] +1 Release it.
All tests pass, artifacts generated successfully, and site correctly generated too with `mvn clean test install -e -X` on the following environments.
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
Maven home: /opt/maven
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
Maven home: /opt/maven
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T05:41:47+13:00)
Maven home: /opt/maven
Java version: 1.8.0, vendor: IBM Corporation
Java home: /home/kinow/Development/java/ibm-java-x86_64-80/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-78-generic", arch: "amd64", family: "unix"
Reports look OK. Noticed that coverage could be enhanced for future releases. There are some classes with 0 tests (PortletFileUpload and PortletRequestContext) so I'm adding a note in my todo list to write some tests when I have some spare time (happy if anyone does so first :).
I think NOTICE.txt was not updated to include 2017 in the year (I believe we manually update this file?), but that's trivial and definitely not a blocker (I guess we just fix it later - if necessary).
My local web site has changes report showing 1.3.3 with date as tbd. Yours is showing 1.4 with date set to today, but I guess it's temporary and after the release it will display 1.3.3 and another date? Anyway, FILEUPLOAD-279 is not there, but this shouldn't be a blocker.
Didn't have much time so checked only the main jar gpg signature, and it's also looking OK.
Go for it, and thanks for preparing the release!
Cheers
Bruno
ps: first time I look at the DOAP file while reviewing a release... there are some releases missing there, but I guess it's not updated automagically by Maven... maybe those blocks could be removed?
________________________________
From: Rob Tompkins <ch...@apache.org>
To: Commons Developers List <de...@commons.apache.org>
Sent: Wednesday, 7 June 2017 6:26 AM
Subject: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Hello all,
This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
Tag name:
commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
Tag URL:
https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
Commit ID the tag points at:
dd2238b1671644cfead0e87c24a8ac61b4039084
Site:
http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
Distribution files (committed at revision 19901):
https://dist.apache.org/repos/dist/dev/commons/fileupload/
Distribution files hashes (SHA1):
commons-fileupload-1.3.3-bin.tar.gz
(SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
commons-fileupload-1.3.3-bin.zip
(SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
commons-fileupload-1.3.3-src.tar.gz
(SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
commons-fileupload-1.3.3-src.zip
(SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
These are the Maven artifacts and their hashes:
commons-fileupload-1.3.3-javadoc.jar
(SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
commons-fileupload-1.3.3-sources.jar
(SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
commons-fileupload-1.3.3-test-sources.jar
(SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
commons-fileupload-1.3.3-tests.jar
(SHA1: 20510147958fc759582e6ede789ccf31d056b232)
commons-fileupload-1.3.3.jar
(SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
commons-fileupload-1.3.3.pom
(SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
KEYS file to check signatures:
http://www.apache.org/dist/commons/KEYS
Maven artifacts:
https://repository.apache.org/content/repositories/orgapachecommons-1249
Please select one of the following options[1]:
[ ] +1 Release it.
[ ] +0 Go ahead; I don't care.
[ ] -0 There are a few minor glitches: ...
[ ] -1 No, do not release it because ...
This vote will be open at least 72 hours, i.e. until
2017-06-09T19:00:00Z
(this is UTC time).
--------
Cheers,
-Rob
[1] http://apache.org/foundation/voting.html
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC5
Posted by Benedikt Ritter <br...@apache.org>.
Hello Rob,
Here are my observations:
- link to the tag in the vote mail points to a commit, not a tag
- site looks good
- RELEASE-NOTES are missing in the dist area
- signatures look good
- build works with:
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.8.0_112, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.4", arch: "x86_64", family: „mac"
+1
Benedikt
> Am 06.06.2017 um 20:20 schrieb Rob Tompkins <ch...@apache.org>:
>
> Hello all,
>
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC5).
>
> Tag name:
> commons-fileupload-1.3.3-RC5 (signature can be checked from git using 'git tag -v')
>
> Tag URL:
> https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=commit;h=dd2238b1671644cfead0e87c24a8ac61b4039084
>
> Commit ID the tag points at:
> dd2238b1671644cfead0e87c24a8ac61b4039084
>
> Site:
> http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC5
>
> Distribution files (committed at revision 19901):
> https://dist.apache.org/repos/dist/dev/commons/fileupload/
>
> Distribution files hashes (SHA1):
> commons-fileupload-1.3.3-bin.tar.gz
> (SHA1: 2f4a9672168641ff726974a3b7cc68b97d1212fa)
> commons-fileupload-1.3.3-bin.zip
> (SHA1: b66e2c434ddbda90dfc9e92af4775d9777524bfa)
> commons-fileupload-1.3.3-src.tar.gz
> (SHA1: 71294a7d737a8ced04934c222ae6dfb16e4d8d73)
> commons-fileupload-1.3.3-src.zip
> (SHA1: 661172a2f62b460c4b754b7a0f04d412afabde52)
>
> These are the Maven artifacts and their hashes:
> commons-fileupload-1.3.3-javadoc.jar
> (SHA1: 92d2fc371379d64a822150ca3882157564dd3f99)
> commons-fileupload-1.3.3-sources.jar
> (SHA1: c8c7bcb851fb5af0b19e4ea845cf2fc03de6f673)
> commons-fileupload-1.3.3-test-sources.jar
> (SHA1: 5e0d8c621d38694e0f2960ab2899ee1d67f2b708)
> commons-fileupload-1.3.3-tests.jar
> (SHA1: 20510147958fc759582e6ede789ccf31d056b232)
> commons-fileupload-1.3.3.jar
> (SHA1: fd754c7518772453aea1d5ffc32cb5ce0ebc0e40)
> commons-fileupload-1.3.3.pom
> (SHA1: 97d781eafc190f4fee3abf11f9ec8076f5f7b58c)
>
> KEYS file to check signatures:
> http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
> https://repository.apache.org/content/repositories/orgapachecommons-1249
>
> Please select one of the following options[1]:
> [ ] +1 Release it.
> [ ] +0 Go ahead; I don't care.
> [ ] -0 There are a few minor glitches: ...
> [ ] -1 No, do not release it because ...
>
> This vote will be open at least 72 hours, i.e. until
> 2017-06-09T19:00:00Z
> (this is UTC time).
> --------
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org