You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by et...@apache.org on 2024/03/04 07:58:40 UTC

(incubator-celeborn) branch main updated: [CELEBORN-1134][FOLLOWUP] Add execution.batch-shuffle-mode: ALL_EXCHANGES_BLOCKING to Flink Configuration of Deploy Flink client

This is an automated email from the ASF dual-hosted git repository.

ethanfeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new ce5386397 [CELEBORN-1134][FOLLOWUP] Add execution.batch-shuffle-mode: ALL_EXCHANGES_BLOCKING to Flink Configuration of Deploy Flink client
ce5386397 is described below

commit ce5386397d22c6cc4b060b7dc12e847255796076
Author: SteNicholas <pr...@163.com>
AuthorDate: Mon Mar 4 15:57:40 2024 +0800

    [CELEBORN-1134][FOLLOWUP] Add execution.batch-shuffle-mode: ALL_EXCHANGES_BLOCKING to Flink Configuration of Deploy Flink client
    
    ### What changes were proposed in this pull request?
    
    Add `execution.batch-shuffle-mode: ALL_EXCHANGES_BLOCKING` to `Flink Configuration` of `Deploy Flink client` in `deploy.md`
    
    ### Why are the changes needed?
    
    Validation whether `execution.batch-shuffle-mode` is `ALL_EXCHANGES_BLOCKING` is supported in #2106. `Flink Configuration` of `Deploy Flink client` should also add this configuration.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    No.
    
    Closes #2355 from SteNicholas/CELEBORN-1134.
    
    Authored-by: SteNicholas <pr...@163.com>
    Signed-off-by: mingji <fe...@alibaba-inc.com>
---
 docs/deploy.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/deploy.md b/docs/deploy.md
index 4fdd1d84b..445b76fa1 100644
--- a/docs/deploy.md
+++ b/docs/deploy.md
@@ -208,6 +208,7 @@ Copy $CELEBORN_HOME/flink/*.jar to $FLINK_HOME/lib/
 To use Celeborn, following flink configurations should be added.
 ```properties
 shuffle-service-factory.class: org.apache.celeborn.plugin.flink.RemoteShuffleServiceFactory
+execution.batch-shuffle-mode: ALL_EXCHANGES_BLOCKING
 celeborn.master.endpoints: clb-1:9097,clb-2:9097,clb-3:9097
 
 celeborn.client.shuffle.batchHandleReleasePartition.enabled: true
@@ -225,3 +226,4 @@ taskmanager.network.memory.floating-buffers-per-gate: 4096
 taskmanager.network.memory.buffers-per-channel: 0
 taskmanager.memory.task.off-heap.size: 512m
 ```
+**Note**: The config option `execution.batch-shuffle-mode` should configure as `ALL_EXCHANGES_BLOCKING`.