You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wayneguow (via GitHub)" <gi...@apache.org> on 2024/10/23 05:02:38 UTC
[PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
wayneguow opened a new pull request, #48611:
URL: https://github.com/apache/spark/pull/48611
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to remove some unnecessary Jersey-related warning logs when `ApiRootResource` or `PrometheusResource` api was called.
To reproduce, when we start spark-shell with the latest master code, open the Spark UI, click the executor tab, you can see relevant warning logs appearing in the spark-shell.
There are some related pr and issues about jersey:
- https://github.com/eclipse-ee4j/jersey/pull/4450
- https://github.com/eclipse-ee4j/jersey/pull/4634
- https://github.com/eclipse-ee4j/jersey/issues/5480
And we can solve these warning logs by setting some properties.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Remove unnecessary warning logs.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Manual check. After this pr, the warning logs are removed.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2434329120
Are there any negative impacts of disabling these features? Is it possible to retain these features through upgrading dependencies or code changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2594235201
Gentle ping, @wayneguow . Could you answer the above questions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2601178221
Given that, this PR is the best and safe way to handle these, right, @wayneguow ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2600994654
> Are there any negative impacts of disabling these features? Is it possible to retain these features through upgrading dependencies or code changes?
For the first question：
- For setting `holder.setInitParameter(CommonProperties.PROVIDER_DEFAULT_DISABLE, "DATASOURCE")`, from code https://github.com/eclipse-ee4j/jersey/blob/d9658aa3064236abf1280f16e1705454e5d0b599/core-common/src/main/java/org/glassfish/jersey/message/internal/MessagingBinders.java#L210-L256, since the `DATASOURCE` will be directly removed from `enabledProviders` after the parameter is set, the `providerBinder.bind(binder, provider);` operation will not be performed, so the effect is the same as when printing the warning log.
- For setting `holder.setInitParameter(ServerProperties.WADL_FEATURE_DISABLE, "true")`, from code https://github.com/eclipse-ee4j/jersey/blob/2.x/core-server/src/main/java/org/glassfish/jersey/server/wadl/WadlFeature.java#L51-L57 , the effect is the same, it returns `false`, so there is no negative impact.
For the second question:
Upgrading to the current jersey version does not work, related code and logic still exists in the latest version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2605203551
> If the following two dependencies are in the class path, there will be no corresponding warning logs, but we excluded it in this PR: https://github.com/apache/spark/pull/25481
> - `jakarta.activation:jakarta.activation-api`
> - `jakarta.xml.bind:jakarta.xml.bind-api`
A little bit of further investigation:
Spark already pulls `jakarta.xml.bind-api` into the runtime classpath, in `mllib` module via `jpmml-model` 1.4
https://github.com/apache/spark/blob/98f276730d1dcfb2732a78439270b2578a777a15/dev/deps/spark-deps-hadoop-3-hive-2.3#L122
while this version actually contains `javax.xml.bind.` classes.
`jpmml` migrated to `jakarta.xml.bind.` since 1.5, see https://github.com/jpmml/jpmml-model/issues/41.
I think Spark eventually needs to follow the Jakarta EE specification to migrate to `jakarta` namespace, I did a quick search on Spark's codebase, seems it has no remaining direct reference for `javax.` that needs to migrate, but 3rd libs like `jpmml` might have the transitive reference, it might be a good time to evaluate upgrading `jpmml` to 1.5 or a newer version before Spark 4.0
```
find . -type f \( -name "*.scala" -o -name "*.java" \) -exec grep -h "^import javax\." {} + | awk '{ sub(/;$/, ""); print }' | sort | uniq
```
Back to the issue specific to this PR, I think either the current approach or @LuciferYang's suggestion has no real runtime differences because Spark only uses a few set features of Jersey(which integrates with a lot of Jakarta EE APIs), but I lean toward @LuciferYang's suggestion because it simplifies both `pom.xml` and code -we don't need to carefully analysis the runtime code path and explicitly exclude/disable everything that we don't need, as long as it does not have side-effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE][ML] Upgrade `pmml-model` to 1.7.1 and migrate `jaxb-api` to `jakarta.xml.bind-api`, `activation` to `jakarta.activation-api` to remove jersey-related warning logs [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2638819267
@LuciferYang and @wayneguow
It seems we need to change the code for `pmml-model` 1.4.8 -> 1.7.1 upgrade, so I am a bit worry about the compatibility, I suggest:
1, split this PR, can we make a separate PR for `pmml-model` upgrade first?
2, adding additional tests to make sure `pmml-model 1.7.1` can successfully load previous models. We can save 1~2 pmml modes into `mllib/src/test/resources/ml-models` with Spark 3.5, and then load them in the tests. you can refer to https://github.com/apache/spark/commit/6b7527e381591bcd51be205853aea3e349893139
also cc @WeichenXu123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2600990458
After doing further research, I found out why there are these two warning logs in Spark 4.0 version, but not in Spark 3.x and earlier versions:
1. When Spark 4.0 upgraded `jetty` 10 to 11, it also upgraded `jesery` 2.41 to 3.0.12, related PR: #45154
2. Relevant changes in `jesery` 3.x version(https://github.com/eclipse-ee4j/jersey/commit/c522d34d1c119ce84973978623b9d1fedd8da493):
- MessagingBinders.java:
`DATASOURCE("jakarta.activation.DataSource")` has been added to `EnabledProvidersBinder`.
- WadlFeature.java:
Added some warning logs.
If the following two dependencies are in the class path, there will be no corresponding warning logs, but we excluded it in this PR: #25481
`jakarta.activation:jakarta.activation-api`
`jakarta.xml.bind:jakarta.xml.bind-api`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2594243271
> Gentle ping, @wayneguow . Could you answer the above questions?
@dongjoon-hyun Sorry, I forgot about this, I will confirm the details and give the final solution and reason in the next few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2430966133
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2431874824
also cc @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE][ML] Upgrade `pmml-model` to 1.7.1 and migrate `jaxb-api` to `jakarta.xml.bind-api`, `activation` to `jakarta.activation-api` to remove jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow closed pull request #48611: [SPARK-50082][CORE][ML] Upgrade `pmml-model` to 1.7.1 and migrate `jaxb-api` to `jakarta.xml.bind-api`, `activation` to `jakarta.activation-api` to remove jersey-related warning logs
URL: https://github.com/apache/spark/pull/48611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2601244783
> After doing further research, I found out why there are these two warning logs in Spark 4.0 version, but not in Spark 3.x and earlier versions:
>
> 1. When Spark 4.0 upgraded `jetty` 10 to 11, it also upgraded `jesery` 2.41 to 3.0.12, related PR: [[SPARK-47118][BUILD][CORE][SQL][UI] Migrate from Jetty 10 to Jetty 11 #45154](https://github.com/apache/spark/pull/45154)
> 2. Relevant changes in `jesery` 3.x version([eclipse-ee4j/jersey@c522d34](https://github.com/eclipse-ee4j/jersey/commit/c522d34d1c119ce84973978623b9d1fedd8da493)):
>
> * MessagingBinders.java:
> `DATASOURCE("jakarta.activation.DataSource")` has been added to `EnabledProvidersBinder`.
> * WadlFeature.java:
> Added some check logic and warning logs.
>
> If the following two dependencies are in the class path, there will be no corresponding warning logs, but we excluded it in this PR: #25481 `jakarta.activation:jakarta.activation-api` `jakarta.xml.bind:jakarta.xml.bind-api`
We upgraded from 2.41 to 3.0.x. Actually, there was a similar registration in 2.41 as well, with just a slight difference in the namespace between `javax` and `jakarta`：
https://github.com/eclipse-ee4j/jersey/blob/3eac07f0b10ada9ba4828785ad2cc0ff5cf19f9f/core-common/src/main/java/org/glassfish/jersey/message/internal/MessagingBinders.java#L172
Why didn't we need to make settings similar to the current pr before? I want to know if we revert the changes made by https://github.com/apache/spark/pull/25481, will the issue described in https://github.com/apache/spark/pull/25481 still exist? And could it also resolve the current problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2601185664
> Thank you so much, @wayneguow . I also observed the issue.
>
> Since this is a log-related thing, it seems a little hard to validate.
>
> Could you revise your PR description about how to validate the contributions on the followings from their logs?
>
> * All Spark shell environments (`spark-shell`, `spark-sql`, `pyspark`, `sparkR`) are fixed?
> * Spark Deamons (Spark Master/Worker/HistoryServer) are fixed?
> * Spark Applications on `Spark Standalone Cluster` and `K9s Cluster` (at least)?
Other than that, I'm checking the items listed here one by one and will update the PR description if it's all finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2601181261
> Given that, this PR is the best and safe way to handle these, right, @wayneguow ?
@dongjoon-hyun In my opinion, it's like this. We can also wait for @LuciferYang 's opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2594244455
Thank you so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2606699186
> javax
If time permits, I suggest we try to migrate them to jakarta before Spark 4.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2601177032
Thank you for sharing that, @wayneguow .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE] Remove some unnecessary Jersey-related warning logs [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2601181702
Ack! Sure, let's wait for @LuciferYang 's opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE][ML] Upgrade `pmml-model` to 1.7.1 and migrate `jaxb-api` to `jakarta.xml.bind-api`, `activation` to `jakarta.activation-api` to remove jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2638825365
> @LuciferYang and @wayneguow
>
> It seems we need to change the code for `pmml-model` 1.4.8 -> 1.7.1 upgrade, so I am a bit worry about the compatibility, I suggest: 1, splitting this PR, can we make a separate PR for `pmml-model` upgrade first? 2, adding additional tests to make sure `pmml-model 1.7.1` can successfully load previous models. We can save 1~2 pmml models into `mllib/src/test/resources/ml-models` with Spark 3.5, and then load them in the tests. you can refer to [6b7527e](https://github.com/apache/spark/commit/6b7527e381591bcd51be205853aea3e349893139)
>
> also cc @WeichenXu123
Okay, I agree with your suggestion, let me first ensure that `pmml-model` can be upgraded without loss of compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE][ML] Upgrade `pmml-model` to 1.7.1 and migrate `jaxb-api` to `jakarta.xml.bind-api`, `activation` to `jakarta.activation-api` to remove jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2629214590
@dongjoon-hyun @LuciferYang @pan3793 Late on updating the PR. If you all get a chance, I'd appreciate another look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50082][CORE][ML] Upgrade `pmml-model` to 1.7.1 and migrate `jaxb-api` to `jakarta.xml.bind-api`, `activation` to `jakarta.activation-api` to remove jersey-related warning logs [spark]
Posted by "wayneguow (via GitHub)" <gi...@apache.org>.
wayneguow commented on PR #48611:
URL: https://github.com/apache/spark/pull/48611#issuecomment-2629217625
Also cc @zhengruifeng for the ML part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org