You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 19:39:09 UTC

[GitHub] [arrow] alamb opened a new pull request #9879: Less symbols in integration

alamb opened a new pull request #9879:
URL: https://github.com/apache/arrow/pull/9879


   # Rationale
   Rust debug symbols are quite verbose, taking up memory during the final link time as well as significant disk space. Turning off the creation of symbols should save us compile / test time for CI as well as space on the integration test
   
   # Change
   Do not produce debug symbols on Rust CI (keep enough to have line numbers in `panic!` traceback, but not enough to interpret a core file, which no one does to my knowledge anyways)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9879: ARROW-12112: [Rust] Create and store less debug information in CI and integration tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9879:
URL: https://github.com/apache/arrow/pull/9879#issuecomment-812892775


   https://issues.apache.org/jira/browse/ARROW-12112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #9879: ARROW-12112: [Rust] Create and store less debug information in CI and integration tests

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9879:
URL: https://github.com/apache/arrow/pull/9879#issuecomment-812894506


   @alamb See here: https://github.com/apache/arrow/compare/master...pitrou:ARROW-12112-conda-integration#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3R1192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9879: ARROW-12112: [Rust] Create and store less debug information in CI and integration tests

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9879:
URL: https://github.com/apache/arrow/pull/9879


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou edited a comment on pull request #9879: ARROW-12112: [Rust] Create and store less debug information in CI and integration tests

Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #9879:
URL: https://github.com/apache/arrow/pull/9879#issuecomment-812894506


   @alamb See [here](https://github.com/apache/arrow/compare/master...pitrou:ARROW-12112-conda-integration#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3R1192)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9879: ARROW-12112: [Rust] Create and store less debug information in CI and integration tests

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9879:
URL: https://github.com/apache/arrow/pull/9879#issuecomment-812894310


   > For the record, how much space did this save?
   
   
   @pitrou  I did not measure it -- how did you do so?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9879: ARROW-12112: [Rust][CI] Create and store less debug information in CI and integration tests

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9879:
URL: https://github.com/apache/arrow/pull/9879#issuecomment-812898760


   I have created https://github.com/apache/arrow/pull/9883 and https://github.com/apache/arrow/pull/9884 to find out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9879: ARROW-TODO: [Rust] Create and store less debug information in CI and integration tests

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9879:
URL: https://github.com/apache/arrow/pull/9879#issuecomment-812681420


   I will do the CI / JIRA dance if this PR works out


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9879: Less symbols in integration

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9879:
URL: https://github.com/apache/arrow/pull/9879#issuecomment-812681117


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org