You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/06/14 14:57:49 UTC

[GitHub] peng-yongsheng opened a new issue #1352: H2 storage implementation

peng-yongsheng opened a new issue #1352: H2 storage implementation
URL: https://github.com/apache/incubator-skywalking/issues/1352
 
 
   Thanks to @chidaodezhongsheng for PR #1347 which is the storage implementation of ShardingJDBC.
    
   ShardingJDBC is using mysql driver based on the SQL grammar. H2 database also supported it by the JDBC API. I prefer use the ShardingJDBC-Storage-DAO instead of current implementation of H2 storage. We can reduce a lot of development and testing for the H2 storage implementation.
   
   Two ways:
   1. H2's DAO extends ShardingJDBC's DAO.
   2. Move ShardingJDBC's DAO into H2's package then make ShardingJDBC's DAO extends H2's DAO
   
   FYI @wu-sheng @chidaodezhongsheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services