[jira] [Commented] (OFBIZ-13664) getOrderedSummaryInformation ignores explicit fromDate and thruDate

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-13664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18125397#comment-18125397 ] 

ASF subversion and git services commented on OFBIZ-13664:
---------------------------------------------------------

Commit 7ab39ee2cd99aaa61f84be5682ff62749133db4a in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7ab39ee2cd ]

Fixed: getOrderedSummaryInformation ignores explicit fromDate and thruDate (OFBIZ-13664)

The service declares fromDate and thruDate as IN attributes and the mini-lang used them to restrict the orders, letting monthsToInclude override them. The Groovy conversion initialised both to null and only set them from monthsToInclude, so callers passing only dates received the totals of all orders. Seed fromDate and thruDate from the parameters again, and keep monthsToInclude overriding them.


> getOrderedSummaryInformation ignores explicit fromDate and thruDate
> -------------------------------------------------------------------
>
>                 Key: OFBIZ-13664
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13664
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Upcoming Branch, 24.09.07
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Major
>
> The service declares {{fromDate}} and {{thruDate}} as IN attributes and the mini-lang filtered orders with them ({{orderDate >= parameters.fromDate}}, {{<= parameters.thruDate}}, ignoring nulls), letting {{monthsToInclude}} override. The Groovy initialises both to null and only sets them from {{monthsToInclude}}. Callers that pass only dates, such as the promotion condition PPIP_ORST_LAST_YEAR ("order sub-total since beginning of last year"), receive the lifetime total.
> h3. Fix
> Seed {{fromDate}} / {{thruDate}} from the parameters and let {{monthsToInclude}} override them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)