You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/15 18:05:55 UTC
Re: Review Request 60623: Convert "file://" URI handling to use new
path::uri() function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60623/#review182971
-----------------------------------------------------------
Ship it!
Just a note though: I don't see any use in this patch of that `bool addprefix` part of the new `paths::uri` interface.
- Andrew Schwartzmeyer
On July 3, 2017, 12:31 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60623/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 12:31 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-6705
> https://issues.apache.org/jira/browse/MESOS-6705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Convert "file://" URI handling to use new path::uri() function.
>
>
> Diffs
> -----
>
> src/tests/credentials_tests.cpp 7eb5abd21a1be35d4739c4928cb922f028cfc9a7
> src/tests/fetcher_tests.cpp 99149baa1c7abfabf572a0d0f4512a8e84d1e5be
> src/tests/master_contender_detector_tests.cpp f499136c0b981072af5bc8accf2238b7ba4bf430
> src/tests/script.cpp 8d40e01da005cb05e7804f0b3975e3e0edb8f3bd
>
>
> Diff: https://reviews.apache.org/r/60623/diff/1/
>
>
> Testing
> -------
>
> See upstream
>
>
> Thanks,
>
> Jeff Coffler
>
>