You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2008/08/09 14:16:05 UTC
svn commit: r684241 - in
/maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model:
PluginMetadataParseException.java PluginMetadataParser.java
Author: vsiveton
Date: Sat Aug 9 05:16:04 2008
New Revision: 684241
URL: http://svn.apache.org/viewvc?rev=684241&view=rev
Log:
o fixed checkstyle + updated javadoc
Modified:
maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParseException.java
maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParser.java
Modified: maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParseException.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParseException.java?rev=684241&r1=684240&r2=684241&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParseException.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParseException.java Sat Aug 9 05:16:04 2008
@@ -37,9 +37,9 @@
private final String originalMessage;
/**
- * @param metadataFile
- * @param message
- * @param cause
+ * @param metadataFile could be null
+ * @param message could be null
+ * @param cause could be null
*/
public PluginMetadataParseException( File metadataFile, String message, Throwable cause )
{
@@ -50,8 +50,8 @@
}
/**
- * @param metadataFile
- * @param message
+ * @param metadataFile could be null
+ * @param message could be null
*/
public PluginMetadataParseException( File metadataFile, String message )
{
Modified: maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParser.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParser.java?rev=684241&r1=684240&r2=684241&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParser.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-model/src/main/java/org/apache/maven/plugin/tools/model/PluginMetadataParser.java Sat Aug 9 05:16:04 2008
@@ -44,6 +44,8 @@
*/
public class PluginMetadataParser
{
+ /** Default implementation path which will be replaced in
+ * AbstractScriptedMojoDescriptorExtractor#extractMojoDescriptorsFromMetadata(Map, PluginDescriptor) */
public static final String IMPL_BASE_PLACEHOLDER = "<REPLACE-WITH-MOJO-PATH>";
/**
@@ -96,6 +98,12 @@
return descriptors;
}
+ /**
+ * @param metadataFile not null
+ * @param mojo not null
+ * @return a mojo descriptor instance
+ * @throws PluginMetadataParseException if any
+ */
private MojoDescriptor asDescriptor( File metadataFile, Mojo mojo )
throws PluginMetadataParseException
{
@@ -151,8 +159,8 @@
if ( StringUtils.isEmpty( dParam.getName() ) )
{
- throw new PluginMetadataParseException( metadataFile, "Mojo: \'" + mojo.getGoal() +
- "\' has a parameter without either property or name attributes. Please specify one." );
+ throw new PluginMetadataParseException( metadataFile, "Mojo: \'" + mojo.getGoal()
+ + "\' has a parameter without either property or name attributes. Please specify one." );
}
dParam.setRequired( param.isRequired() );
@@ -165,8 +173,8 @@
catch ( DuplicateParameterException e )
{
throw new PluginMetadataParseException( metadataFile,
- "Duplicate parameters detected for mojo: " + mojo.getGoal(),
- e );
+ "Duplicate parameters detected for mojo: "
+ + mojo.getGoal(), e );
}
}
}