[GitHub] [drill] vvysotskyi commented on pull request #2401: DRILL-8056: Add OAuth2 Support for HTTP Rest Plugin

[GitBox <gi...@apache.org>]

vvysotskyi commented on pull request #2401:
URL: https://github.com/apache/drill/pull/2401#issuecomment-1017659175


   @cgivre, for now, we can query Dropbox using the file storage plugin, but Dropbox also supports OAuth (in their docs I didn't find differences with OAuth), so extracting that logic to the OAuth creds provider and removing dependency to HTTP plugin will automatically enable this and other similar cases. If we have some specific logic for Google Sheets, in the future we can extend that implementation of the OAuth creds provider to handle additional cases.
   
   Regarding concurrent updates of the token, I think it is a major issue because we could have high concurrent queries (even for a single user) that will be slowed down because of unnecessary updating of the access_token. Please take a look at the versioned persistent store, I think it can be used to solve that issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org