You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/16 10:44:11 UTC
[GitHub] [apisix-ingress-controller] fhuzero opened a new pull request #598: feat: support for Knative
fhuzero opened a new pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
#533
___
### New feature or improvement
- Describe the details and related test reports.
* This PR provides support for Knative so that APISIX Ingress Controller is an alternative to KIngress implementation. It can replace Istio, Gloo, Kourier, or Kong to serve as the network layer of Knative Serving.
* A demo to run Hello World app with APISIX Ingress Controller backed Knative is provided in _knative-support.md_.
* It has passed around 70% of Knative conformance test. _test/conformance/README.md_ explains how to run it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #598: feat: support for Knative
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598#issuecomment-884618421
@fhuzero Thanks for your great contributions. The PR is too huge to review, would you mind to separate it into multiple PRs so that we can implement this feature gradually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fhuzero commented on pull request #598: feat: support for Knative
Posted by GitBox <gi...@apache.org>.
fhuzero commented on pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598#issuecomment-884663398
> @fhuzero Thanks for your great contributions. The PR is too huge to review, would you mind separating it into multiple PRs so that we can implement this feature gradually.
Thanks for your suggestion! I'll divide the PR into small parts to make it easier for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers edited a comment on pull request #598: feat: support for Knative
Posted by GitBox <gi...@apache.org>.
tokers edited a comment on pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598#issuecomment-884618421
@fhuzero Thanks for your great contributions. The PR is too huge to review, would you mind separating it into multiple PRs so that we can implement this feature gradually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fhuzero closed pull request #598: feat: support for Knative
Posted by GitBox <gi...@apache.org>.
fhuzero closed pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Yiyiyimu commented on a change in pull request #598: feat: support for Knative
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598#discussion_r674248071
##########
File path: tmpvendor/knative.dev/networking/test/test_images/grpc-ping/main.go
##########
@@ -0,0 +1,111 @@
+/*
+Copyright 2019 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package main
Review comment:
Got it. Thanks for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] fhuzero commented on a change in pull request #598: feat: support for Knative
Posted by GitBox <gi...@apache.org>.
fhuzero commented on a change in pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598#discussion_r673893107
##########
File path: tmpvendor/knative.dev/networking/test/test_images/grpc-ping/main.go
##########
@@ -0,0 +1,111 @@
+/*
+Copyright 2019 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package main
Review comment:
In theory, this directory can be replaced with its online version hosted on GitHub. I've been trying to replace it and reorg Knative-related test directory but encountered some bugs. I'll remove the directory once reorg is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Yiyiyimu commented on a change in pull request #598: feat: support for Knative
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #598:
URL: https://github.com/apache/apisix-ingress-controller/pull/598#discussion_r673570980
##########
File path: tmpvendor/knative.dev/networking/test/test_images/grpc-ping/main.go
##########
@@ -0,0 +1,111 @@
+/*
+Copyright 2019 The Knative Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package main
Review comment:
Hi @fhuzero do we still need this directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org