[GitHub] [arrow] MannySchneck commented on pull request #14554: ARROW-18208 [JS] Fixes crash when inferring objects with string-valued keys nested in an array

[GitBox <gi...@apache.org>]

MannySchneck commented on PR #14554:
URL: https://github.com/apache/arrow/pull/14554#issuecomment-1297910163

   Reverted the code change and re-ran the test I wrote:
   
   ```
   manny|arrow/js> yarn test
   yarn run v1.22.19
   $ cross-env NODE_NO_WARNINGS=1 gulp test
   [20:50:59] Using gulpfile ~/code/arrow/js/gulpfile.js
   [20:50:59] Starting 'test'...
   [20:50:59] Starting 'test:ts'...
   [20:50:59] Starting 'test:src'...
   [20:50:59] Starting 'test:apache-arrow'...
   [20:50:59] Starting 'test:es5:cjs'...
   Determining test suites to run...Determining test suites to run...Determining test suites to run...Determini
   ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
   transform: {
       <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
   },
   ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
   transform: {
       <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
   },
   ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
   transform: {
       <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
   },
   ts-jest[ts-jest-transformer] (WARN) Define `ts-jest` config under `globals` is deprecated. Please do
   transform: {
       <transform_regex>: ['ts-jest', { /* ts-jest config goes here in Jest */ }],
   },
   
     ● tableFromJSON() › creates table from objects with string values nested in an array
   
       TypeError: Unable to infer Vector type from input values, explicit type declaration expected
   
         166 |     }
         167 |
       > 168 |     throw new TypeError('Unable to infer Vector type from input values, explicit type declaration expected');
             |           ^
         169 | }
         170 |
         171 | /**
   
         at inferType (targets/ts/factories.ts:168:11)
         at inferType (targets/ts/factories.ts:161:52)
         at vectorFromArray (targets/ts/factories.ts:86:61)
         at tableFromJSON (targets/ts/factories.ts:101:20)
         at Object.<anonymous> (test/unit/table/table-test.ts:83:16)
   
   
     ● tableFromJSON() › creates table from objects with string values nested in an array
   
       TypeError: Unable to infer Vector type from input values, explicit type declaration expected
   
         166 |     }
         167 |
       > 168 |     throw new TypeError('Unable to infer Vector type from input values, explicit type declaration expected');
             |           ^
         169 | }
         170 |
         171 | /**
   
         at inferType (targets/apache-arrow/src/factories.ts:168:11)
         at inferType (targets/apache-arrow/src/factories.ts:161:52)
         at vectorFromArray (targets/apache-arrow/src/factories.ts:86:61)
         at tableFromJSON (targets/apache-arrow/src/factories.ts:101:20)
         at Object.<anonymous> (test/unit/table/table-test.ts:83:29)
   
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org