You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Randall Hauch <rh...@gmail.com> on 2019/04/29 22:34:06 UTC
[VOT] KIP-449: Add connector contexts to Connect worker logs (vote thread)
I would like to start the vote for KIP-258:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API to
add more context to log messages from within Connect workers and connector
implementations. This would not be enabled by default, though it would be
easy to enable within the Connect Log4J configuration.
Thanks!
Randall
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Randall Hauch <rh...@gmail.com>.
Thanks everyone! The vote has been open for about 9 days, and the KIP is
adopted with +4 binding votes (Randall, Manikumar, Gwen, and Bill) and no
-1 votes. Thanks also to Jeremy, Magesh, Chris, and Konstantine for their
non-binding votes.
On Thu, May 9, 2019 at 1:59 PM Bill Bejeck <bb...@gmail.com> wrote:
> +1 (binding)
> Makes a lot of sense to me.
>
> -Bill
>
> On Thu, May 9, 2019 at 2:05 PM Gwen Shapira <gw...@confluent.io> wrote:
>
> > +1 (binding)
> > Hell yeah!
> >
> > On Mon, Apr 29, 2019 at 3:34 PM Randall Hauch <rh...@gmail.com> wrote:
> >
> > > I would like to start the vote for KIP-258:
> > >
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
> > >
> > > The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API
> to
> > > add more context to log messages from within Connect workers and
> > connector
> > > implementations. This would not be enabled by default, though it would
> be
> > > easy to enable within the Connect Log4J configuration.
> > >
> > > Thanks!
> > >
> > > Randall
> > >
> >
> >
> > --
> > *Gwen Shapira*
> > Product Manager | Confluent
> > 650.450.2760 | @gwenshap
> > Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> > <http://www.confluent.io/blog>
> >
>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Bill Bejeck <bb...@gmail.com>.
+1 (binding)
Makes a lot of sense to me.
-Bill
On Thu, May 9, 2019 at 2:05 PM Gwen Shapira <gw...@confluent.io> wrote:
> +1 (binding)
> Hell yeah!
>
> On Mon, Apr 29, 2019 at 3:34 PM Randall Hauch <rh...@gmail.com> wrote:
>
> > I would like to start the vote for KIP-258:
> >
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
> >
> > The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API to
> > add more context to log messages from within Connect workers and
> connector
> > implementations. This would not be enabled by default, though it would be
> > easy to enable within the Connect Log4J configuration.
> >
> > Thanks!
> >
> > Randall
> >
>
>
> --
> *Gwen Shapira*
> Product Manager | Confluent
> 650.450.2760 | @gwenshap
> Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
> <http://www.confluent.io/blog>
>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding)
Hell yeah!
On Mon, Apr 29, 2019 at 3:34 PM Randall Hauch <rh...@gmail.com> wrote:
> I would like to start the vote for KIP-258:
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
>
> The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API to
> add more context to log messages from within Connect workers and connector
> implementations. This would not be enabled by default, though it would be
> easy to enable within the Connect Log4J configuration.
>
> Thanks!
>
> Randall
>
--
*Gwen Shapira*
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
<http://www.confluent.io/blog>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Manikumar <ma...@gmail.com>.
HI Randall,
+1 (binding), Thanks for the KIP.
Thanks,
Manikumar
On Wed, May 8, 2019 at 4:29 AM Randall Hauch <rh...@gmail.com> wrote:
> +1 (binding)
>
> On Mon, May 6, 2019 at 3:53 PM Konstantine Karantasis <
> konstantine@confluent.io> wrote:
>
> > Great improvement for multi-tenancy.
> > Thanks Randall!
> >
> > +1 (non-binding)
> >
> > Konstantine
> >
> > On Tue, Apr 30, 2019 at 9:18 PM Chris Egerton <ch...@confluent.io>
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > Really looking forward to this. Thanks, Randall!
> > >
> > > On Tue, Apr 30, 2019, 20:47 Magesh Nandakumar <ma...@confluent.io>
> > > wrote:
> > >
> > > > This will make connect debugging so much easier. Thanks a lot for
> > driving
> > > > this Randall.
> > > >
> > > > +1 (non-binding)
> > > >
> > > > Thanks,
> > > > Magesh
> > > >
> > > > On Tue, Apr 30, 2019 at 7:19 PM Jeremy Custenborder <
> > > > jcustenborder@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 non binding
> > > > >
> > > > > On Mon, Apr 29, 2019 at 5:34 PM Randall Hauch <rh...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > I would like to start the vote for KIP-258:
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
> > > > > >
> > > > > > The KIP uses the Mapped Diagnostic Contexts (MDC) feature of
> SLF4J
> > > API
> > > > to
> > > > > > add more context to log messages from within Connect workers and
> > > > > connector
> > > > > > implementations. This would not be enabled by default, though it
> > > would
> > > > be
> > > > > > easy to enable within the Connect Log4J configuration.
> > > > > >
> > > > > > Thanks!
> > > > > >
> > > > > > Randall
> > > > >
> > > >
> > >
> >
>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Randall Hauch <rh...@gmail.com>.
+1 (binding)
On Mon, May 6, 2019 at 3:53 PM Konstantine Karantasis <
konstantine@confluent.io> wrote:
> Great improvement for multi-tenancy.
> Thanks Randall!
>
> +1 (non-binding)
>
> Konstantine
>
> On Tue, Apr 30, 2019 at 9:18 PM Chris Egerton <ch...@confluent.io> wrote:
>
> > +1 (non-binding)
> >
> > Really looking forward to this. Thanks, Randall!
> >
> > On Tue, Apr 30, 2019, 20:47 Magesh Nandakumar <ma...@confluent.io>
> > wrote:
> >
> > > This will make connect debugging so much easier. Thanks a lot for
> driving
> > > this Randall.
> > >
> > > +1 (non-binding)
> > >
> > > Thanks,
> > > Magesh
> > >
> > > On Tue, Apr 30, 2019 at 7:19 PM Jeremy Custenborder <
> > > jcustenborder@gmail.com>
> > > wrote:
> > >
> > > > +1 non binding
> > > >
> > > > On Mon, Apr 29, 2019 at 5:34 PM Randall Hauch <rh...@gmail.com>
> > wrote:
> > > > >
> > > > > I would like to start the vote for KIP-258:
> > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
> > > > >
> > > > > The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J
> > API
> > > to
> > > > > add more context to log messages from within Connect workers and
> > > > connector
> > > > > implementations. This would not be enabled by default, though it
> > would
> > > be
> > > > > easy to enable within the Connect Log4J configuration.
> > > > >
> > > > > Thanks!
> > > > >
> > > > > Randall
> > > >
> > >
> >
>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Konstantine Karantasis <ko...@confluent.io>.
Great improvement for multi-tenancy.
Thanks Randall!
+1 (non-binding)
Konstantine
On Tue, Apr 30, 2019 at 9:18 PM Chris Egerton <ch...@confluent.io> wrote:
> +1 (non-binding)
>
> Really looking forward to this. Thanks, Randall!
>
> On Tue, Apr 30, 2019, 20:47 Magesh Nandakumar <ma...@confluent.io>
> wrote:
>
> > This will make connect debugging so much easier. Thanks a lot for driving
> > this Randall.
> >
> > +1 (non-binding)
> >
> > Thanks,
> > Magesh
> >
> > On Tue, Apr 30, 2019 at 7:19 PM Jeremy Custenborder <
> > jcustenborder@gmail.com>
> > wrote:
> >
> > > +1 non binding
> > >
> > > On Mon, Apr 29, 2019 at 5:34 PM Randall Hauch <rh...@gmail.com>
> wrote:
> > > >
> > > > I would like to start the vote for KIP-258:
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
> > > >
> > > > The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J
> API
> > to
> > > > add more context to log messages from within Connect workers and
> > > connector
> > > > implementations. This would not be enabled by default, though it
> would
> > be
> > > > easy to enable within the Connect Log4J configuration.
> > > >
> > > > Thanks!
> > > >
> > > > Randall
> > >
> >
>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Chris Egerton <ch...@confluent.io>.
+1 (non-binding)
Really looking forward to this. Thanks, Randall!
On Tue, Apr 30, 2019, 20:47 Magesh Nandakumar <ma...@confluent.io> wrote:
> This will make connect debugging so much easier. Thanks a lot for driving
> this Randall.
>
> +1 (non-binding)
>
> Thanks,
> Magesh
>
> On Tue, Apr 30, 2019 at 7:19 PM Jeremy Custenborder <
> jcustenborder@gmail.com>
> wrote:
>
> > +1 non binding
> >
> > On Mon, Apr 29, 2019 at 5:34 PM Randall Hauch <rh...@gmail.com> wrote:
> > >
> > > I would like to start the vote for KIP-258:
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
> > >
> > > The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API
> to
> > > add more context to log messages from within Connect workers and
> > connector
> > > implementations. This would not be enabled by default, though it would
> be
> > > easy to enable within the Connect Log4J configuration.
> > >
> > > Thanks!
> > >
> > > Randall
> >
>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Magesh Nandakumar <ma...@confluent.io>.
This will make connect debugging so much easier. Thanks a lot for driving
this Randall.
+1 (non-binding)
Thanks,
Magesh
On Tue, Apr 30, 2019 at 7:19 PM Jeremy Custenborder <jc...@gmail.com>
wrote:
> +1 non binding
>
> On Mon, Apr 29, 2019 at 5:34 PM Randall Hauch <rh...@gmail.com> wrote:
> >
> > I would like to start the vote for KIP-258:
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
> >
> > The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API to
> > add more context to log messages from within Connect workers and
> connector
> > implementations. This would not be enabled by default, though it would be
> > easy to enable within the Connect Log4J configuration.
> >
> > Thanks!
> >
> > Randall
>
Re: [VOT] KIP-449: Add connector contexts to Connect worker logs
(vote thread)
Posted by Jeremy Custenborder <jc...@gmail.com>.
+1 non binding
On Mon, Apr 29, 2019 at 5:34 PM Randall Hauch <rh...@gmail.com> wrote:
>
> I would like to start the vote for KIP-258:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs
>
> The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API to
> add more context to log messages from within Connect workers and connector
> implementations. This would not be enabled by default, though it would be
> easy to enable within the Connect Log4J configuration.
>
> Thanks!
>
> Randall