You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2011/10/26 12:54:04 UTC

Review Request: implement a hedwig console to use/intract with/admin hedwig system.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2570/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

using zookeeper client to read metadata, use hedwig client to interact with hedwig, use bookkeeper client to openLedgerNoRecovery to read messages to implement a hedwig console


This addresses bug BOOKKEEPER-77.
    http://issues.apache.org/jira/browse/BOOKKEEPER-77


Diffs
-----

  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-console/bin/hedwig_console PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-console/conf/hedwig-env.sh PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-console/conf/hedwig_console.conf PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-console/pom.xml PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-console/src/main/java/org/apache/hedwig/client/console/HedwigConsole.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-console/src/main/java/org/apache/hedwig/client/console/JLineHedwigCompletor.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-console/src/main/java/org/apache/hedwig/client/console/ReadTopic.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/pom.xml 1188996 

Diff: https://reviews.apache.org/r/2570/diff


Testing
-------


Thanks,

Sijie


Re: Review Request: implement a hedwig console to use/intract with/admin hedwig system.

Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2570/
-----------------------------------------------------------

(Updated 2012-02-02 12:48:24.354170)


Review request for bookkeeper.


Changes
-------

attach a new patch based on trunk. in this patch, I did some cleanup to move all the meta-related operations such as getTopics, show topic info into a admin class. 


Summary
-------

using zookeeper client to read metadata, use hedwig client to interact with hedwig, use bookkeeper client to openLedgerNoRecovery to read messages to implement a hedwig console


This addresses bug BOOKKEEPER-77.
    http://issues.apache.org/jira/browse/BOOKKEEPER-77


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/bin/hedwig 1239585 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/pom.xml 1239585 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/JLineHedwigCompletor.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java PRE-CREATION 

Diff: https://reviews.apache.org/r/2570/diff


Testing
-------


Thanks,

Sijie


Re: Review Request: implement a hedwig console to use/intract with/admin hedwig system.

Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2570/
-----------------------------------------------------------

(Updated 2011-10-28 11:59:22.626468)


Review request for bookkeeper.


Changes
-------

made changed according to Ivan's suggestions:
1) move it to hedwig-server, so the console can be distributed with hedwig-server, which ease administration.
2) move commands and options to a separated file, change them to final static strings.
3) can use 'help <command>' to display detail usage for a specific command
4) change zkquorum to zkserver

since, 'describe topic <topic>' can display subscriptions of a specific topic, so I didn't add a new command for 'show subscriptions'.


Summary
-------

using zookeeper client to read metadata, use hedwig client to interact with hedwig, use bookkeeper client to openLedgerNoRecovery to read messages to implement a hedwig console


This addresses bug BOOKKEEPER-77.
    http://issues.apache.org/jira/browse/BOOKKEEPER-77


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/bin/hedwig 1188996 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/pom.xml 1188996 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/JLineHedwigCompletor.java PRE-CREATION 
  http://svn.apache.org/repos/asf/zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java PRE-CREATION 

Diff: https://reviews.apache.org/r/2570/diff


Testing
-------


Thanks,

Sijie