You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/28 15:25:31 UTC

[GitHub] [spark] MaxGekk commented on pull request #35274: [SPARK-37982] Use error classes in the execution errors related to unsupported input type

MaxGekk commented on pull request #35274:
URL: https://github.com/apache/spark/pull/35274#issuecomment-1080794466


   >  but how can I pass the non struct type to throw QueryExecutionErrors.inputTypeUnsupportedError(other)?
   
   @leesf Could you replace the exception by `IllegalStateException` and remove `inputTypeUnsupportedError` from `QueryExecutionErrors`.
   
   The requirement of the input type in the exception:
   ```scala
     override def inputTypes: Seq[AbstractDataType] = StructType :: Nil
   ```
   can guarantee that the input type must be a struct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org