You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Karl Pauls (Jira)" <ji...@apache.org> on 2021/06/10 13:31:00 UTC
[jira] [Commented] (SLING-10481) Review filter.xml creation for
content package output of converter
[ https://issues.apache.org/jira/browse/SLING-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360894#comment-17360894 ]
Karl Pauls commented on SLING-10481:
------------------------------------
[~kwin] - what was the thinking behind [0]? Additionally, is this correct relative to: [1]?
[~angela] and I are trying to find out if the filters are still adjusted correctly if the content packages have changed.
[0] https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/84d4de7738883a01a3c4619aac9c36406dcdd736/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/VaultPackageAssembler.java#L290
[1] https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/84d4de7738883a01a3c4619aac9c36406dcdd736/src/main/java/org/apache/sling/feature/cpconverter/handlers/BundleEntryHandler.java#L419
> Review filter.xml creation for content package output of converter
> ------------------------------------------------------------------
>
> Key: SLING-10481
> URL: https://issues.apache.org/jira/browse/SLING-10481
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
> Affects Versions: Content-Package to Feature Model Converter 1.1.4
> Reporter: Karl Pauls
> Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.6
>
>
> The converter used to recalculate the filters for content-packages. Starting with SLING-10243 that was made optional (maybe to not do it for sling initial content packages) - however, it looks like it is now not done at all anymore.
> We have to see if that is what we want and if the filters are still correct for the converted packages (especially in the context of the principal and acl work).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)