You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/04 18:57:18 UTC

[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5490: TP Remember Pagination on ag-grids

shamrickus commented on a change in pull request #5490:
URL: https://github.com/apache/trafficcontrol/pull/5490#discussion_r570468727



##########
File path: traffic_portal/app/src/common/modules/table/servers/TableServersController.js
##########
@@ -414,6 +414,16 @@ var TableServersController = function(tableName, servers, filter, $scope, $state
 			} catch (e) {
 				console.error("Failure to load stored page size:", e);
 			}
+			
+			try {
+				const page = localStorage.getItem(tableName + "_table_page");
+				const pageSize = $scope.gridOptions.api.paginationGetPageSize();
+				if (page !== undefined && page > 0 && page <= pageSize-1) {

Review comment:
       Woops, I changed it `pagenationGetTotalPages` but I must've undid that change at some point.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org