[GitHub] [metamodel] arjansh commented on a change in pull request #229: Upgrade to Elasticsearch 7.3.1

[GitBox <gi...@apache.org>]

arjansh commented on a change in pull request #229: Upgrade to Elasticsearch 7.3.1
URL: https://github.com/apache/metamodel/pull/229#discussion_r328100753
 
 

 ##########
 File path: elasticsearch/native/src/main/java/org/apache/metamodel/elasticsearch/nativeclient/ElasticSearchDataContextFactory.java
 ##########
 @@ -131,10 +135,16 @@ public DataContext create(DataContextProperties properties, ResourceFactoryRegis
     }
 
     private Client createTransportClient(DataContextProperties properties) {
-        final Settings settings = Settings.builder().put().put("name", "MetaModel").put("cluster.name", getCluster(properties)).build();
+        final Settings settings = Settings
+                .builder()
+                .put("name", "MetaModel")
 
 Review comment:
   I had to remove one "put()" here to get it to work, otherwise I wouldn't have touched this piece of code at all. Since the nativeclient will be deprected as part of this PR, I'd rather change as little of the internal implementation as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services