You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/01/22 07:41:03 UTC

Review Request 30156: Versions: cannot register version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30156/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk, Srimanth Gunturi, and Yusaku Sako.


Bugs: AMBARI-9252
    https://issues.apache.org/jira/browse/AMBARI-9252


Repository: ambari


Description
-------

ng-if create its own scope, need to refer to $parent when use ng-model in ng-if


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 18a5700 
  ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 11d42f9 

Diff: https://reviews.apache.org/r/30156/diff/


Testing
-------

Manually tested in live cluster. All unit test passed.


Thanks,

Richard Zang

Re: Review Request 30156: Versions: cannot register version

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30156/#review69141
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Янв. 22, 2015, 6:41 д.п., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30156/
> -----------------------------------------------------------
> 
> (Updated Янв. 22, 2015, 6:41 д.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9252
>     https://issues.apache.org/jira/browse/AMBARI-9252
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ng-if create its own scope, need to refer to $parent when use ng-model in ng-if
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 18a5700 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 11d42f9 
> 
> Diff: https://reviews.apache.org/r/30156/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in live cluster. All unit test passed.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>