[GitHub] [airflow] pgagnon commented on issue #5824: [AIRFLOW-5215] Add sidecar containers support to Pod class

[GitBox <gi...@apache.org>]

pgagnon commented on issue #5824: [AIRFLOW-5215] Add sidecar containers support to Pod class
URL: https://github.com/apache/airflow/pull/5824#issuecomment-528917651
 
 
   > Does this have the problem where the task won't finish as long as the sidecar container is still alive? Do we need an option to kill the sidecar when the main pod finishes?
   
   @ashb Yes, it does. This PR is basically a bandaid to allow users to add sidecars with the pod mutation hook.
   
   Users have a couple of options to kill the sidecar when the main container exits:
   
   - Give the sidecar API access and check the pod's status;
   - Have the main container write a heartbeat to a volume shared with the sidecar
   
   Obviously both these methods are rather hackish, but I can't immediately think of a straightforward way to kill the sidecar when the main container exits, that would support both `KubernetesPodOperator` and `KubernetesExecutor`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services