[GitHub] [kafka] hachikuji commented on a diff in pull request #12086: Minor : cleanup.policy is a comma separated list

[GitBox <gi...@apache.org>]

hachikuji commented on code in PR #12086:
URL: https://github.com/apache/kafka/pull/12086#discussion_r885117228


##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -139,7 +139,7 @@ public class TopicConfig {
     public static final String CLEANUP_POLICY_CONFIG = "cleanup.policy";
     public static final String CLEANUP_POLICY_COMPACT = "compact";
     public static final String CLEANUP_POLICY_DELETE = "delete";
-    public static final String CLEANUP_POLICY_DOC = "A string that is either \"" + CLEANUP_POLICY_DELETE +
+    public static final String CLEANUP_POLICY_DOC = "A comma separated list of String(s) that is either \"" + CLEANUP_POLICY_DELETE +

Review Comment:
   This config could use a rewrite. Let me take a stab.
   
   > This config designates the retention policy to use on old log segments. The "delete" policy (which is the default) will discard old segments when their retention time or size limit has been reached. The "compact" policy will enable log compaction. It is also possible to specify both policies in a comma-separated list (e.g. "delete,compact"). In this case, old segments will be discarded per the retention time and size configuration, while retained segments will be compacted.
   
   What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org