You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by maropu <gi...@git.apache.org> on 2017/01/25 16:07:23 UTC
[GitHub] incubator-hivemall pull request #27: [HIVEMALL-36] Refactor each_top_k
GitHub user maropu opened a pull request:
https://github.com/apache/incubator-hivemall/pull/27
[HIVEMALL-36] Refactor each_top_k
## What changes were proposed in this pull request?
This pr fixed wrongly-handling code for logical plans in `each_top_k`.
Also, it removed the interface `def each_top_k(k: Int, group: String, score: String, args: String*)` for `each_top_k` because I think the other interface is more natural as Spark APIs.
## What type of PR is it?
Refactoring
### What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-36
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maropu/incubator-hivemall HIVEMALL-36
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hivemall/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 2940223acad62740aaa00d9e19cc706a031089da
Author: Takeshi YAMAMURO <li...@gmail.com>
Date: 2017-01-25T15:44:42Z
Refactor each_top_k
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #27: [HIVEMALL-36] Refactor each_top_k
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-hivemall/pull/27
[](https://coveralls.io/builds/9849255)
Coverage increased (+0.3%) to 36.14% when pulling **98ff0b90e0d47dc1695869a1347b276fac0881a0 on maropu:HIVEMALL-36** into **4688494418693de5b08dc0a4bd22685dbcf0b876 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall pull request #27: [HIVEMALL-36] Refactor each_top_k
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hivemall/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #27: [HIVEMALL-36] Refactor each_top_k
Posted by myui <gi...@git.apache.org>.
Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/27
@maropu LGTM. Please merge this PR and close the JIRA ticket.
BTW, `HiveUdfWithFeatureSuite` causes OOM again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #27: [HIVEMALL-36] Refactor each_top_k
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-hivemall/pull/27
[](https://coveralls.io/builds/9838793)
Coverage increased (+0.3%) to 36.14% when pulling **2940223acad62740aaa00d9e19cc706a031089da on maropu:HIVEMALL-36** into **4688494418693de5b08dc0a4bd22685dbcf0b876 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #27: [HIVEMALL-36] Refactor each_top_k
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-hivemall/pull/27
[](https://coveralls.io/builds/9852131)
Coverage remained the same at 35.842% when pulling **cceabc6aa1c7c2ce0f5164263dc0ce4750f69cb6 on maropu:HIVEMALL-36** into **e86c8a0bf3c448fa1642b4ad3f938e57d32f524b on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #27: [HIVEMALL-36] Refactor each_top_k
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-hivemall/pull/27
[](https://coveralls.io/builds/9851772)
Coverage increased (+0.01%) to 35.842% when pulling **4039f9e17d20f8a8fd804da461e0e2e63e3a6b90 on maropu:HIVEMALL-36** into **79f92f4f2c6458ccf4133744a1654a46cbbb56cc on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hivemall issue #27: [HIVEMALL-36] Refactor each_top_k
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/incubator-hivemall/pull/27
okay, I'll merge this, then I'll check the OOM issue in follow-up activities. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---