You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/05 08:16:25 UTC
[GitHub] [cloudstack] vladimirpetrov opened a new issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
vladimirpetrov opened a new issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
* Bug Report
##### COMPONENT NAME
~~~
UI
~~~
##### CLOUDSTACK VERSION
~~~
4.14
4.15 RC1
~~~
##### CONFIGURATION
N/A
##### OS / ENVIRONMENT
N/A
##### SUMMARY
The Images > ISOs page ignores the backend flag 'isextractable' and allows user to download an ISO even when it was uploaded with this setting unchecked.
##### STEPS TO REPRODUCE
~~~
1. Register (or upload) ISO image, leaving the 'Extractable' option unchecked.
~~~
~~~
2. Go to Images > ISOs > new ISO, wait until it's successfully installed and try to download it:
~~~
##### EXPECTED RESULTS
~~~
The download icon should be missing and this operation must be forbidden.
~~~
##### ACTUAL RESULTS
~~~
The UI ignores this flag, allowing user to download ISO images marked as non-extractable.
~~~
##### ADDITIONAL INFORMATION
Here is the request when registering a new ISO image - the isextractable flag is properly sent:
http ://10.10.2.113:8080/client/api/?url=http:%2F%2F10.5.1.128%2Fopenvm%2Fcloudstack%2Fiso%2FTinyCore-8.0.iso&name=Tiny+Core&displaytext=Tiny+Core&zoneid=-1&bootable=true&ostypeid=0b9e0c15-3bad-11eb-9ec8-1e00830138c0&**isextractable=false**&ispublic=false&isfeatured=false&command=registerIso&response=json
And this is the server response when preparing the details page - the same flag is properly sent from the server:
account: "admin"
bits: 64
bootable: true
checksum: "18a24183958339cb0508a9e27abd81494514469529bf1a4dd0cbc8a3c4d502a94400e6c58b6d54d5043eb2100946f6e85dd7032bc12642e4ab2e8907ed88dbcb"
created: "2020-12-11T15:23:18+0000"
crossZones: true
directdownload: false
displaytext: "Tiny Core"
domain: "ROOT"
domainid: "0b746f3a-3bad-11eb-9ec8-1e00830138c0"
id: "7c51f019-fbed-485d-a2f4-d2ca9e235e78"
isdynamicallyscalable: false
**isextractable: false**
isfeatured: false
ispublic: false
isready: true
name: "Tiny Core"
ostypeid: "0b9e0c15-3bad-11eb-9ec8-1e00830138c0"
ostypename: "Other Linux (64-bit)"
passwordenabled: false
size: 16777216
status: "Successfully Installed"
tags: []
url: "http://10.5.1.128/openvm/cloudstack/iso/TinyCore-8.0.iso"
zoneid: "b321c664-734a-4c98-9c4d-9a692d99f08e"
zonename: "ref-trl-2078-k-M7-rohit-yadav"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-773872722
why did you close this @andrijapanicsb , i see no comments indicating it isn't a problem anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb closed issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
andrijapanicsb closed issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-791906947
@vladimirpetrov can you check if in the modern UI we don't show the button to download now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-773925831
um... I don't recall doing it (probably accidental click)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-745862198
@vladimirpetrov can you test the user vs admin behaviour and revisit please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-744305260
Thanks @vladimirpetrov - since this is a known historic issue, let's fix in the next minor release or 4.16.0.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov edited a comment on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
vladimirpetrov edited a comment on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-747301918
I did, @rhtyd , we have the same problem on 4.15 RC2:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-745425643
@vladimirpetrov Did you test with a regular user account?
Admins can always download even the non-extractable templates....
If you register a public templat/ISO as root admin (non-extractable) - and then if the regular user fails to download it - then there is no bug. If the regular user can still download it - it's a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-747269454
@Spaceman1984 can you test against 4.15 RC2? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-744272942
@DaanHoogland I'm not really sure if it's only about the UI - perhaps the backend also should not allow extracting of an image even when UI allows it. It's always a good practice to have checks on both places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-745479334
Again, my 2 cents after testing with 4.14;
- root admin account can download all templates/ISOs, irrelevant if it's marked as Extractable or not
- If a template is not extractable, regular user accounts can not download it - see images below:
(Even more, when the template is marked as public and extractable (ISO uploaded by the root admin) - _the regular user can not download it (this looks like a bug, indeed),_ while the user can download it's own uploaded ISO)
So, I don't think the reported issues is a bug, but a design behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland edited a comment on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
DaanHoogland edited a comment on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-745862198
@vladimirpetrov can you test the user vs admin behaviour and revisit please? and as you stated this is not UI, can you test it using the API, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-744275046
I just tested this on 4.14 and we have the same behavior there - using the legacy UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-773872722
why did you close this @andrijapanicsb , i see no comments indicating it isn't a problem anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Spaceman1984 commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-747251094
I tested the UI with master and the behavior is different, an admin does not have the download icon for an iso that is not marked as extractable. The question now is - is master or 4.13/4.14 broken?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb closed issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
andrijapanicsb closed issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-743286570
@vladimirpetrov this seems a primate bug, as we have not merged it in the main tree yet can you submit it there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on issue #4535: UI allows ISO images, uploaded/registered as not extractable to be downloaded
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #4535:
URL: https://github.com/apache/cloudstack/issues/4535#issuecomment-747301918
I did, @rhtyd , the issue is there:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org