[jira] [Commented] (STORM-1051) Netty Client.java's flushMessages produces a NullPointerException

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803408#comment-14803408 ] 

ASF GitHub Bot commented on STORM-1051:
---------------------------------------

GitHub user schonfeld opened a pull request:

    https://github.com/apache/storm/pull/742

    [STORM-1051] Fix for flushMessagse NPE

    STORM-763 introduced a situation in which flushMessages could receive batch = null, in which case, an NPE is thrown because we weren't validating != null

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schonfeld/storm 0.10.x-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #742
    
----
commit bcc1cc6ce1b1455a68eae8f0b1d4ceafe93d8488
Author: Michael Schonfeld <mi...@schonfeld.org>
Date:   2015-09-17T15:57:07Z

    fix npe issue

----


> Netty Client.java's flushMessages produces a NullPointerException
> -----------------------------------------------------------------
>
>                 Key: STORM-1051
>                 URL: https://issues.apache.org/jira/browse/STORM-1051
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0, 0.9.6
>            Reporter: Michael Schonfeld
>            Assignee: Michael Schonfeld
>
> STORM-763 replaced `return batch != null && !batch.isEmpty();` with `if(batch.isEmpty())`... which means that if batch == null, a NullPointerException is thrown. Problem is, batch is often null, which means that 763 made Storm unusable...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)