Re: svn commit: r292397 - /httpd/httpd/branches/2.0.x/server/core.c

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

Although it took two commits, please comment on the following patch to
eliminate an 'unused variable' rv in some cases (happy to back out if
there are objections);

Index: server/core.c^M
===================================================================
--- server/core.c       (revision 292396)
+++ server/core.c       (working copy)
@@ -4485,9 +4485,10 @@
  static int core_pre_connection(conn_rec *c, void *csd)
  {
      core_net_rec *net = apr_palloc(c->pool, sizeof(*net));
+
+#ifdef AP_MPM_DISABLE_NAGLE_ACCEPTED_SOCK
      apr_status_t rv;

-#ifdef AP_MPM_DISABLE_NAGLE_ACCEPTED_SOCK
      /* BillS says perhaps this should be moved to the MPMs. Some OSes
       * allow listening socket attributes to be inherited by the
       * accept sockets which means this call only needs to be made

Thanks,

Bill

Re: svn commit: r292397 - /httpd/httpd/branches/2.0.x/server/core.c

[Jeff Trawick <tr...@gmail.com>]

On 9/29/05, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> Although it took two commits, please comment on the following patch to
> eliminate an 'unused variable' rv in some cases (happy to back out if
> there are objections);

keep it