You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Micah Kornfield (JIRA)" <ji...@apache.org> on 2019/06/24 14:16:00 UTC

[jira] [Resolved] (ARROW-5706) [Java] Remove type conversion in getValidityBufferValueCapacity

     [ https://issues.apache.org/jira/browse/ARROW-5706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Micah Kornfield resolved ARROW-5706.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 0.14.0

Issue resolved by pull request 4672
[https://github.com/apache/arrow/pull/4672]

> [Java] Remove type conversion in getValidityBufferValueCapacity
> ---------------------------------------------------------------
>
>                 Key: ARROW-5706
>                 URL: https://issues.apache.org/jira/browse/ARROW-5706
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Ji Liu
>            Assignee: Ji Liu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 0.14.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now implementation of getValidityBufferValueCapacity is:
> (int) (validityBuffer.capacity() * 8L)
> Seems no need to convert it to Long then convert it back to Int, just replace with:
> validityBuffer.capacity() * 8
> VariableWidthVectorBenchmarks#getValueCapacity shows the performance:
> Before:
> avgt 5 5.731 ± 0.160 ns/op
> After:
> avgt 5 5.124 ± 0.125 ns/op



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)