[GitHub] [incubator-pekko-http] jrudolph commented on pull request #19: put license and notice in all jars

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on PR #19:
URL: https://github.com/apache/incubator-pekko-http/pull/19#issuecomment-1432778205

   > From my understanding, we do not need to include HPack license - or even include details in our NOTICE file
   > 
   >     * it is Apache licensed
   > 
   >     * [twitter/hpack](https://github.com/twitter/hpack) has no NOTICE so we don't have copy that non-existent notice into our notice
   
   Not sure I fully agree. 
   
    * We should note somewhere that we included code and the notice file seems a good place
    * Since we are adapting akka-http we still have to keep akka-http's NOTICE file (based on the Apache License terms), so we cannot just delete it because we think the information is not useful to keep...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org