You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/27 06:18:01 UTC

[GitHub] [fineract] vorburger commented on a change in pull request #1361: FINERACT-1169 fixed credit bureau Loan-product mapping module

vorburger commented on a change in pull request #1361:
URL: https://github.com/apache/fineract/pull/1361#discussion_r512439405



##########
File path: fineract-provider/src/main/resources/sql/migrations/core_db/V327__creditbureau_configuration.sql
##########
@@ -66,7 +66,7 @@ CREATE TABLE `m_creditbureau_loanproduct_mapping` (
   `is_creditcheck_mandatory` tinyint DEFAULT NULL,
   `skip_creditcheck_in_failure` tinyint DEFAULT NULL,
   `stale_period` INT DEFAULT NULL,
-  `is_active` tinyint DEFAULT NULL,
+  `isActive` tinyint DEFAULT NULL,

Review comment:
       @nikpawar89 @rrpawar96 even on the develop branch we should never update existing SQL migration scripts.. think about it, if you have an existing DB, this script  won't re-run (because Flyway thinks tgat 327 already ran) - and then your code would fail.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org