svn commit: r1082838 - /subversion/trunk/subversion/libsvn_diff/parse-diff.c

[st...@apache.org]

Author: stylesen
Date: Fri Mar 18 07:47:07 2011
New Revision: 1082838

URL: http://svn.apache.org/viewvc?rev=1082838&view=rev
Log:
Follow up r1079686.

* subversion/libsvn_diff/parse-diff.c
  (scan_eol): Do not initialize boolean variable and calculate size of
   the buffer properly.

See - http://svn.haxx.se/dev/archive-2011-03/0487.shtml

Suggested by: danielsh

Modified:
    subversion/trunk/subversion/libsvn_diff/parse-diff.c

Modified: subversion/trunk/subversion/libsvn_diff/parse-diff.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_diff/parse-diff.c?rev=1082838&r1=1082837&r2=1082838&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_diff/parse-diff.c (original)
+++ subversion/trunk/subversion/libsvn_diff/parse-diff.c Fri Mar 18 07:47:07 2011
@@ -287,14 +287,14 @@ scan_eol(const char **eol, apr_file_t *f
     {
       char buf[256];
       apr_size_t len;
-      svn_boolean_t eof = FALSE;
+      svn_boolean_t eof;
 
       if (total_len >= max_len)
         break;
 
       len = sizeof(buf) - 1 < (max_len - total_len) ? sizeof(buf) - 1
                                                     : (max_len - total_len);
-      SVN_ERR(svn_io_file_read_full2(file, buf, sizeof(buf) - 1, &len, &eof,
+      SVN_ERR(svn_io_file_read_full2(file, buf, sizeof(buf), &len, &eof,
                                      pool));
 
       if (len == 0)