You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by ka...@apache.org on 2018/07/12 13:35:27 UTC
[2/4] storm git commit: STORM-3134: addressed review comments
STORM-3134: addressed review comments
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/f237f320
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/f237f320
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/f237f320
Branch: refs/heads/master
Commit: f237f3207afa6761c1948e0b0af33175337a3924
Parents: aa4d93c
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Authored: Thu Jul 5 11:30:12 2018 -0500
Committer: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Committed: Thu Jul 5 11:30:12 2018 -0500
----------------------------------------------------------------------
.../jvm/org/apache/storm/command/UploadCredentials.java | 10 ++++++++++
1 file changed, 10 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/f237f320/storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java b/storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java
index 7eb89f2..101f8f2 100644
--- a/storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java
+++ b/storm-core/src/jvm/org/apache/storm/command/UploadCredentials.java
@@ -86,6 +86,16 @@ public class UploadCredentials {
if (!extra.isEmpty()) {
LOG.warn("The topology {} is not using {} but they were included here.", topologyId, extra);
}
+
+ //Now check for autoCreds that are missing from the command line, but only if the
+ // command line is used.
+ if (topoCreds != null) {
+ Set<String> missing = new HashSet<>(topoCreds);
+ missing.removeAll(clCreds);
+ if (!missing.isEmpty()) {
+ LOG.warn("The topology {} is using {} but they were not included here.", topologyId, missing);
+ }
+ }
}
break;
}