You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "boyjoy1127 (via GitHub)" <gi...@apache.org> on 2023/04/10 02:27:58 UTC
[GitHub] [shardingsphere] boyjoy1127 opened a new pull request, #25074: Refactor SQLFederationRowEnumerator
boyjoy1127 opened a new pull request, #25074:
URL: https://github.com/apache/shardingsphere/pull/25074
Refs #19937.
Changes proposed in this pull request:
- use stream query instead of memory query.
---
Before committing this PR, I'm sure that I have checked the following options:
- [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [X] I have self-reviewed the commit code.
- [X] I have (or in comment I request) added corresponding labels for the pull request.
- [X] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [X] I have made corresponding changes to the documentation.
- [X] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #25074: Refactor SQLFederationRowEnumerator
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #25074:
URL: https://github.com/apache/shardingsphere/pull/25074#issuecomment-1567687916
Hi @boyjoy1127
Any update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor SQLFederationRowEnumerator [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed pull request #25074: Refactor SQLFederationRowEnumerator
URL: https://github.com/apache/shardingsphere/pull/25074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor SQLFederationRowEnumerator [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #25074:
URL: https://github.com/apache/shardingsphere/pull/25074#issuecomment-1763897402
Since this pr has long time no reponse, I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 134130 commented on a diff in pull request #25074: Refactor SQLFederationRowEnumerator
Posted by "134130 (via GitHub)" <gi...@apache.org>.
134130 commented on code in PR #25074:
URL: https://github.com/apache/shardingsphere/pull/25074#discussion_r1327933490
##########
kernel/sql-federation/executor/core/src/main/java/org/apache/shardingsphere/sqlfederation/executor/FilterableTableScanExecutor.java:
##########
@@ -252,28 +252,16 @@ private Collection<RexNode> createProjections(final int[] projects, final RelBui
private AbstractEnumerable<Object[]> createEnumerable(final MergedResult mergedResult, final QueryResultMetaData metaData, final Collection<Statement> statements) throws SQLException {
// TODO remove getRows when mergedResult support JDBC first method
Review Comment:
Do this TODO comment is valid after this refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org