You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/12/25 12:57:19 UTC

[jira] Created: (MNG-3941) Execution project is accessible to later mojo executions

Execution project is accessible to later mojo executions
--------------------------------------------------------

                 Key: MNG-3941
                 URL: http://jira.codehaus.org/browse/MNG-3941
             Project: Maven 2
          Issue Type: Bug
          Components: Plugins and Lifecycle
    Affects Versions: 2.1.0-M1, 2.0.9
            Reporter: Benjamin Bentmann
            Priority: Minor


As MSHADE-44 shows, the execution project created for a mojo execution that forks the lifecycle is still accessible to later mojo executions althought these later mojo executions did not request a forked lifecycle. While mojos should not depend on the execution project unless they fork by themselves, the core should probably wipe out any mojo-related state bits from the {{MavenProject}} instance before executing another mojo.

IIRC, the same applies to the project dependencies available to a mojo. Currently, badly written mojos can still get proper dependency sets if some other mojo triggered dependency resolution before. For deterministic behavior, mojos should only see those deps that they requested themselves via {{{@requiresDependencyResolution}}. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3941) Execution project is accessible to later mojo executions

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-3941:
------------------------------

    Fix Version/s: 2.1.0-M3

> Execution project is accessible to later mojo executions
> --------------------------------------------------------
>
>                 Key: MNG-3941
>                 URL: http://jira.codehaus.org/browse/MNG-3941
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>             Fix For: 2.1.0-M3
>
>
> As MSHADE-44 shows, the execution project created for a mojo execution that forks the lifecycle is still accessible to later mojo executions althought these later mojo executions did not request a forked lifecycle. While mojos should not depend on the execution project unless they fork by themselves, the core should probably wipe out any mojo-related state bits from the {{MavenProject}} instance before executing another mojo.
> IIRC, the same applies to the project dependencies available to a mojo. Currently, badly written mojos can still get proper dependency sets if some other mojo triggered dependency resolution before. For deterministic behavior, mojos should only see those deps that they requested themselves via {{{@requiresDependencyResolution}}. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3941) Execution project is accessible to later mojo executions

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-3941:
------------------------------

    Fix Version/s:     (was: 2.1.0)
                   2.2.0-M1

> Execution project is accessible to later mojo executions
> --------------------------------------------------------
>
>                 Key: MNG-3941
>                 URL: http://jira.codehaus.org/browse/MNG-3941
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Benjamin Bentmann
>            Priority: Minor
>             Fix For: 2.2.0-M1
>
>
> As MSHADE-44 shows, the execution project created for a mojo execution that forks the lifecycle is still accessible to later mojo executions althought these later mojo executions did not request a forked lifecycle. While mojos should not depend on the execution project unless they fork by themselves, the core should probably wipe out any mojo-related state bits from the {{MavenProject}} instance before executing another mojo.
> IIRC, the same applies to the project dependencies available to a mojo. Currently, badly written mojos can still get proper dependency sets if some other mojo triggered dependency resolution before. For deterministic behavior, mojos should only see those deps that they requested themselves via {{{@requiresDependencyResolution}}. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-3941) Execution project is accessible to later mojo executions

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-3941.
----------------------------------

         Assignee: Benjamin Bentmann
       Resolution: Fixed
    Fix Version/s:     (was: 2.3.0-M1)
                   3.0-alpha-3

> Execution project is accessible to later mojo executions
> --------------------------------------------------------
>
>                 Key: MNG-3941
>                 URL: http://jira.codehaus.org/browse/MNG-3941
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 2.0.9, 2.1.0-M1
>            Reporter: Benjamin Bentmann
>            Assignee: Benjamin Bentmann
>            Priority: Minor
>             Fix For: 3.0-alpha-3
>
>
> As MSHADE-44 shows, the execution project created for a mojo execution that forks the lifecycle is still accessible to later mojo executions althought these later mojo executions did not request a forked lifecycle. While mojos should not depend on the execution project unless they fork by themselves, the core should probably wipe out any mojo-related state bits from the {{MavenProject}} instance before executing another mojo.
> IIRC, the same applies to the project dependencies available to a mojo. Currently, badly written mojos can still get proper dependency sets if some other mojo triggered dependency resolution before. For deterministic behavior, mojos should only see those deps that they requested themselves via {{{@requiresDependencyResolution}}. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira