You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2020/10/19 12:43:29 UTC
Re: Review Request 72891: RANGER-2996 : Add search by Roles and
Auditor user should be able to see "Roles" tab.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72891/
-----------------------------------------------------------
(Updated Oct. 19, 2020, 12:43 p.m.)
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-2996
https://issues.apache.org/jira/browse/RANGER-2996
Repository: ranger
Description
-------
Search by Roles Name on
1) Report page and Policy listing page.
Auditor user should be able to see Roles tab.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 6ef5fe5
security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 8528652
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java be3bf2f
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java bcbca09
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 0cf9295
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js 42722b0
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js df052cb
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4d58b21
security-admin/src/main/webapp/templates/common/ServiceManagerSidebarLayout_tmpl.html 7907834
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 99d04cb
Diff: https://reviews.apache.org/r/72891/diff/2/
Changes: https://reviews.apache.org/r/72891/diff/1-2/
Testing
-------
Testing is in progress.
Thanks,
Nitin Galave
Re: Review Request 72891: RANGER-2996 : Add search by Roles and
Auditor user should be able to see "Roles" tab.
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72891/#review222125
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Oct. 20, 2020, 12:56 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72891/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2020, 12:56 p.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2996
> https://issues.apache.org/jira/browse/RANGER-2996
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Search by Roles Name on
> 1) Report page and Policy listing page.
>
> Auditor user should be able to see Roles tab.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 6ef5fe5
> security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 8528652
> security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java be3bf2f
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java bcbca09
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 0cf9295
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js 42722b0
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js df052cb
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4d58b21
> security-admin/src/main/webapp/templates/common/ServiceManagerSidebarLayout_tmpl.html 7907834
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 99d04cb
>
>
> Diff: https://reviews.apache.org/r/72891/diff/2/
>
>
> Testing
> -------
>
> Tested that
> Admin Role user:
> Check he is able to see all the roles.
> Check he is able to create new role
> Check he is able to edit role
> Check he is able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is able to create policy using roles.
>
> Auditer Role user:
> Role Listing
> Check he is able to see all the roles.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is not able to create policy using roles
>
> User Role user:
> Check he is not able to see all the roles.
> Check he is able to see only the roles assigned to him.
> Check he is able to see only the roles assigned to the group he belongs.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to search all the roles in policy item listing.
> Check he is not able to create policy using roles
> Check he is able to create policy using roles when delegate admin
> Check he is able to create policy using roles when service admin
>
> Keyadmin Role user :
> Role Listing
> Check he is not able to see all the roles.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is not able to create policy using roles
>
> Kmsauditer Role user :
> Role Listing
> Check he is not able to see all the roles.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is not able to create policy using roles
>
> when a user(testuser1) is assigned in one group(group1) and that group(group1) is added in any role(role1) then the user should see that role
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 72891: RANGER-2996 : Add search by Roles and
Auditor user should be able to see "Roles" tab.
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72891/#review222090
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Oct. 20, 2020, 12:56 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72891/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2020, 12:56 p.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2996
> https://issues.apache.org/jira/browse/RANGER-2996
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Search by Roles Name on
> 1) Report page and Policy listing page.
>
> Auditor user should be able to see Roles tab.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 6ef5fe5
> security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 8528652
> security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java be3bf2f
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java bcbca09
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 0cf9295
> security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js 42722b0
> security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js df052cb
> security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4d58b21
> security-admin/src/main/webapp/templates/common/ServiceManagerSidebarLayout_tmpl.html 7907834
> security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 99d04cb
>
>
> Diff: https://reviews.apache.org/r/72891/diff/2/
>
>
> Testing
> -------
>
> Tested that
> Admin Role user:
> Check he is able to see all the roles.
> Check he is able to create new role
> Check he is able to edit role
> Check he is able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is able to create policy using roles.
>
> Auditer Role user:
> Role Listing
> Check he is able to see all the roles.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is not able to create policy using roles
>
> User Role user:
> Check he is not able to see all the roles.
> Check he is able to see only the roles assigned to him.
> Check he is able to see only the roles assigned to the group he belongs.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to search all the roles in policy item listing.
> Check he is not able to create policy using roles
> Check he is able to create policy using roles when delegate admin
> Check he is able to create policy using roles when service admin
>
> Keyadmin Role user :
> Role Listing
> Check he is not able to see all the roles.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is not able to create policy using roles
>
> Kmsauditer Role user :
> Role Listing
> Check he is not able to see all the roles.
> Check he is not able to create new role
> Check he is not able to edit role
> Check he is not able to delete role
>
> Report Page
> Check he is able to see all the roles in search listing.
> Check he is able search using roles
>
> Policy page
> Check he is able to see all the roles in policy item listing.
> Check he is not able to create policy using roles
>
> when a user(testuser1) is assigned in one group(group1) and that group(group1) is added in any role(role1) then the user should see that role
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 72891: RANGER-2996 : Add search by Roles and
Auditor user should be able to see "Roles" tab.
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72891/
-----------------------------------------------------------
(Updated Oct. 20, 2020, 12:56 p.m.)
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-2996
https://issues.apache.org/jira/browse/RANGER-2996
Repository: ranger
Description
-------
Search by Roles Name on
1) Report page and Policy listing page.
Auditor user should be able to see Roles tab.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 6ef5fe5
security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 8528652
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java be3bf2f
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java bcbca09
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 0cf9295
security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js 42722b0
security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js df052cb
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 4d58b21
security-admin/src/main/webapp/templates/common/ServiceManagerSidebarLayout_tmpl.html 7907834
security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html 99d04cb
Diff: https://reviews.apache.org/r/72891/diff/2/
Testing (updated)
-------
Tested that
Admin Role user:
Check he is able to see all the roles.
Check he is able to create new role
Check he is able to edit role
Check he is able to delete role
Report Page
Check he is able to see all the roles in search listing.
Check he is able search using roles
Policy page
Check he is able to see all the roles in policy item listing.
Check he is able to create policy using roles.
Auditer Role user:
Role Listing
Check he is able to see all the roles.
Check he is not able to create new role
Check he is not able to edit role
Check he is not able to delete role
Report Page
Check he is able to see all the roles in search listing.
Check he is able search using roles
Policy page
Check he is able to see all the roles in policy item listing.
Check he is not able to create policy using roles
User Role user:
Check he is not able to see all the roles.
Check he is able to see only the roles assigned to him.
Check he is able to see only the roles assigned to the group he belongs.
Check he is not able to create new role
Check he is not able to edit role
Check he is not able to delete role
Report Page
Check he is able to see all the roles in search listing.
Check he is able search using roles
Policy page
Check he is able to search all the roles in policy item listing.
Check he is not able to create policy using roles
Check he is able to create policy using roles when delegate admin
Check he is able to create policy using roles when service admin
Keyadmin Role user :
Role Listing
Check he is not able to see all the roles.
Check he is not able to create new role
Check he is not able to edit role
Check he is not able to delete role
Report Page
Check he is able to see all the roles in search listing.
Check he is able search using roles
Policy page
Check he is able to see all the roles in policy item listing.
Check he is not able to create policy using roles
Kmsauditer Role user :
Role Listing
Check he is not able to see all the roles.
Check he is not able to create new role
Check he is not able to edit role
Check he is not able to delete role
Report Page
Check he is able to see all the roles in search listing.
Check he is able search using roles
Policy page
Check he is able to see all the roles in policy item listing.
Check he is not able to create policy using roles
when a user(testuser1) is assigned in one group(group1) and that group(group1) is added in any role(role1) then the user should see that role
Thanks,
Nitin Galave