You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/03/02 13:40:44 UTC
[GitHub] [ignite] Mmuzaf opened a new pull request #7486: IGNITE-12733:
TransmissionHandler can now notify user listeners when it ends
Mmuzaf opened a new pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] xtern commented on a change in pull request #7486:
IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r388843078
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/managers/communication/TransmissionHandler.java
##########
@@ -40,6 +40,15 @@
* {@link TransmissionPolicy#CHUNK} the <em>#chunkHandler()</em> will be picked up.
*/
public interface TransmissionHandler {
+ /**
+ * The end of the handled transmission. This means that all resources associated with previously opened
+ * session is freed and can be reused. Generally, it means that transmission topic from now can
+ * safely accept new files.
+ *
+ * @param rmtNodeId Remote node id from which the source request comes from.
+ */
+ public void onEnd(UUID rmtNodeId);
Review comment:
As I can see. this method is not mandatory - maybe it’s worth adding a default implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] xtern commented on a change in pull request #7486:
IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r388843078
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/managers/communication/TransmissionHandler.java
##########
@@ -40,6 +40,15 @@
* {@link TransmissionPolicy#CHUNK} the <em>#chunkHandler()</em> will be picked up.
*/
public interface TransmissionHandler {
+ /**
+ * The end of the handled transmission. This means that all resources associated with previously opened
+ * session is freed and can be reused. Generally, it means that transmission topic from now can
+ * safely accept new files.
+ *
+ * @param rmtNodeId Remote node id from which the source request comes from.
+ */
+ public void onEnd(UUID rmtNodeId);
Review comment:
As I can see. this method is not mandatory - maybe it’s worth adding a default implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7486:
IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r387846291
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/managers/communication/TransmissionHandler.java
##########
@@ -40,6 +40,15 @@
* {@link TransmissionPolicy#CHUNK} the <em>#chunkHandler()</em> will be picked up.
*/
public interface TransmissionHandler {
+ /**
+ * The end of the handled transmission. This means that all resources associated with previously opened
+ * session are freed and can be reused. Generally, it means that transmission topic from now can
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] xtern commented on a change in pull request #7486:
IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r387799642
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/managers/communication/TransmissionHandler.java
##########
@@ -40,6 +40,15 @@
* {@link TransmissionPolicy#CHUNK} the <em>#chunkHandler()</em> will be picked up.
*/
public interface TransmissionHandler {
+ /**
+ * The end of the handled transmission. This means that all resources associated with previously opened
+ * session are freed and can be reused. Generally, it means that transmission topic from now can
Review comment:
"session is freed"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] Mmuzaf merged pull request #7486: IGNITE-12733:
TransmissionHandler can now notify user listeners when it ends
Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] Mmuzaf commented on a change in pull request #7486:
IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r387846357
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java
##########
@@ -2835,7 +2835,11 @@ private void receiveFromChannel(
boolean exit = in.readBoolean();
if (exit) {
- rcvCtxs.remove(topic);
+ ReceiverContext rcv0 = rcvCtxs.remove(topic);
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] xtern commented on a change in pull request #7486:
IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #7486: IGNITE-12733: TransmissionHandler can now notify user listeners when it ends
URL: https://github.com/apache/ignite/pull/7486#discussion_r387805861
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoManager.java
##########
@@ -2835,7 +2835,11 @@ private void receiveFromChannel(
boolean exit = in.readBoolean();
if (exit) {
- rcvCtxs.remove(topic);
+ ReceiverContext rcv0 = rcvCtxs.remove(topic);
Review comment:
Why not name this variable simply "rcv" (instead of rcv0)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services