[GitHub] [mynewt-core] kasjer commented on a change in pull request #2403: Detect connected programmer to download and debug firmware

[GitBox <gi...@apache.org>]

kasjer commented on a change in pull request #2403:
URL: https://github.com/apache/mynewt-core/pull/2403#discussion_r516953393



##########
File path: hw/scripts/common.sh
##########
@@ -76,3 +76,27 @@ parse_extra_jtag_cmd() {
     echo $NEW_EXTRA_JTAG_CMD
     EXTRA_JTAG_CMD=$NEW_EXTRA_JTAG_CMD
 }
+
+# Try to detect connnected programmers
+detect_programmer() {
+
+    # scan USB for well-known VID:PID
+    USB_DEV=$(ls /sys/bus/hid/devices)

Review comment:
       Are you sure that _stlink_ and _jlink_ are **HID** devices.
   It does not show up on my Linux (for Windows there is no such folder but we can leave it for now).
   `lsusb` on the other hand does show instances of stlink, jlink and dap.
   Maybe command is valid for Mac?

##########
File path: hw/scripts/common.sh
##########
@@ -76,3 +76,27 @@ parse_extra_jtag_cmd() {
     echo $NEW_EXTRA_JTAG_CMD
     EXTRA_JTAG_CMD=$NEW_EXTRA_JTAG_CMD
 }
+
+# Try to detect connnected programmers

Review comment:
       typo in `connnected`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org