You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/24 14:38:22 UTC

[GitHub] [tvm] giuseros commented on a change in pull request #6949: [TF frontend] add support for StridedSlice to input a single constant

giuseros commented on a change in pull request #6949:
URL: https://github.com/apache/tvm/pull/6949#discussion_r529593591



##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -1599,6 +1599,9 @@ def _impl(inputs, attr, params, mod):
         data_shape = get_const_tuple(in_type.checked_type.shape)
         data_dim = len(data_shape)
         stride_dim = len(stride)
+        if data_dim == 0 and isinstance(inputs[0], _expr.Constant):

Review comment:
       Cool, I didn't know that! I would still add a test to show when this situation arises (just to make sure that branch is covered). What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org