You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2008/07/18 15:48:31 UTC
[jira] Created: (HADOOP-3789) Include more detail in the exception
message when a streaming task fails
Include more detail in the exception message when a streaming task fails
------------------------------------------------------------------------
Key: HADOOP-3789
URL: https://issues.apache.org/jira/browse/HADOOP-3789
Project: Hadoop Core
Issue Type: Improvement
Components: contrib/streaming
Reporter: Tom White
Fix For: 0.19.0
When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3789) Include more detail in the exception
message when a streaming task fails
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3789:
----------------------------------
Status: Open (was: Patch Available)
Canceling until Chris' comments are addressed.
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789-v2.patch, hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3789) Include more detail in the exception
message when a streaming task fails
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-3789:
------------------------------
Status: Patch Available (was: Open)
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789-v2.patch, hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3789) Include more detail in the
exception message when a streaming task fails
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625583#action_12625583 ]
Chris Douglas commented on HADOOP-3789:
---------------------------------------
Just a few nits:
* Instead of {{stderrStatus.delete(0, stderrStatus.length())}}, {{stderrStatus.setLength(0)}} should do the same thing. The former should just make a call to System.arraycopy- which won't do anything- but the latter is a little more readable.
* Instead of appending to the buffer and copying over the excess, stderrStatusLimit might be enforced more strictly by doing the length check and delete before the append of lineStr
* It looks like the buffer size config gets thrown away, instead of being assigned to stderrStatusLimit:
{noformat}
@@ -122,6 +122,7 @@
fs_ = FileSystem.get(job_);
nonZeroExitIsFailure_ = job_.getBoolean("stream.non.zero.exit.is.failure", true);
+ job_.getInt("stream.stderr.capture.limit", 2048);
doPipe_ = getDoPipe();
if (!doPipe_) return;
{noformat}
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789-v2.patch, hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3789) Include more detail in the exception
message when a streaming task fails
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-3789:
------------------------------
Attachment: hadoop-3789.patch
This patch extends PipeMapRed so that when a HadoopStreaming subprocess terminates with a nonzero exit code, and it's recognized as task failure due to stream.non.zero.exit.is.failure, the resulting Java exception carries recent subprocess stderr. "Recent" means more recent than the last "reporter:" line on stderr, limited to a maximum of 2K (configurable)
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3789) Include more detail in the exception
message when a streaming task fails
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White reassigned HADOOP-3789:
---------------------------------
Assignee: Tom White
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3789) Include more detail in the
exception message when a streaming task fails
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620923#action_12620923 ]
Hadoop QA commented on HADOOP-3789:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387803/hadoop-3789-v2.patch
against trunk revision 683671.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3037/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3037/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3037/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3037/console
This message is automatically generated.
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789-v2.patch, hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3789) Include more detail in the exception
message when a streaming task fails
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-3789:
------------------------------
Attachment: hadoop-3789-v2.patch
Synced with trunk.
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3789-v2.patch, hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3789) Include more detail in the exception
message when a streaming task fails
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-3789:
------------------------------
Fix Version/s: (was: 0.19.0)
0.20.0
> Include more detail in the exception message when a streaming task fails
> ------------------------------------------------------------------------
>
> Key: HADOOP-3789
> URL: https://issues.apache.org/jira/browse/HADOOP-3789
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/streaming
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.20.0
>
> Attachments: hadoop-3789-v2.patch, hadoop-3789.patch
>
>
> When debugging streaming programs, it would be useful to have the last few lines from stderr in the exception message (which is shown in the task's status display).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.