You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Christopher Elkins <ch...@scardini.com> on 2002/02/28 20:07:28 UTC
[collections] Some source files contain bad line-endings (was Re: [patch] Remove redundant public modifiers from interface methods)
On Thu, Feb 28, 2002 at 12:58:47PM -0600, Morgan Delagrange wrote:
> I'd prefer to not apply this patch. I also like having the public modifier,
> and being able to copy blocks of interface source code into abstract
> classes.
That's certainly your prerogative. However, I hope that doesn't preclude
fixing the line-ending problems described later in my email:
> > On Thu, 28 Feb 2002, Christopher Elkins wrote:
> > >
> > > While I'm thinking about it, here is a list of all the files containing
> bad
> > > line-endings:
> > >
> > > AbstractBag.java
> > > Bag.java
> > > BeanMap.java
> > > Closure.java
> > > DefaultMapEntry.java
> > > HashBag.java
> > > IteratorEnumeration.java
> > > MapUtils.java
> > > MultiHashMap.java
> > > MultiMap.java
> > > Predicate.java
> > > SingletonIterator.java
> > > SoftRefHashMap.java
> > > SortedBag.java
> > > TransformIterator.java
> > > Transformer.java
> > > TreeBag.java
> > >
> > > It'd be nice if someone could fix those before the forthcoming 2.0
> release.
> > >
> > > (And in case anyone thinks that there's something wrong in my local CVS
> > > setup, I suggest you take a look at the nightly builds. ;-)
--
Christopher Elkins
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] Some source files contain bad line-endings (was Re: [patch] Remove redundant public modifiers from interface methods)
Posted by James Strachan <ja...@yahoo.co.uk>.
From: "James Strachan" <ja...@yahoo.co.uk>
> ----- Original Message -----
> From: "Morgan Delagrange" <md...@yahoo.com>
> > Certainly, that's fine. I've already fixed the line endings on quite a
> few
> > classes, and I continue to fix them whenever I have to make significant
> > modifications to a class. Not to point fingers but James' checkins seem
> to
> > exhibit this problem often. Sorry James. ;)
>
> Yes I hold my hands up there - sorry everyone - I'll try figure out how to
> stop that happening again.
I'm just wondering what I'm doing wrong from a line-ending perspective.
I'm using Win2000 (I know I'm sorry), along with cygwin for cvs+ssh and
Forte as my editor. I thought CVS was meant to swizzle the line endings from
win <-> unix as checkin/checkouts happened?
Any ideas would be greatly appreciated...
James
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] Some source files contain bad line-endings (was Re: [patch] Remove redundant public modifiers from interface methods)
Posted by James Strachan <ja...@yahoo.co.uk>.
----- Original Message -----
From: "Morgan Delagrange" <md...@yahoo.com>
> Certainly, that's fine. I've already fixed the line endings on quite a
few
> classes, and I continue to fix them whenever I have to make significant
> modifications to a class. Not to point fingers but James' checkins seem
to
> exhibit this problem often. Sorry James. ;)
Yes I hold my hands up there - sorry everyone - I'll try figure out how to
stop that happening again.
James
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] Some source files contain bad line-endings (was Re: [patch] Remove redundant public modifiers from interface methods)
Posted by Morgan Delagrange <md...@yahoo.com>.
----- Original Message -----
From: "Christopher Elkins" <ch...@scardini.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Thursday, February 28, 2002 1:07 PM
Subject: [collections] Some source files contain bad line-endings (was Re:
[patch] Remove redundant public modifiers from interface methods)
> On Thu, Feb 28, 2002 at 12:58:47PM -0600, Morgan Delagrange wrote:
> > I'd prefer to not apply this patch. I also like having the public
modifier,
> > and being able to copy blocks of interface source code into abstract
> > classes.
>
> That's certainly your prerogative. However, I hope that doesn't preclude
> fixing the line-ending problems described later in my email:
>
Certainly, that's fine. I've already fixed the line endings on quite a few
classes, and I continue to fix them whenever I have to make significant
modifications to a class. Not to point fingers but James' checkins seem to
exhibit this problem often. Sorry James. ;)
- Morgan
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>