You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/31 07:12:52 UTC

[GitHub] [kafka] inponomarev edited a comment on pull request #9107: KAFKA-5488: KIP-418 implementation

inponomarev edited a comment on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-666749809


   ⚠️ Two differences with KIP specification, discussion needed⚠️ 
   
   1. Instead of multiple overloaded variants of `Branched.with` we now have `Branched.withFunction` and `Branched.withConsumer`. This is because of compiler warnings about overloading (`Function` and `Consumer` being indistinguishable when supplied as lambdas)
   
   2. 'Fully covariant' signatures like `Consumer<? super KStream<? super K, ? super V>>` don't work as expected. Used `Consumer<? super KStream<K, V>>` instead
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org