You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/03 01:33:23 UTC

[GitHub] [incubator-superset] suddjian opened a new pull request #8724: handle nulls in bar chart series/breakdown

suddjian opened a new pull request #8724: handle nulls in bar chart series/breakdown
URL: https://github.com/apache/incubator-superset/pull/8724
 
 
   ### CATEGORY
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   pandas removes `None` values when doing a groupby or a pivot, so we have to substitute a value for `None`s beforehand to allow null values in the bar chart's series or breakdown. There is already a value `"<NULL>"` being used in a few places, so I used that and centralized it in a new `constants.py` file.
   
   Fixes #8672 
   
   ### BEFORE/AFTER SCREENSHOTS
   <!--- Skip this if not applicable -->
   
   Before:
   
   <img width="1065" alt="Screen Shot 2019-12-02 at 5 18 33 PM" src="https://user-images.githubusercontent.com/1858430/70012230-b3583900-1528-11ea-8119-e8f9472bde8e.png">
   
   After:
   
   <img width="1064" alt="Screen Shot 2019-12-02 at 5 18 03 PM" src="https://user-images.githubusercontent.com/1858430/70012232-b521fc80-1528-11ea-8cf0-5edd4858bc6f.png">
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   `<NULL>`
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org