You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/09 19:59:58 UTC

[GitHub] [arrow] nevi-me opened a new pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

nevi-me opened a new pull request #9148:
URL: https://github.com/apache/arrow/pull/9148


   packed_simd has support for aarch64 for the functions that we are using.
   
   We can't test this feature yet, as we don't have aarch64 targets on our Rust CI yet. I however tested this on an ARM Mac device.
   I perceive the build risk to be low, as I'm only enabling `aarch64` in addition to the already used `x86_64` target in `packed_simd`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757359551


   @alamb @jorgecarleitao I see decent performance increases in benchmarks, but because my device gets hot running the benchmarks, I'm opting to view them as not too reliable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] codecov-io commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757361386


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=h1) Report
   > Merging [#9148](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=desc) (b67c47a) into [master](https://codecov.io/gh/apache/arrow/commit/08cccd68802c9ddc3ca0a5d4bad6e4ba382d74b4?el=desc) (08cccd6) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9148/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9148   +/-   ##
   =======================================
     Coverage   81.81%   81.82%           
   =======================================
     Files         214      214           
     Lines       51373    51373           
   =======================================
   + Hits        42033    42034    +1     
   + Misses       9340     9339    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `97.72% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FnZ3JlZ2F0ZS5ycw==) | `75.00% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FyaXRobWV0aWMucnM=) | `89.83% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `95.91% <ø> (ø)` | |
   | [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `78.75% <ø> (ø)` | |
   | [rust/arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC9iaXRfdXRpbC5ycw==) | `100.00% <ø> (ø)` | |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=footer). Last update [08cccd6...b67c47a](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] paddyhoran closed pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
paddyhoran closed pull request #9148:
URL: https://github.com/apache/arrow/pull/9148


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy edited a comment on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433133


   List some possible TODO/discussion about the SIMD feature:
   
   - Is it make sense to `enable the SIMD feature by default` [1]? I noticed that [servo/pathfinder](https://github.com/servo/pathfinder/blob/master/simd/Cargo.toml) enables SIMD by default.
   - Change static configure to `dynamic CPU feature detection`,  [core::arch dynamic-cpu-feature-detection](https://doc.rust-lang.org/core/arch/index.html#dynamic-cpu-feature-detection) explains.
   
   [1] Quote from https://en.wikipedia.org/wiki/SIMD:
   `Small-scale (64 or 128 bits) SIMD became popular on general-purpose CPUs in the early 1990s and continued through 1997 and later with Motion Video Instructions (MVI) for Alpha. SIMD instructions can be found, to one degree or another, on most CPUs`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433583


   > * Is it make sense to `enable the SIMD feature by default`
   
   No, because we want `stable` support by default, so simd is opt-in (ARROW-6717)
   
   > * Change static configure to `dynamic CPU feature detection`
   
   ARROW-6410 mainly deals with this.
   
   I'd opt not to document anything on this PR, as we have activity on JIRA documenting our use of SIMD


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] codecov-io commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757361386


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=h1) Report
   > Merging [#9148](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=desc) (b67c47a) into [master](https://codecov.io/gh/apache/arrow/commit/08cccd68802c9ddc3ca0a5d4bad6e4ba382d74b4?el=desc) (08cccd6) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9148/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9148   +/-   ##
   =======================================
     Coverage   81.81%   81.82%           
   =======================================
     Files         214      214           
     Lines       51373    51373           
   =======================================
   + Hits        42033    42034    +1     
   + Misses       9340     9339    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `97.72% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FnZ3JlZ2F0ZS5ycw==) | `75.00% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FyaXRobWV0aWMucnM=) | `89.83% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `95.91% <ø> (ø)` | |
   | [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `78.75% <ø> (ø)` | |
   | [rust/arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC9iaXRfdXRpbC5ycw==) | `100.00% <ø> (ø)` | |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=footer). Last update [08cccd6...b67c47a](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757420452


   How about merging `simd_x86` and `simd_aarch64` together, on the presumption that as long as we use the same library for both (`packed_simd_2` now, `stdsimd` later), we don't need to split the architectures?
   
   ```rust
       cfg_aliases! {
           simd: { all(any(target_arch = "x86", target_arch = "x86_64", target_arch = "aarch64"), feature = "simd") },
       }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] codecov-io edited a comment on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757361386


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=h1) Report
   > Merging [#9148](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=desc) (181a78d) into [master](https://codecov.io/gh/apache/arrow/commit/08cccd68802c9ddc3ca0a5d4bad6e4ba382d74b4?el=desc) (08cccd6) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9148/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9148      +/-   ##
   ==========================================
   - Coverage   81.81%   81.80%   -0.02%     
   ==========================================
     Files         214      214              
     Lines       51373    51383      +10     
   ==========================================
   + Hits        42033    42034       +1     
   - Misses       9340     9349       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/buffer.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyLnJz) | `97.72% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FnZ3JlZ2F0ZS5ycw==) | `75.00% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2FyaXRobWV0aWMucnM=) | `89.83% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `95.91% <ø> (ø)` | |
   | [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `78.75% <ø> (ø)` | |
   | [rust/arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC9iaXRfdXRpbC5ycw==) | `100.00% <ø> (ø)` | |
   | [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `65.00% <0.00%> (-16.25%)` | :arrow_down: |
   | [rust/datafusion/src/datasource/parquet.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL3BhcnF1ZXQucnM=) | `94.77% <0.00%> (-1.44%)` | :arrow_down: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9148/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=footer). Last update [08cccd6...181a78d](https://codecov.io/gh/apache/arrow/pull/9148?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757359389


   https://issues.apache.org/jira/browse/ARROW-11194


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757359389


   https://issues.apache.org/jira/browse/ARROW-11194


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433133


   List some possible TODOs/discussion about the SIMD feature:
   
   - Is it make sense to `enable the SIMD feature by default` [1]? I noticed that [servo/pathfinder](https://github.com/servo/pathfinder/blob/master/simd/Cargo.toml) enables SIMD by default.
   - Change static configure to `dynamic CPU feature detection`,  [core::arch dynamic-cpu-feature-detection](https://doc.rust-lang.org/core/arch/index.html#dynamic-cpu-feature-detection) explains.
   
   [1] Quote from https://en.wikipedia.org/wiki/SIMD:
   `Small-scale (64 or 128 bits) SIMD became popular on general-purpose CPUs in the early 1990s and continued through 1997 and later with Motion Video Instructions (MVI) for Alpha. SIMD instructions can be found, to one degree or another, on most CPUs`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757421222


   > How about merging `simd_x86` and `simd_aarch64` together, on the presumption that as long as we use the same library for both (`packed_simd_2` now, `stdsimd` later), we don't need to split the architectures?
   > 
   > ```rust
   >     cfg_aliases! {
   >         simd: { all(any(target_arch = "x86", target_arch = "x86_64", target_arch = "aarch64"), feature = "simd") },
   >     }
   > ```
   
   +1 because the codes make no difference for all targets


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me edited a comment on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
nevi-me edited a comment on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757433583


   > * Is it make sense to `enable the SIMD feature by default`
   
   No, because we want `stable` support by default, so simd is opt-in (ARROW-6717)
   
   > * Change static configure to `dynamic CPU feature detection`
   
   ARROW-6410 mainly deals with this.
   
   I'd opt not to document anything on this PR, as we have activity on JIRA documenting our use of SIMD.
   In the long run, we'd likely want SIMD to become stable, so that we can more freely implement SIMD versions of our code, without the `nightly` constraint.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757418739


   #8891 added `simd_x86`.
   How about add `simd: { any(simd_x86, simd_aarch64) }` in this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757359551


   @alamb @jorgecarleitao I see decent performance increases in benchmarks, but because my device gets hot running the benchmarks, I'm opting to view them as not too reliable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mqy commented on pull request #9148: ARROW-11194: [Rust] Enable packed_simd for aarch64

Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9148:
URL: https://github.com/apache/arrow/pull/9148#issuecomment-757434194


   @nevi-me got it, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org