You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/29 06:54:55 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request #126: Add helm packaging to create_source_release.sh script
gyfora opened a new pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126
This is the logic I have used to create the first RC, formalizing in a script here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837150030
##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
--exclude ".travis.yml" \
. flink-kubernetes-operator-${RELEASE_VERSION}
+# Package sources
tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^ repository: .*# repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^ tag: .*# tag: ${commit_hash}#" helm/flink-operator/values.yaml
Review comment:
We are using commit hash as the image tag, not the `${RELEASE_VERSION}`. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837289433
##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
--exclude ".travis.yml" \
. flink-kubernetes-operator-${RELEASE_VERSION}
+# Package sources
tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^ repository: .*# repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^ tag: .*# tag: ${commit_hash}#" helm/flink-operator/values.yaml
Review comment:
You are correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837284682
##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
--exclude ".travis.yml" \
. flink-kubernetes-operator-${RELEASE_VERSION}
+# Package sources
tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^ repository: .*# repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^ tag: .*# tag: ${commit_hash}#" helm/flink-operator/values.yaml
Review comment:
The commit recorded in the RC is the commit of the release tag: https://github.com/apache/flink-kubernetes-operator/tree/release-0.1.0-rc2 seems to be correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837284682
##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
--exclude ".travis.yml" \
. flink-kubernetes-operator-${RELEASE_VERSION}
+# Package sources
tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^ repository: .*# repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^ tag: .*# tag: ${commit_hash}#" helm/flink-operator/values.yaml
Review comment:
The commit recorded in the RC is the commit of the release tag: https://github.com/apache/flink-kubernetes-operator/tree/release-0.1.0-rc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837151021
##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
--exclude ".travis.yml" \
. flink-kubernetes-operator-${RELEASE_VERSION}
+# Package sources
tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^ repository: .*# repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^ tag: .*# tag: ${commit_hash}#" helm/flink-operator/values.yaml
Review comment:
exactly, we publish the image build with the short commit hash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#issuecomment-1081530908
@wangyang0918 I also added the helm repo index generation logic so users can use the release as a helm repo as you linked for airflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837275903
##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
--exclude ".travis.yml" \
. flink-kubernetes-operator-${RELEASE_VERSION}
+# Package sources
tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^ repository: .*# repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^ tag: .*# tag: ${commit_hash}#" helm/flink-operator/values.yaml
Review comment:
It seems that the image tag in [rc2](https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-0.1.0-rc2/) is `260df17`. But I could not find this commit in release-0.1. Is this the expected behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on a change in pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
mbalassi commented on a change in pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126#discussion_r837152978
##########
File path: tools/releasing/create_source_release.sh
##########
@@ -77,10 +77,29 @@ rsync -a \
--exclude ".travis.yml" \
. flink-kubernetes-operator-${RELEASE_VERSION}
+# Package sources
tar czf ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz flink-kubernetes-operator-${RELEASE_VERSION}
gpg --armor --detach-sig ${RELEASE_DIR}/flink-kubernetes-operator-${RELEASE_VERSION}-src.tgz
+
+# Package helm chart
+commit_hash=$(git log -1 --pretty=format:%h)
+
+# TODO: We might want to be more specific here later on what to replace
+perl -pi -e "s#^ repository: .*# repository: ghcr.io/apache/flink-operator#" helm/flink-operator/values.yaml
+perl -pi -e "s#^ tag: .*# tag: ${commit_hash}#" helm/flink-operator/values.yaml
Review comment:
We can certainly improve this once we get some more experience with this, but currently this is the approach we can use for this preview release candidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #126: Add helm packaging to create_source_release.sh script
Posted by GitBox <gi...@apache.org>.
gyfora merged pull request #126:
URL: https://github.com/apache/flink-kubernetes-operator/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org