[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #373: GUACAMOLE-1538: Terminal shared libary follow-on fixes

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #373:
URL: https://github.com/apache/guacamole-server/pull/373#discussion_r812362332



##########
File path: src/protocols/kubernetes/client.c
##########
@@ -96,7 +96,7 @@ int guac_client_init(guac_client* client) {
     client->data = kubernetes_client;
 
     /* Init clipboard */
-    kubernetes_client->clipboard = guac_common_clipboard_alloc(GUAC_KUBERNETES_CLIPBOARD_MAX_LENGTH);
+    kubernetes_client->clipboard = guac_common_clipboard_alloc();

Review comment:
       I think allocation of this should be internal to the terminal. Thoughts?

##########
File path: src/protocols/kubernetes/argv.c
##########
@@ -21,6 +21,7 @@
 #include "argv.h"
 #include "kubernetes.h"
 #include "terminal/terminal.h"
+#include "terminal/terminal_priv.h"

Review comment:
       Why is the private internal header included here? I'd think it'd be included and required only by the terminal internals.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org