You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/09/21 02:42:01 UTC

[GitHub] [flink-connector-pulsar] tisonkun commented on a diff in pull request #59: [FLINK-32938] Replace pulsar admin calls

tisonkun commented on code in PR #59:
URL: https://github.com/apache/flink-connector-pulsar/pull/59#discussion_r1332377788


##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/sink/PulsarSinkBuilder.java:
##########
@@ -126,9 +123,11 @@ public class PulsarSinkBuilder<IN> {
      *
      * @param adminUrl The url for the PulsarAdmin.
      * @return this PulsarSinkBuilder.
+     * @deprecated this method will return builder directly

Review Comment:
   Perhaps add a link to this PR as background. But it's OK that we do it in a follow-up patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org