You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Zoltan Martonka (Code Review)" <ge...@cloudera.org> on 2023/08/09 11:13:29 UTC
[kudu-CR] [ubuntu-22.04] tsan build will compile on ubuntu 22.04
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20336
Change subject: [ubuntu-22.04] tsan build will compile on ubuntu 22.04
......................................................................
[ubuntu-22.04] tsan build will compile on ubuntu 22.04
There are 2 thing missing from llvm 11:
+ SIGSTKSZ is no longer a constant in the newer glibc, so caching it in a
static variable can result in a crash.
+ "/usr/bin/krb5-config --libs gssapi" brings the config "-flto=auto",
which is handled correctly by clang > 14.0. We can just igore it with
clang 11 for now.
Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch
A thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
A thirdparty/patches/llvm-ignore-flto-values.diff
4 files changed, 71 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/20336/1
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Overall looks good to me. Please address Ashwani's feedback regarding the information about the original changelist(s) from the LLVM upstream repo and maybe add the information about the TSAN build failure message.
http://gerrit.cloudera.org:8080/#/c/20336/1/thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch
File thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch:
PS1:
> No, it is just a speedup . I will merge the 2 patches, there is no reason t
Ah, I see. Calling the same function that returns the same result twice doesn't make much sense, so this update looks reasonable if that was the intent, indeed.
Thank you for the clarification.
Yep, merging these into a single patch would make more sense.
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
File thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch:
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@6
PS2, Line 6:
> nit: Remove whitespaces here and at lines 15, 30.
Ashwani, it's a patch file, and removing these spaces could break the patch utility when trying to apply this.
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@8
PS2, Line 8: // TODO(glider):
> Better to add information (commit id, gcc branch info, etc) about the patch
+1, but please add that information into the commit description, not this code itself. It's better to keep this code as close to the upstream version as possible.
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 18:22:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20336
to look at the new patch set (#5).
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
[thirdparty] fix TSAN build on Ubuntu 22.04
There are 2 things missing from llvm 11:
1. SIGSTKSZ is no longer a constant in the newer glibc, so caching it in a
static variable can result in a crash.
This causes the libunwind build to fail at configure:
"configure: error: cannot run C compiled programs."
The problem is that the conftest.c compile crashes.
Although the problem occurs at libunwind build first, it is an llvm
issue.
More info:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100114
+ "/usr/bin/krb5-config --libs gssapi" brings the config "-flto=auto",
which is ignored by newer clangs (starting from 14.0), but clang 11
still gives an error.
The problem occurs while building curl:
"configure: error: one or more libs available at link-time
are not available run-time"
But the error message is misleading: clang just dies with
unknown option.
See:
https://reviews.llvm.org/D99501
Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
A thirdparty/patches/llvm-ignore-flto-values.diff
3 files changed, 54 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/20336/5
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
[thirdparty] fix TSAN build on Ubuntu 22.04
There are 2 things missing from llvm 11:
1. SIGSTKSZ is no longer a constant in the newer glibc, so caching it in a
static variable can result in a crash.
This causes the libunwind build to fail at configure:
"configure: error: cannot run C compiled programs."
The problem is that the conftest.c compile crashes.
Although the problem occurs at libunwind build first, it is an llvm
issue.
More info:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100114
+ "/usr/bin/krb5-config --libs gssapi" brings the config "-flto=auto",
which is ignored by newer clangs (starting from 14.0), but clang 11
still gives an error.
The problem occurs while building curl:
"configure: error: one or more libs available at link-time
are not available run-time"
But the error message is misleading: clang just dies with
unknown option.
See:
https://reviews.llvm.org/D99501
Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Reviewed-on: http://gerrit.cloudera.org:8080/20336
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
A thirdparty/patches/llvm-ignore-flto-values.diff
3 files changed, 54 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20336
to look at the new patch set (#2).
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
[thirdparty] fix TSAN build on Ubuntu 22.04
There are 2 thing missing from llvm 11:
+ SIGSTKSZ is no longer a constant in the newer glibc, so caching it in a
static variable can result in a crash.
+ "/usr/bin/krb5-config --libs gssapi" brings the config "-flto=auto",
which is ignored by newer clangs (starting from 14.0), but clang 11 still gives an error.
Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
A thirdparty/patches/llvm-ignore-flto-values.diff
3 files changed, 54 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/20336/2
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
Patch Set 5: Verified+1
unrelated test failures in Java tests (TSAN) and AutoAddMasterTest.TestFailTabletCopy (ASAN)
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Aug 2023 20:34:01 +0000
Gerrit-HasComments: No
[kudu-CR] [ubuntu-22.04] tsan build will compile on ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [ubuntu-22.04] tsan build will compile on ubuntu 22.04
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG@7
PS1, Line 7: ubuntu-22.04
nit: thirdparty
http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG@7
PS1, Line 7: tsan build will compile on ubuntu 22.04
nit: fix TSAN build on Ubuntu 22.04
http://gerrit.cloudera.org:8080/#/c/20336/1//COMMIT_MSG@15
PS1, Line 15: is handled correctly by clang > 14.0
Are you trying to say that -flto=auto isn't handled correctly by CLANG < 15.0? Please update this sentence to be clearer.
http://gerrit.cloudera.org:8080/#/c/20336/1/thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch
File thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch:
PS1:
Are there any actual functional changes in this patch?
I'm just trying to understand: was the issue in calling GetAltStackSize() twice, so it returned different numbers each time? Or this patch doesn't actually fix anything?
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 09 Aug 2023 16:51:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/20336/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20336/2//COMMIT_MSG@9
PS2, Line 9: There are 2 thing missing from llvm 11:
For posterity, can you also add minimal error message that TSAN build throws?
Sometimes the error string doesn't directly point to the underlying problem so having a record of error string associated with fix can be of help.
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
File thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch:
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@6
PS2, Line 6:
nit: Remove whitespaces here and at lines 15, 30.
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@8
PS2, Line 8: // TODO(glider):
Better to add information (commit id, gcc branch info, etc) about the patch if this fix is derived.
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 15:30:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20336
to look at the new patch set (#3).
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
[thirdparty] fix TSAN build on Ubuntu 22.04
There are 2 thing missing from llvm 11:
1. SIGSTKSZ is no longer a constant in the newer glibc, so caching it in a
static variable can result in a crash.
This causes the libunwind build to fail at configure:
"configure: error: cannot run C compiled programs."
The problem is that the conftest.c compile crashes.
Altought the problem occurs at libunwind build first, it is an llvm
issue.
More info:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100114
+ "/usr/bin/krb5-config --libs gssapi" brings the config "-flto=auto",
which is ignored by newer clangs (starting from 14.0), but clang 11
still gives an error.
The problem occurs while building curl:
"configure: error: one or more libs available at link-time
are not available run-time"
But, the error message is misleading: clang just dies with
unknown option.
See:
https://reviews.llvm.org/D99501
Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
A thirdparty/patches/llvm-ignore-flto-values.diff
3 files changed, 54 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/20336/3
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20336/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20336/3//COMMIT_MSG@18
PS3, Line 18: Altought
nit: Although
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
File thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch:
http://gerrit.cloudera.org:8080/#/c/20336/2/thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch@6
PS2, Line 6:
> Ashwani, it's a patch file, and removing these spaces could break the patch
My bad! didn't realise it before. Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Aug 2023 08:16:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ubuntu-22.04] tsan build will compile on ubuntu 22.04
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [ubuntu-22.04] tsan build will compile on ubuntu 22.04
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20336/1/thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch
File thirdparty/patches/llvm-Address-D100645-comment-eliminate-double-stacksize-calc.patch:
PS1:
> Are there any actual functional changes in this patch?
No, it is just a speedup . I will merge the 2 patches, there is no reason to make this changes separately.
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Aug 2023 14:39:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Ashwani Raina, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20336
to look at the new patch set (#4).
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
[thirdparty] fix TSAN build on Ubuntu 22.04
There are 2 things missing from llvm 11:
1. SIGSTKSZ is no longer a constant in the newer glibc, so caching it in a
static variable can result in a crash.
This causes the libunwind build to fail at configure:
"configure: error: cannot run C compiled programs."
The problem is that the conftest.c compile crashes.
Altough the problem occurs at libunwind build first, it is an llvm
issue.
More info:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100114
+ "/usr/bin/krb5-config --libs gssapi" brings the config "-flto=auto",
which is ignored by newer clangs (starting from 14.0), but clang 11
still gives an error.
The problem occurs while building curl:
"configure: error: one or more libs available at link-time
are not available run-time"
But the error message is misleading: clang just dies with
unknown option.
See:
https://reviews.llvm.org/D99501
Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-Sanitizer-built-against-glibc-2_34-doesnt-work.patch
A thirdparty/patches/llvm-ignore-flto-values.diff
3 files changed, 54 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/20336/4
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [thirdparty] fix TSAN build on Ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20336 )
Change subject: [thirdparty] fix TSAN build on Ubuntu 22.04
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9493a9f7212c26a9cfc1e6a6015340cc5fbfdc5
Gerrit-Change-Number: 20336
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Aug 2023 19:20:29 +0000
Gerrit-HasComments: No